)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"4f25a3a2998953942be5d4ba9350bc4dd3ea7740","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Creating domain and filtering by parent_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We are allowing the creation of a domain with a parent_id and creating"},{"line_number":10,"context_line":"the list_domain filtering by the parent_id."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements bp reseller"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"da9b358b_365b8989","line":10,"updated":"2015-03-31 09:10:47.000000000","message":"Form this text, it is very unclear what the purpose of this patch is for, are we saying that we shouldn\u0027t be allowing this?  Also, we should not be mixing adding the parent_id filter to list_domain with the other things you are attempting here...","commit_id":"cf4a7a68a4ffa37879f0204ff2d017bcf2dffafc"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"edfe3d479f3cf576dea500a5783b8fb9e099ed1a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Creating domain and filtering by parent_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We are allowing the creation of a domain with a parent_id and creating"},{"line_number":10,"context_line":"the list_domain filtering by the parent_id."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements bp reseller"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"da9b358b_d029f738","line":10,"in_reply_to":"da9b358b_365b8989","updated":"2015-03-31 14:03:26.000000000","message":"Ok, we will rephrase this.","commit_id":"cf4a7a68a4ffa37879f0204ff2d017bcf2dffafc"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"207078bad12d3092dd75fcb144118ca07ba28ffa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Raildo Mascena de Sousa Filho \u003craildom@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-02 14:06:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating domain and filtering by parent_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* We are allowing the creation of subdomains passing a parent_id from an"},{"line_number":10,"context_line":"  existing domain"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baa041b7_d84dbc73","line":7,"updated":"2015-04-02 17:47:22.000000000","message":"Should reword this title to be something more explicit, e.g.:\n\nSupport creation of subdomains and domain filtering by parent_id","commit_id":"740d18d97e76432e0c821dc430d91644dbf43916"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"d587294d8ca1a2e798b3392878bc5004be56e21d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Raildo Mascena de Sousa Filho \u003craildom@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-02 14:06:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating domain and filtering by parent_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* We are allowing the creation of subdomains passing a parent_id from an"},{"line_number":10,"context_line":"  existing domain"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9aa53dc9_6ba9317b","line":7,"in_reply_to":"baa041b7_d84dbc73","updated":"2015-04-07 20:28:51.000000000","message":"Commit title cannot be bigger then 50 character, so I adapted your comment.","commit_id":"740d18d97e76432e0c821dc430d91644dbf43916"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"207078bad12d3092dd75fcb144118ca07ba28ffa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating domain and filtering by parent_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* We are allowing the creation of subdomains passing a parent_id from an"},{"line_number":10,"context_line":"  existing domain"},{"line_number":11,"context_line":"* We are allowing list sub_domain requesting the list_domain call"},{"line_number":12,"context_line":"  filtering by the parent_id"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baa041b7_b852f811","line":9,"updated":"2015-04-02 17:47:22.000000000","message":"I wouldn\u0027t user \"We are allowing\"....just say what it is we are adding...","commit_id":"740d18d97e76432e0c821dc430d91644dbf43916"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"d587294d8ca1a2e798b3392878bc5004be56e21d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating domain and filtering by parent_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* We are allowing the creation of subdomains passing a parent_id from an"},{"line_number":10,"context_line":"  existing domain"},{"line_number":11,"context_line":"* We are allowing list sub_domain requesting the list_domain call"},{"line_number":12,"context_line":"  filtering by the parent_id"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9aa53dc9_8baeb583","line":9,"in_reply_to":"baa041b7_b852f811","updated":"2015-04-07 20:28:51.000000000","message":"Done","commit_id":"740d18d97e76432e0c821dc430d91644dbf43916"}],"keystone/resource/controllers.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"4b2a5d37747213642787c4b8a2c873a704e9313f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        ref \u003d self.resource_api.create_domain(ref[\u0027id\u0027], ref, initiator)"},{"line_number":121,"context_line":"        return DomainV3.wrap_member(context, ref)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @controller.filterprotected(\u0027enabled\u0027, \u0027name\u0027, \u0027parent_id\u0027)"},{"line_number":124,"context_line":"    def list_domains(self, context, filters):"},{"line_number":125,"context_line":"        hints \u003d DomainV3.build_driver_hints(context, filters)"},{"line_number":126,"context_line":"        refs \u003d self.resource_api.list_domains(hints\u003dhints)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baa041b7_d62c80ad","line":123,"updated":"2015-04-02 10:38:20.000000000","message":"see my comment on the spec....I\u0027m questioning whether we should be able to do this via the domain API","commit_id":"50f6008f4c87a2b9c56e948fe536a18ffbc8c6e6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f6e028d93cebb01441f23f5e775eed5212acc408","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        ref \u003d self.resource_api.create_domain(ref[\u0027id\u0027], ref, initiator)"},{"line_number":121,"context_line":"        return DomainV3.wrap_member(context, ref)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @controller.filterprotected(\u0027enabled\u0027, \u0027name\u0027, \u0027parent_id\u0027)"},{"line_number":124,"context_line":"    def list_domains(self, context, filters):"},{"line_number":125,"context_line":"        hints \u003d DomainV3.build_driver_hints(context, filters)"},{"line_number":126,"context_line":"        refs \u003d self.resource_api.list_domains(hints\u003dhints)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa53dc9_e7e3ff03","line":123,"updated":"2015-04-08 21:43:36.000000000","message":"I still don\u0027t understand why we need to support this for the domain API...surely we should just freeze the domain API as is....","commit_id":"0081459447f9197b3f6b1e12eba089bbce5ecadd"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"cdd5022e4dff5d2d0098d0a3a1565640acb603b5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        ref \u003d self.resource_api.create_domain(ref[\u0027id\u0027], ref, initiator)"},{"line_number":121,"context_line":"        return DomainV3.wrap_member(context, ref)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @controller.filterprotected(\u0027enabled\u0027, \u0027name\u0027, \u0027parent_id\u0027)"},{"line_number":124,"context_line":"    def list_domains(self, context, filters):"},{"line_number":125,"context_line":"        hints \u003d DomainV3.build_driver_hints(context, filters)"},{"line_number":126,"context_line":"        refs \u003d self.resource_api.list_domains(hints\u003dhints)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa53dc9_2f0ad979","line":123,"in_reply_to":"9aa53dc9_e7e3ff03","updated":"2015-04-09 01:27:03.000000000","message":"Hum... We just don\u0027t want broke the backward compatibility, but we can discuss this with the Keystone folks.","commit_id":"0081459447f9197b3f6b1e12eba089bbce5ecadd"}],"keystone/resource/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"4f25a3a2998953942be5d4ba9350bc4dd3ea7740","unresolved":false,"context_lines":[{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        # Create an is_domain project based on the created domain"},{"line_number":580,"context_line":"        is_domain_project \u003d self._get_project_from_domain(ret)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        self._create_project(is_domain_project[\u0027id\u0027], is_domain_project,"},{"line_number":583,"context_line":"                             initiator)"},{"line_number":584,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da9b358b_f6d2c1ff","line":581,"updated":"2015-03-31 09:10:47.000000000","message":"blank line?","commit_id":"cf4a7a68a4ffa37879f0204ff2d017bcf2dffafc"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"edfe3d479f3cf576dea500a5783b8fb9e099ed1a","unresolved":false,"context_lines":[{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        # Create an is_domain project based on the created domain"},{"line_number":580,"context_line":"        is_domain_project \u003d self._get_project_from_domain(ret)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        self._create_project(is_domain_project[\u0027id\u0027], is_domain_project,"},{"line_number":583,"context_line":"                             initiator)"},{"line_number":584,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da9b358b_706d8b97","line":581,"in_reply_to":"da9b358b_f6d2c1ff","updated":"2015-03-31 14:03:26.000000000","message":"Done","commit_id":"cf4a7a68a4ffa37879f0204ff2d017bcf2dffafc"}]}