)]}'
{"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":4059,"context_line":"        self.setUpKeyRepository()"},{"line_number":4060,"context_line":""},{"line_number":4061,"context_line":"    def _make_auth_request(self, auth_data, trust_token\u003dFalse,"},{"line_number":4062,"context_line":"                           unscoped_token\u003dFalse):"},{"line_number":4063,"context_line":"        resp \u003d self.post(\u0027/auth/tokens\u0027, body\u003dauth_data, expected_status\u003d201)"},{"line_number":4064,"context_line":"        token \u003d resp.headers.get(\u0027X-Subject-Token\u0027)"},{"line_number":4065,"context_line":"        if trust_token:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_63fab9be","line":4062,"updated":"2015-03-05 23:32:21.000000000","message":"what if I set both trust_token and unscoped_token? this needs some docs now, or a better interface (e.g., pass a value like token_type\u003dTRUST or token_type\u003dUNSCOPED)\n\nthese objects could be matchers... e.g., \n\n TRUST \u003d matchers.StartsWith(\u0027F02\u0027)\n\nthen no if/else would be needed.","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":4059,"context_line":"        self.setUpKeyRepository()"},{"line_number":4060,"context_line":""},{"line_number":4061,"context_line":"    def _make_auth_request(self, auth_data, trust_token\u003dFalse,"},{"line_number":4062,"context_line":"                           unscoped_token\u003dFalse):"},{"line_number":4063,"context_line":"        resp \u003d self.post(\u0027/auth/tokens\u0027, body\u003dauth_data, expected_status\u003d201)"},{"line_number":4064,"context_line":"        token \u003d resp.headers.get(\u0027X-Subject-Token\u0027)"},{"line_number":4065,"context_line":"        if trust_token:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c597c9ea","line":4062,"in_reply_to":"9a80dd14_63fab9be","updated":"2015-03-06 15:33:31.000000000","message":"this is addressed in dependent changes (all these arguments are removed). https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"}],"keystone/token/providers/fernet/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            include_catalog\u003dinclude_catalog,"},{"line_number":91,"context_line":"            audit_info\u003dparent_audit_id)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        token_format \u003d None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if trust:"},{"line_number":96,"context_line":"            token_format \u003d self.token_format_map[fm.TRUST_TOKEN_PREFIX]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e3906945","line":93,"updated":"2015-03-05 23:32:21.000000000","message":"this line is unnecessary since it\u0027s always set.","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            include_catalog\u003dinclude_catalog,"},{"line_number":91,"context_line":"            audit_info\u003dparent_audit_id)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        token_format \u003d None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if trust:"},{"line_number":96,"context_line":"            token_format \u003d self.token_format_map[fm.TRUST_TOKEN_PREFIX]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_6588ddc5","line":93,"in_reply_to":"9a80dd14_e3906945","updated":"2015-03-06 15:33:31.000000000","message":"this is dropped in dependent refactors: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if trust:"},{"line_number":96,"context_line":"            token_format \u003d self.token_format_map[fm.TRUST_TOKEN_PREFIX]"},{"line_number":97,"context_line":"            token_id \u003d token_format.create_token(user_id, project_id,"},{"line_number":98,"context_line":"                                                 token_data)"},{"line_number":99,"context_line":"        elif domain_id is None and project_id is None:"},{"line_number":100,"context_line":"            token_format \u003d self.token_format_map[fm.UNSCOPED_TOKEN_PREFIX]"},{"line_number":101,"context_line":"            token_id \u003d token_format.create_token(user_id, token_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c3a9a57c","line":98,"updated":"2015-03-05 23:32:21.000000000","message":"if this is going to be different every time what\u0027s the point of the map?\n\nall the create_tokens should take all the arguments and then just ignore the ones they don\u0027t care about, then can just call\n\n if trust:\n   formatter \u003d fm.TRUST_TOKEN_PREFIX\n elif domain_id is None and project_id is None:\n   formatter \u003d fm.UNSCOPED_TOKEN_PREFIX\n else:\n   formatter \u003d fm.TOKEN_PREFIX\n\n token_format \u003d  self.token_format_map[formatter]\n token_id \u003d token_format.create(user_id, project_id, token_data)","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"2ad58e8c8d8d46e3588e468ec2a1ddc3e7c53421","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if trust:"},{"line_number":96,"context_line":"            token_format \u003d self.token_format_map[fm.TRUST_TOKEN_PREFIX]"},{"line_number":97,"context_line":"            token_id \u003d token_format.create_token(user_id, project_id,"},{"line_number":98,"context_line":"                                                 token_data)"},{"line_number":99,"context_line":"        elif domain_id is None and project_id is None:"},{"line_number":100,"context_line":"            token_format \u003d self.token_format_map[fm.UNSCOPED_TOKEN_PREFIX]"},{"line_number":101,"context_line":"            token_id \u003d token_format.create_token(user_id, token_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_63c9bd58","line":98,"in_reply_to":"9a80dd14_c3a9a57c","updated":"2015-03-06 13:25:49.000000000","message":"++","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"2671c5be18c435b586fc1797699629c9c700df57","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if trust:"},{"line_number":96,"context_line":"            token_format \u003d self.token_format_map[fm.TRUST_TOKEN_PREFIX]"},{"line_number":97,"context_line":"            token_id \u003d token_format.create_token(user_id, project_id,"},{"line_number":98,"context_line":"                                                 token_data)"},{"line_number":99,"context_line":"        elif domain_id is None and project_id is None:"},{"line_number":100,"context_line":"            token_format \u003d self.token_format_map[fm.UNSCOPED_TOKEN_PREFIX]"},{"line_number":101,"context_line":"            token_id \u003d token_format.create_token(user_id, token_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_f9971a38","line":98,"in_reply_to":"9a80dd14_c3a9a57c","updated":"2015-03-06 14:06:56.000000000","message":"actually, if the more options are added and argument diverge more it may worse the readibility to try to accumulate all the possible arguments in one call and fill half of them as None simply because they don\u0027t apply to the particular token type.","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if trust:"},{"line_number":96,"context_line":"            token_format \u003d self.token_format_map[fm.TRUST_TOKEN_PREFIX]"},{"line_number":97,"context_line":"            token_id \u003d token_format.create_token(user_id, project_id,"},{"line_number":98,"context_line":"                                                 token_data)"},{"line_number":99,"context_line":"        elif domain_id is None and project_id is None:"},{"line_number":100,"context_line":"            token_format \u003d self.token_format_map[fm.UNSCOPED_TOKEN_PREFIX]"},{"line_number":101,"context_line":"            token_id \u003d token_format.create_token(user_id, token_data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c5bee964","line":98,"in_reply_to":"9a80dd14_f9971a38","updated":"2015-03-06 15:33:31.000000000","message":"this is simplified in dependent changes: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            token_id \u003d token_format.create_token(user_id, token_data)"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            token_format \u003d self.token_format_map[fm.TOKEN_PREFIX]"},{"line_number":104,"context_line":"            token_id \u003d token_format.create_token(user_id, project_id,"},{"line_number":105,"context_line":"                                                 token_data)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        return token_id, token_data"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c34525b4","line":104,"updated":"2015-03-05 23:32:21.000000000","message":"domain_id?","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            token_id \u003d token_format.create_token(user_id, token_data)"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            token_format \u003d self.token_format_map[fm.TOKEN_PREFIX]"},{"line_number":104,"context_line":"            token_id \u003d token_format.create_token(user_id, project_id,"},{"line_number":105,"context_line":"                                                 token_data)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        return token_id, token_data"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_45b2f994","line":104,"in_reply_to":"9a80dd14_83c23132","updated":"2015-03-06 15:33:31.000000000","message":"domain support is added in a dependent change: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"2ad58e8c8d8d46e3588e468ec2a1ddc3e7c53421","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            token_id \u003d token_format.create_token(user_id, token_data)"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            token_format \u003d self.token_format_map[fm.TOKEN_PREFIX]"},{"line_number":104,"context_line":"            token_id \u003d token_format.create_token(user_id, project_id,"},{"line_number":105,"context_line":"                                                 token_data)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        return token_id, token_data"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_83c23132","line":104,"in_reply_to":"9a80dd14_c34525b4","updated":"2015-03-06 13:25:49.000000000","message":"++","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"}],"keystone/token/providers/fernet/format_map.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"UNSCOPED_TOKEN_PREFIX \u003d \u0027F00\u0027"},{"line_number":14,"context_line":"TOKEN_PREFIX \u003d \u0027F01\u0027"},{"line_number":15,"context_line":"TRUST_TOKEN_PREFIX \u003d \u0027F02\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_438855e7","line":13,"updated":"2015-03-05 23:32:21.000000000","message":"these all start with \"prefix\", suggest call this part \"format_prefixes\" and then can remove the _PREFIX.","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"UNSCOPED_TOKEN_PREFIX \u003d \u0027F00\u0027"},{"line_number":14,"context_line":"TOKEN_PREFIX \u003d \u0027F01\u0027"},{"line_number":15,"context_line":"TRUST_TOKEN_PREFIX \u003d \u0027F02\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_655d3d47","line":13,"in_reply_to":"9a80dd14_438855e7","updated":"2015-03-06 15:33:31.000000000","message":"this entire module is deleted in a dependent change: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"UNSCOPED_TOKEN_PREFIX \u003d \u0027F00\u0027"},{"line_number":14,"context_line":"TOKEN_PREFIX \u003d \u0027F01\u0027"},{"line_number":15,"context_line":"TRUST_TOKEN_PREFIX \u003d \u0027F02\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c3736513","line":14,"updated":"2015-03-05 23:32:21.000000000","message":"rename to SCOPED_TOKEN?","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"UNSCOPED_TOKEN_PREFIX \u003d \u0027F00\u0027"},{"line_number":14,"context_line":"TOKEN_PREFIX \u003d \u0027F01\u0027"},{"line_number":15,"context_line":"TRUST_TOKEN_PREFIX \u003d \u0027F02\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e51f6d6a","line":14,"in_reply_to":"9a80dd14_c3736513","updated":"2015-03-06 15:33:31.000000000","message":"these are essentially renamed to ProjectScopedPayload.version etc in a dependent change: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"}],"keystone/token/providers/fernet/token_formatters.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    token_format \u003d fm.UNSCOPED_TOKEN_PREFIX"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def create_token(self, user_id, token_data):"},{"line_number":156,"context_line":"        \"\"\"Create a unscoped token."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        :param user_id: identifier of the user in the token request"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_03f3bd73","line":155,"updated":"2015-03-05 23:32:21.000000000","message":"if they all need a create_token then add this to BaseTokenFormatter.","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    token_format \u003d fm.UNSCOPED_TOKEN_PREFIX"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def create_token(self, user_id, token_data):"},{"line_number":156,"context_line":"        \"\"\"Create a unscoped token."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        :param user_id: identifier of the user in the token request"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e9010706","line":155,"in_reply_to":"9a80dd14_03f3bd73","updated":"2015-03-06 15:33:31.000000000","message":"they\u0027re all slightly different, but these are all renamed and shuffled around in a dependent change: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class StandardTokenFormatter(BaseTokenFormatter):"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    token_format \u003d fm.TOKEN_PREFIX"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def create_token(self, user_id, project_id, token_data):"},{"line_number":206,"context_line":"        \"\"\"Create a standard formatted token."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_c3f8c54b","line":203,"updated":"2015-03-05 23:32:21.000000000","message":"this should be called prefix.","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class StandardTokenFormatter(BaseTokenFormatter):"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    token_format \u003d fm.TOKEN_PREFIX"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def create_token(self, user_id, project_id, token_data):"},{"line_number":206,"context_line":"        \"\"\"Create a standard formatted token."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_29087f27","line":203,"in_reply_to":"9a80dd14_c3f8c54b","updated":"2015-03-06 15:33:31.000000000","message":"prefixes no longer exist in a dependent change: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cb0e64293dca21309603f9b570b2d172641d7629","unresolved":false,"context_lines":[{"line_number":271,"context_line":"@dependency.requires(\u0027trust_api\u0027)"},{"line_number":272,"context_line":"class TrustTokenFormatter(BaseTokenFormatter):"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    token_format \u003d fm.TRUST_TOKEN_PREFIX"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def create_token(self, user_id, project_id, token_data):"},{"line_number":277,"context_line":"        \"\"\"Create a trust formatted token."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_23a1a147","line":274,"updated":"2015-03-05 23:32:21.000000000","message":"actually, should get rid of format_map.py and just use TrustTokenFormatter.token_format rather than format_map.TRUST_TOKEN_PREFIX.","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"48db1d87acf7735867c33c94fcb5927cd52aa775","unresolved":false,"context_lines":[{"line_number":271,"context_line":"@dependency.requires(\u0027trust_api\u0027)"},{"line_number":272,"context_line":"class TrustTokenFormatter(BaseTokenFormatter):"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    token_format \u003d fm.TRUST_TOKEN_PREFIX"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def create_token(self, user_id, project_id, token_data):"},{"line_number":277,"context_line":"        \"\"\"Create a trust formatted token."}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_e9282788","line":274,"in_reply_to":"9a80dd14_23a1a147","updated":"2015-03-06 15:33:31.000000000","message":"i do exactly that in a dependent change: https://review.openstack.org/#/c/162196/","commit_id":"12c6b9a0b9e7477676c11f0ac3ac23060634d61f"}]}