)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e514154d163208be4be80d4959e1de679f936890","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave Chen \u003cwei.d.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-11 05:09:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use assertFalse and assertTrue instead of assertEqual"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since `assertFalse` and `assertTrue` are provided for asserting"},{"line_number":10,"context_line":"boolean expression, seems it is not official to use assertEqual."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_47702ca4","line":7,"updated":"2015-09-30 13:45:10.000000000","message":"The big thing I don\u0027t like about this is that it changes the test semantics. They are no longer checking to see if the return value *is* True or False. Would assertIs be more accurate since True and False are singletons?","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"f49d6a566de5641eca049e7bc04b0a9cff84fcbb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since `assertFalse` and `assertTrue` are provided for asserting"},{"line_number":10,"context_line":"boolean expression, seems it is not official to use assertEqual."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id522f1c72cbd1cc079c860f611dcb922b7d89525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_d6033e0e","line":11,"updated":"2015-09-25 07:39:59.000000000","message":"IMO you can use Related-Bug: #1259292 flag.\n\n[1] https://bugs.launchpad.net/heat/+bug/1259292","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"651735c05811781e676240b773778e78b213c700","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since `assertFalse` and `assertTrue` are provided for asserting"},{"line_number":10,"context_line":"boolean expression, seems it is not official to use assertEqual."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id522f1c72cbd1cc079c860f611dcb922b7d89525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_447eea6a","line":11,"in_reply_to":"9a1a9d01_27004634","updated":"2015-09-30 13:33:09.000000000","message":"Hi Dave,\n\nIMO since patch [1] got merged with partial bug flag, you can use Closes-Bug: #1259292 here, so that bug can be closed.\n\n[1] https://review.openstack.org/#/c/226677/2","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"13b7315f88db2d1fb092873c3d531c80c3143300","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since `assertFalse` and `assertTrue` are provided for asserting"},{"line_number":10,"context_line":"boolean expression, seems it is not official to use assertEqual."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id522f1c72cbd1cc079c860f611dcb922b7d89525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_c74f5c32","line":11,"in_reply_to":"9a1a9d01_4446ea7b","updated":"2015-09-30 13:48:56.000000000","message":"In that case, how can we close the bug https://bugs.launchpad.net/heat/+bug/1259292 ?","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e514154d163208be4be80d4959e1de679f936890","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since `assertFalse` and `assertTrue` are provided for asserting"},{"line_number":10,"context_line":"boolean expression, seems it is not official to use assertEqual."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id522f1c72cbd1cc079c860f611dcb922b7d89525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_4446ea7b","line":11,"in_reply_to":"9a1a9d01_447eea6a","updated":"2015-09-30 13:45:10.000000000","message":"That bug is about reversing order. This commit doesn\u0027t do that, so I agree that related in more accurate.","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b7fb762ec49acc0fddf55caf6dc133def3850b12","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since `assertFalse` and `assertTrue` are provided for asserting"},{"line_number":10,"context_line":"boolean expression, seems it is not official to use assertEqual."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id522f1c72cbd1cc079c860f611dcb922b7d89525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a26ad4f_e8f06093","line":11,"in_reply_to":"9a1a9d01_c74f5c32","updated":"2015-11-02 13:29:16.000000000","message":"Rajesh, I saw status of that bug has been changed to \"Fix Committed\". :)","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"bc40948a07fc9add601728c5831eb8665fe163f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since `assertFalse` and `assertTrue` are provided for asserting"},{"line_number":10,"context_line":"boolean expression, seems it is not official to use assertEqual."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id522f1c72cbd1cc079c860f611dcb922b7d89525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_27004634","line":11,"in_reply_to":"9a1a9d01_d6033e0e","updated":"2015-09-25 09:14:21.000000000","message":"this is related that bug, they are different scoped.","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"}],"keystone/tests/unit/test_backend.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"0c4a6dc91af2605902c8687d4658795c91071cd6","unresolved":false,"context_lines":[{"line_number":2310,"context_line":"        user[\u0027enabled\u0027] \u003d -42"},{"line_number":2311,"context_line":"        self.identity_api.update_user(user[\u0027id\u0027], user)"},{"line_number":2312,"context_line":"        user_ref \u003d self.identity_api.get_user(user[\u0027id\u0027])"},{"line_number":2313,"context_line":"        self.assertTrue(user_ref[\u0027enabled\u0027])"},{"line_number":2314,"context_line":""},{"line_number":2315,"context_line":"    def test_update_user_name(self):"},{"line_number":2316,"context_line":"        user \u003d {\u0027name\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_53d6de28","line":2313,"updated":"2015-03-10 09:39:07.000000000","message":"I am not sure about this line. Before the change we tested that True is returned even after we pass -42. If -42 is returned, it will raise an exception (because -42 !\u003d True). With the change assertTrue will not raise the exception.\n\nDo we have any type checks for attributes outside this function?","commit_id":"eb1eb73f5837854565de8720c81e95ba01b5ecc0"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"5f34d2e011e4e97f55bc4ce2d979f59d35ff3451","unresolved":false,"context_lines":[{"line_number":2310,"context_line":"        user[\u0027enabled\u0027] \u003d -42"},{"line_number":2311,"context_line":"        self.identity_api.update_user(user[\u0027id\u0027], user)"},{"line_number":2312,"context_line":"        user_ref \u003d self.identity_api.get_user(user[\u0027id\u0027])"},{"line_number":2313,"context_line":"        self.assertTrue(user_ref[\u0027enabled\u0027])"},{"line_number":2314,"context_line":""},{"line_number":2315,"context_line":"    def test_update_user_name(self):"},{"line_number":2316,"context_line":"        user \u003d {\u0027name\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_8059d136","line":2313,"in_reply_to":"9a80dd14_055c1318","updated":"2015-03-10 13:26:52.000000000","message":"I think that a comment should be added for future reference, so that people don\u0027t think that there is some inconsistency here.","commit_id":"eb1eb73f5837854565de8720c81e95ba01b5ecc0"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"df577e9d402e4b4e9b4a6a5fee9c734380c76b3a","unresolved":false,"context_lines":[{"line_number":2310,"context_line":"        user[\u0027enabled\u0027] \u003d -42"},{"line_number":2311,"context_line":"        self.identity_api.update_user(user[\u0027id\u0027], user)"},{"line_number":2312,"context_line":"        user_ref \u003d self.identity_api.get_user(user[\u0027id\u0027])"},{"line_number":2313,"context_line":"        self.assertTrue(user_ref[\u0027enabled\u0027])"},{"line_number":2314,"context_line":""},{"line_number":2315,"context_line":"    def test_update_user_name(self):"},{"line_number":2316,"context_line":"        user \u003d {\u0027name\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_055c1318","line":2313,"in_reply_to":"9a80dd14_53d6de28","updated":"2015-03-10 13:13:16.000000000","message":"I did a testing and understand what\u0027s the difference behind this, so I just keep it as what it was, thanks Boris.","commit_id":"eb1eb73f5837854565de8720c81e95ba01b5ecc0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"cbc4d681e6e2ae23ddab224c73db3ac331dd15f1","unresolved":false,"context_lines":[{"line_number":1956,"context_line":"                   \u0027domain_id\u0027: DEFAULT_DOMAIN_ID}"},{"line_number":1957,"context_line":"        self.resource_api.create_project(project[\u0027id\u0027], project)"},{"line_number":1958,"context_line":"        project_ref \u003d self.resource_api.get_project(project[\u0027id\u0027])"},{"line_number":1959,"context_line":"        self.assertTrue(project_ref[\u0027enabled\u0027])"},{"line_number":1960,"context_line":""},{"line_number":1961,"context_line":"        # Strings are not valid boolean values"},{"line_number":1962,"context_line":"        project[\u0027enabled\u0027] \u003d \"false\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_529e5557","line":1959,"updated":"2015-06-29 21:41:44.000000000","message":"These should be changed to assertIs rather than assertEqual since the value needs to be a bool.","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"f49d6a566de5641eca049e7bc04b0a9cff84fcbb","unresolved":false,"context_lines":[{"line_number":2310,"context_line":"        user[\u0027enabled\u0027] \u003d -42"},{"line_number":2311,"context_line":"        self.identity_api.update_user(user[\u0027id\u0027], user)"},{"line_number":2312,"context_line":"        user_ref \u003d self.identity_api.get_user(user[\u0027id\u0027])"},{"line_number":2313,"context_line":"        self.assertEqual(True, user_ref[\u0027enabled\u0027])"},{"line_number":2314,"context_line":""},{"line_number":2315,"context_line":"    def test_update_user_name(self):"},{"line_number":2316,"context_line":"        user \u003d {\u0027name\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_96a626c0","line":2313,"updated":"2015-09-25 07:39:59.000000000","message":"you have missed this.","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"bc40948a07fc9add601728c5831eb8665fe163f6","unresolved":false,"context_lines":[{"line_number":2310,"context_line":"        user[\u0027enabled\u0027] \u003d -42"},{"line_number":2311,"context_line":"        self.identity_api.update_user(user[\u0027id\u0027], user)"},{"line_number":2312,"context_line":"        user_ref \u003d self.identity_api.get_user(user[\u0027id\u0027])"},{"line_number":2313,"context_line":"        self.assertEqual(True, user_ref[\u0027enabled\u0027])"},{"line_number":2314,"context_line":""},{"line_number":2315,"context_line":"    def test_update_user_name(self):"},{"line_number":2316,"context_line":"        user \u003d {\u0027name\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_87eef289","line":2313,"in_reply_to":"9a1a9d01_96a626c0","updated":"2015-09-25 09:14:21.000000000","message":"see the comments there, https://review.openstack.org/#/c/162570/2/keystone/tests/unit/test_backend.py","commit_id":"4f554d8e9325315ad1f5d5464109a8bc6c828277"}]}