)]}'
{"keystone/tests/unit/common/test_ldap.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"96ea56b3bfeeff864e08e32cb99d5153cd36a874","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        py_result \u003d ks_ldap.convert_ldap_result(result)"},{"line_number":449,"context_line":"        # The user id should be 0123456, and the enabled"},{"line_number":450,"context_line":"        # flag should be True"},{"line_number":451,"context_line":"        self.assertTrue(py_result[0][1][\u0027enabled\u0027][0])"},{"line_number":452,"context_line":"        self.assertEqual(user_id, py_result[0][1][\u0027user_id\u0027][0])"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_user_id_begins_with_0_and_enabled_bit_mask(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_331a4ac6","line":451,"updated":"2015-03-10 09:44:19.000000000","message":"not sure about this change either. It seems to me that the code checks type too.","commit_id":"dd837cb11b4306f533c9febe6d56e1b38b3d2978"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"c93f1f4049116400cbb0445c51916a1cb342b677","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        py_result \u003d ks_ldap.convert_ldap_result(result)"},{"line_number":449,"context_line":"        # The user id should be 0123456, and the enabled"},{"line_number":450,"context_line":"        # flag should be True"},{"line_number":451,"context_line":"        self.assertTrue(py_result[0][1][\u0027enabled\u0027][0])"},{"line_number":452,"context_line":"        self.assertEqual(user_id, py_result[0][1][\u0027user_id\u0027][0])"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_user_id_begins_with_0_and_enabled_bit_mask(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_dc6ac980","line":451,"in_reply_to":"9a80dd14_13570627","updated":"2015-03-10 15:57:40.000000000","message":"++ thanks for the clarification!","commit_id":"dd837cb11b4306f533c9febe6d56e1b38b3d2978"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4bf8956f769c96322090a26a357ca3a449985408","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        py_result \u003d ks_ldap.convert_ldap_result(result)"},{"line_number":449,"context_line":"        # The user id should be 0123456, and the enabled"},{"line_number":450,"context_line":"        # flag should be True"},{"line_number":451,"context_line":"        self.assertTrue(py_result[0][1][\u0027enabled\u0027][0])"},{"line_number":452,"context_line":"        self.assertEqual(user_id, py_result[0][1][\u0027user_id\u0027][0])"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_user_id_begins_with_0_and_enabled_bit_mask(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_73668252","line":451,"in_reply_to":"9a80dd14_331a4ac6","updated":"2015-03-10 09:45:39.000000000","message":"does assertTrue accept other values than the boolean True?","commit_id":"dd837cb11b4306f533c9febe6d56e1b38b3d2978"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"603006f34c4a4445f3181757fea1ffea014729be","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        py_result \u003d ks_ldap.convert_ldap_result(result)"},{"line_number":449,"context_line":"        # The user id should be 0123456, and the enabled"},{"line_number":450,"context_line":"        # flag should be True"},{"line_number":451,"context_line":"        self.assertTrue(py_result[0][1][\u0027enabled\u0027][0])"},{"line_number":452,"context_line":"        self.assertEqual(user_id, py_result[0][1][\u0027user_id\u0027][0])"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_user_id_begins_with_0_and_enabled_bit_mask(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_13570627","line":451,"in_reply_to":"9a80dd14_73668252","updated":"2015-03-10 09:48:54.000000000","message":"it does.\n\nCheck yourself in /usr/lib/python2.7/unittest/case.py","commit_id":"dd837cb11b4306f533c9febe6d56e1b38b3d2978"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"8d0a08462bd0835481994da3b60618b827ebef06","unresolved":false,"context_lines":[{"line_number":1222,"context_line":""},{"line_number":1223,"context_line":"        # Use assertIs rather than assertTrue because assertIs will assert the"},{"line_number":1224,"context_line":"        # value is a Boolean as expected."},{"line_number":1225,"context_line":"        self.assertTrue(user_ref[\u0027enabled\u0027])"},{"line_number":1226,"context_line":"        self.assertNotIn(\u0027enabled_nomask\u0027, user_ref)"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        enabled_vals \u003d self.get_user_enabled_vals(user_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_73bcc2bb","line":1225,"updated":"2015-03-10 09:42:39.000000000","message":"No, please read comment in the code above.\n\nI also suggest you to re-think changes in other functions below, maybe assertIs is required  there too.","commit_id":"dd837cb11b4306f533c9febe6d56e1b38b3d2978"}]}
