)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8b46f041e657e9c3d63df6314d5c58ad810b18c7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-11 20:38:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Abstract the direct map concept into an object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partially-Implements: bp mapping-enhancements"},{"line_number":10,"context_line":"Change-Id: I8699e99e62361275e6d9d919539a68bd07be75f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_64cadea2","line":8,"updated":"2015-03-11 22:11:52.000000000","message":"why?","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"ac50f69e91e5be2c8dbf7b521e517abd53055508","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-11 20:38:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Abstract the direct map concept into an object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partially-Implements: bp mapping-enhancements"},{"line_number":10,"context_line":"Change-Id: I8699e99e62361275e6d9d919539a68bd07be75f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a80dd14_2eb193e1","line":8,"in_reply_to":"9a80dd14_64cadea2","updated":"2015-03-12 07:51:40.000000000","message":"This probably deserves a bug, doesn\u0027t it?","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"}],"keystone/contrib/federation/utils.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"285da77ff04811daf503a9b2aff820df25456bdc","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    def __getitem__(self, idx):"},{"line_number":119,"context_line":"        value \u003d self._maps[idx]"},{"line_number":120,"context_line":"        if isinstance(value, list) and len(value) \u003d\u003d 1:"},{"line_number":121,"context_line":"            return value[0]"},{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            return value"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_3d1d5a67","line":121,"updated":"2015-03-11 21:19:39.000000000","message":"we could probably use comments or maybe a class level docstring that shows example values, and why we would use value[0] or value","commit_id":"8a52f7ed1e89cc337301838a3568f452e95a5b95"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"101b5660fee7e678aab5dc55d2c9ba4aeff4c5c0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def as_list(self):"},{"line_number":126,"context_line":"        for value in self:"},{"line_number":127,"context_line":"            if isinstance(value, list) and len(value) \u003d\u003d 1:"},{"line_number":128,"context_line":"                print value[0]"},{"line_number":129,"context_line":"                yield value[0]"},{"line_number":130,"context_line":"            else:"},{"line_number":131,"context_line":"                yield value"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ddb7def3","line":128,"updated":"2015-03-11 21:26:06.000000000","message":"remove this and just use yield value[0]","commit_id":"8a52f7ed1e89cc337301838a3568f452e95a5b95"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8b46f041e657e9c3d63df6314d5c58ad810b18c7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def __init__(self):"},{"line_number":117,"context_line":"        self._matches \u003d []"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def add(self, value):"},{"line_number":120,"context_line":"        \"\"\"Adds a matched value to the list of matches."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :param list value: the match to save"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e4024eb3","line":119,"updated":"2015-03-11 22:11:52.000000000","message":"would be nice to have unit tests for this class.","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"4f475d45722a06d7614f733780a5bea9f5363735","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def __init__(self):"},{"line_number":117,"context_line":"        self._matches \u003d []"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def add(self, value):"},{"line_number":120,"context_line":"        \"\"\"Adds a matched value to the list of matches."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :param list value: the match to save"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e3aa3b19","line":119,"in_reply_to":"9a80dd14_e4024eb3","updated":"2015-03-12 03:50:53.000000000","message":"This will be tested by the Federation code.  It Should probably be an internal cals with _ infront of the name.","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8b46f041e657e9c3d63df6314d5c58ad810b18c7","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def add(self, value):"},{"line_number":120,"context_line":"        \"\"\"Adds a matched value to the list of matches."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :param list value: the match to save"},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        self._matches.append(value)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c4e1cafd","line":122,"updated":"2015-03-11 22:11:52.000000000","message":"suggest call the param values since it\u0027s a list.","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"ac50f69e91e5be2c8dbf7b521e517abd53055508","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def add(self, value):"},{"line_number":120,"context_line":"        \"\"\"Adds a matched value to the list of matches."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :param list value: the match to save"},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        self._matches.append(value)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0e084f90","line":122,"in_reply_to":"9a80dd14_c4e1cafd","updated":"2015-03-12 07:51:40.000000000","message":"Done","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8b46f041e657e9c3d63df6314d5c58ad810b18c7","unresolved":false,"context_lines":[{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        :param requirements: list of remote requirements from rules"},{"line_number":543,"context_line":"        :type requirements: list"},{"line_number":544,"context_line":"        :returns: identity values used to update local"},{"line_number":545,"context_line":"        :rtype: keystone.contrib.federation.utils.DirectMaps"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        Example requirements::"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_a4cdb688","line":544,"updated":"2015-03-11 22:11:52.000000000","message":"move this down after the other param.","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"ac50f69e91e5be2c8dbf7b521e517abd53055508","unresolved":false,"context_lines":[{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        :param requirements: list of remote requirements from rules"},{"line_number":543,"context_line":"        :type requirements: list"},{"line_number":544,"context_line":"        :returns: identity values used to update local"},{"line_number":545,"context_line":"        :rtype: keystone.contrib.federation.utils.DirectMaps"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":"        Example requirements::"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ceed57b9","line":544,"in_reply_to":"9a80dd14_a4cdb688","updated":"2015-03-12 07:51:40.000000000","message":"Done","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8b46f041e657e9c3d63df6314d5c58ad810b18c7","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                \u0027FirstName\u0027: [\u0027Test\u0027]"},{"line_number":572,"context_line":"            }"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        :returns: list of direct mappings or None."},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        \"\"\""},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_64b49ef2","line":574,"updated":"2015-03-11 22:11:52.000000000","message":"there\u0027s already a returns above.","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"ac50f69e91e5be2c8dbf7b521e517abd53055508","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                \u0027FirstName\u0027: [\u0027Test\u0027]"},{"line_number":572,"context_line":"            }"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        :returns: list of direct mappings or None."},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"        \"\"\""},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ee2bfbe8","line":574,"in_reply_to":"9a80dd14_64b49ef2","updated":"2015-03-12 07:51:40.000000000","message":"removed.","commit_id":"91241a12c7ba0a303fb023809365600516bc8f55"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9649832bcad7b9a182a2cf568ea92b51f3a65381","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def add(self, values):"},{"line_number":120,"context_line":"        \"\"\"Adds a matched value to the list of matches."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        :param list value: the match to save"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        self._matches.append(values)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_df0fa8df","line":122,"updated":"2015-03-12 16:49:22.000000000","message":"nit: this should be values*","commit_id":"40c9b5fa28bf6288654330d862917a4e0b16039d"}]}
