)]}'
{"keystone/contrib/federation/schema.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"3856258ef8468f69e9dd222760d2da3270982b93","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"_service_provider_properties \u003d {"},{"line_number":56,"context_line":"    \u0027id\u0027: parameter_types.id_string,"},{"line_number":57,"context_line":"    # NOTE(rodrigods): The database accepts URLs with 256 as max length,"},{"line_number":58,"context_line":"    # but parameter_types.url uses 225 as max length."},{"line_number":59,"context_line":"    \u0027auth_url\u0027: parameter_types.url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_5adbc61a","line":56,"updated":"2015-03-12 17:17:11.000000000","message":"when is this required? We don\u0027t need to accept id in the request.","commit_id":"798d08a7b54841b35dc2686ea6deaaa9fed530ae"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d4616609f5faecac51955ad7417482d01052d501","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"_service_provider_properties \u003d {"},{"line_number":56,"context_line":"    \u0027id\u0027: parameter_types.id_string,"},{"line_number":57,"context_line":"    # NOTE(rodrigods): The database accepts URLs with 256 as max length,"},{"line_number":58,"context_line":"    # but parameter_types.url uses 225 as max length."},{"line_number":59,"context_line":"    \u0027auth_url\u0027: parameter_types.url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1a6dce32","line":56,"in_reply_to":"9a80dd14_5adbc61a","updated":"2015-03-12 17:19:09.000000000","message":"not at all, actually we can\u0027t pass the \u0027id\u0027 since it is a PUT, will remove this","commit_id":"798d08a7b54841b35dc2686ea6deaaa9fed530ae"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6e816d51fc86a94409affd853f6a324d0b831008","unresolved":false,"context_lines":[{"line_number":55,"context_line":"_service_provider_properties \u003d {"},{"line_number":56,"context_line":"    # NOTE(rodrigods): The database accepts URLs with 256 as max length,"},{"line_number":57,"context_line":"    # but parameter_types.url uses 225 as max length."},{"line_number":58,"context_line":"    \u0027auth_url\u0027: parameter_types.url,"},{"line_number":59,"context_line":"    \u0027sp_url\u0027: parameter_types.url,"},{"line_number":60,"context_line":"    \u0027description\u0027: validation.nullable(parameter_types.description),"},{"line_number":61,"context_line":"    \u0027enabled\u0027: parameter_types.boolean"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_2f0c043b","line":58,"updated":"2015-03-12 23:27:36.000000000","message":"This may result in broken implementations since they could already have a longer URL. Highly unlikely, but possible.","commit_id":"0e40349d397e43747d5dc2eca1483b40e1a5df5d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6e816d51fc86a94409affd853f6a324d0b831008","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # NOTE(rodrigods): The database accepts URLs with 256 as max length,"},{"line_number":57,"context_line":"    # but parameter_types.url uses 225 as max length."},{"line_number":58,"context_line":"    \u0027auth_url\u0027: parameter_types.url,"},{"line_number":59,"context_line":"    \u0027sp_url\u0027: parameter_types.url,"},{"line_number":60,"context_line":"    \u0027description\u0027: validation.nullable(parameter_types.description),"},{"line_number":61,"context_line":"    \u0027enabled\u0027: parameter_types.boolean"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_6f119c51","line":59,"updated":"2015-03-12 23:27:36.000000000","message":"Same.","commit_id":"0e40349d397e43747d5dc2eca1483b40e1a5df5d"}],"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de090ea0cbaa3b0a4c5bdacc1f171570827b039d","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"    def test_validate_sp_request_with_id(self):"},{"line_number":1490,"context_line":"        \"\"\"Test that we validate `id` in create requests.\"\"\""},{"line_number":1491,"context_line":"        request_to_validate \u003d {"},{"line_number":1492,"context_line":"            \u0027id\u0027: \u0027ACME\u0027,"},{"line_number":1493,"context_line":"            \u0027auth_url\u0027: self.valid_auth_url,"},{"line_number":1494,"context_line":"            \u0027sp_url\u0027: self.valid_sp_url,"},{"line_number":1495,"context_line":"            \u0027description\u0027: \u0027My Service Provider\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ba3a0296","line":1492,"updated":"2015-03-12 17:08:50.000000000","message":"shouldn\u0027t this fail as it\u0027s a PUT request with the ID in the url","commit_id":"798d08a7b54841b35dc2686ea6deaaa9fed530ae"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d4616609f5faecac51955ad7417482d01052d501","unresolved":false,"context_lines":[{"line_number":1489,"context_line":"    def test_validate_sp_request_with_id(self):"},{"line_number":1490,"context_line":"        \"\"\"Test that we validate `id` in create requests.\"\"\""},{"line_number":1491,"context_line":"        request_to_validate \u003d {"},{"line_number":1492,"context_line":"            \u0027id\u0027: \u0027ACME\u0027,"},{"line_number":1493,"context_line":"            \u0027auth_url\u0027: self.valid_auth_url,"},{"line_number":1494,"context_line":"            \u0027sp_url\u0027: self.valid_sp_url,"},{"line_number":1495,"context_line":"            \u0027description\u0027: \u0027My Service Provider\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1a26ae16","line":1492,"in_reply_to":"9a80dd14_ba3a0296","updated":"2015-03-12 17:19:09.000000000","message":"hmm, true... will remove it from the schema","commit_id":"798d08a7b54841b35dc2686ea6deaaa9fed530ae"}]}