)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a377aeec0a7092e284489c201e63074d26f162d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add caching to getting of the fully substituted domain config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supporting caching on the fully substituted domain config will"},{"line_number":10,"context_line":"enable us to use cache expiration as a way of ensuing all"},{"line_number":11,"context_line":"keystone server processes pick up new domain configs. This"},{"line_number":12,"context_line":"patch adds this caching in preparation of that support."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa963961_1ce90d1b","line":10,"updated":"2015-03-26 15:23:06.000000000","message":"ensuring*","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8877548f8b96b762b475af5b01e735bb7d1cce1b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add caching to getting of the fully substituted domain config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supporting caching on the fully substituted domain config will"},{"line_number":10,"context_line":"enable us to use cache expiration as a way of ensuing all"},{"line_number":11,"context_line":"keystone server processes pick up new domain configs. This"},{"line_number":12,"context_line":"patch adds this caching in preparation of that support."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa963961_f30e8fe4","line":10,"in_reply_to":"fa963961_1ce90d1b","updated":"2015-03-26 20:28:21.000000000","message":"Done","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"}],"keystone/common/config.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a377aeec0a7092e284489c201e63074d26f162d","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                   help\u003d\u0027Domain config backend driver.\u0027),"},{"line_number":454,"context_line":"        cfg.BoolOpt(\u0027caching\u0027, default\u003dTrue,"},{"line_number":455,"context_line":"                    help\u003d\u0027Toggle for domain config caching. This has no \u0027"},{"line_number":456,"context_line":"                         \u0027effect unless global caching is enabled.\u0027),"},{"line_number":457,"context_line":"        cfg.IntOpt(\u0027cache_time\u0027, default\u003d300,"},{"line_number":458,"context_line":"                   help\u003d\u0027TTL (in seconds) to domain config data. This has \u0027"},{"line_number":459,"context_line":"                        \u0027no effect unless global caching is enabled.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_3c69718c","line":456,"updated":"2015-03-26 15:23:06.000000000","message":"Should this reference the configuration option for enabling global caching as well? Or at least in the documentation. As an end-user reading this, it would be easier to follow with something like: \n\n     \u0027Toggle for domain config caching. This has no \u0027\n     \u0027effect unless \u003cglobal caching config property name\u003e is also enabled\u0027","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8877548f8b96b762b475af5b01e735bb7d1cce1b","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                   help\u003d\u0027Domain config backend driver.\u0027),"},{"line_number":454,"context_line":"        cfg.BoolOpt(\u0027caching\u0027, default\u003dTrue,"},{"line_number":455,"context_line":"                    help\u003d\u0027Toggle for domain config caching. This has no \u0027"},{"line_number":456,"context_line":"                         \u0027effect unless global caching is enabled.\u0027),"},{"line_number":457,"context_line":"        cfg.IntOpt(\u0027cache_time\u0027, default\u003d300,"},{"line_number":458,"context_line":"                   help\u003d\u0027TTL (in seconds) to domain config data. This has \u0027"},{"line_number":459,"context_line":"                        \u0027no effect unless global caching is enabled.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_f83aeee6","line":456,"in_reply_to":"fa963961_3c69718c","updated":"2015-03-26 20:28:21.000000000","message":"so I just copied what they all say :-)  how about I raise a separate bug to come back in and fix them all?","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a377aeec0a7092e284489c201e63074d26f162d","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                         \u0027effect unless global caching is enabled.\u0027),"},{"line_number":457,"context_line":"        cfg.IntOpt(\u0027cache_time\u0027, default\u003d300,"},{"line_number":458,"context_line":"                   help\u003d\u0027TTL (in seconds) to domain config data. This has \u0027"},{"line_number":459,"context_line":"                        \u0027no effect unless global caching is enabled.\u0027),"},{"line_number":460,"context_line":"    ],"},{"line_number":461,"context_line":"    \u0027role\u0027: ["},{"line_number":462,"context_line":"        # The role driver has no default for backward compatibility reasons."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_bc13410d","line":459,"updated":"2015-03-26 15:23:06.000000000","message":"Same comment here. If this is going to be one by default, then can the domain config caching just feed off the global caching options?","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8877548f8b96b762b475af5b01e735bb7d1cce1b","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                         \u0027effect unless global caching is enabled.\u0027),"},{"line_number":457,"context_line":"        cfg.IntOpt(\u0027cache_time\u0027, default\u003d300,"},{"line_number":458,"context_line":"                   help\u003d\u0027TTL (in seconds) to domain config data. This has \u0027"},{"line_number":459,"context_line":"                        \u0027no effect unless global caching is enabled.\u0027),"},{"line_number":460,"context_line":"    ],"},{"line_number":461,"context_line":"    \u0027role\u0027: ["},{"line_number":462,"context_line":"        # The role driver has no default for backward compatibility reasons."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_9809a234","line":459,"in_reply_to":"fa963961_bc13410d","updated":"2015-03-26 20:28:21.000000000","message":"I think this comment is actually wrong!  This has no effect unless the domain config caching is enabled...will fix.","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"}],"keystone/resource/core.py":[{"author":{"_account_id":10917,"name":"Gabriel Bezerra","email":"gabrielb@lsd.ufcg.edu.br","username":"gabriel.bezerra"},"change_message_id":"67e654afb8a70fe31e185576ed7a7a5eaece25d3","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"        for new_option in sensitive:"},{"line_number":1139,"context_line":"            _update_or_create(domain_id, new_option, sensitive\u003dTrue)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        self.get_config_with_sensitive_info.invalidate(self, domain_id)"},{"line_number":1142,"context_line":"        return self.get_config(domain_id)"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"    def delete_config(self, domain_id, group\u003dNone, option\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_3dd230d1","line":1141,"updated":"2015-03-20 14:30:49.000000000","message":"The comment you have in create_config is also useful here.\n\n        # Since we are caching on the full substituted config, we just\n        # invalidate here, rather than try and create the right result to\n        # cache.","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"a26a41d2898cbf650f017e92011cdbb295f935f5","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"        for new_option in sensitive:"},{"line_number":1139,"context_line":"            _update_or_create(domain_id, new_option, sensitive\u003dTrue)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        self.get_config_with_sensitive_info.invalidate(self, domain_id)"},{"line_number":1142,"context_line":"        return self.get_config(domain_id)"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"    def delete_config(self, domain_id, group\u003dNone, option\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_73221902","line":1141,"in_reply_to":"9a80dd14_3dd230d1","updated":"2015-03-20 15:09:00.000000000","message":"that\u0027s strictly true - although in general we tend to not try and directly update the cache on an update - we usually do just invalidate (see other examples for project/domain in this file). For that reason, I didn\u0027t repeat the comment here","commit_id":"cd504679b54b14812ab94c8dd227da7e5c83bcf6"}],"keystone/tests/unit/backend/domain_config/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a8e3b10245510ba452c2a84faffa5f95f880018f","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        self.domain_config_api.delete_config_options(self.domain[\u0027id\u0027],"},{"line_number":541,"context_line":"                                                     sensitive\u003dTrue)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        self.assertDictEqual("},{"line_number":544,"context_line":"            res, self.domain_config_api.get_config_with_sensitive_info("},{"line_number":545,"context_line":"                self.domain[\u0027id\u0027]))"},{"line_number":546,"context_line":"        self.domain_config_api.get_config_with_sensitive_info.invalidate("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa963961_5f55391b","line":543,"updated":"2015-03-26 21:20:49.000000000","message":"this could be broken up with comments to be a bit cleaner, but that\u0027s OK","commit_id":"be7e5308fb5499c53fe4b4f0d475df9bdf2a005e"}]}