)]}'
{"etc/keystone.conf.sample":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"9bb02b359526208ab57720920057675ea830da38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba3cc151_eb30e1ea","updated":"2015-07-06 11:57:30.000000000","message":"please do not update this file by yourself, it will be updated by one of the core reviewers some time later.","commit_id":"3f556d6ad196a812d2de6db37c9f2f048b2067f8"}],"keystone/common/environment/__init__.py":[{"author":{"_account_id":5334,"name":"Sushma Korati","email":"sushma_korati@persistent.co.in","username":"sushma-korati"},"change_message_id":"1d7a489ac1d4eccfa97634625818a8b1494dae18","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_2165bd44","line":19,"updated":"2015-03-20 08:34:10.000000000","message":"It will be good to import modules in alphabetical order,  oslo_config above oslo_log module.","commit_id":"ab6f0844aee43652fbab2bd10296435b62785e71"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ac6995a8e62c7ecd788d6eff5ee88cfb9b27ddb6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_367939fd","line":19,"in_reply_to":"9a80dd14_2165bd44","updated":"2015-03-23 05:45:20.000000000","message":"Yes, this will cause a PEP8 error.","commit_id":"ab6f0844aee43652fbab2bd10296435b62785e71"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ac6995a8e62c7ecd788d6eff5ee88cfb9b27ddb6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                               help\u003d\"Maximum line size of message headers to be accepted. \""},{"line_number":80,"context_line":"                                               \"max_header_line may need to be increased when using \""},{"line_number":81,"context_line":"                                               \"large tokens (typically those generated by the \""},{"line_number":82,"context_line":"                                               \"Keystone v3 API with big service catalogs).\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(ldbragst): Explicitly declare what should be monkey patched and"},{"line_number":85,"context_line":"    # what shouldn\u0027t. Doing this allows for more readable code when"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_f676c105","line":82,"updated":"2015-03-23 05:45:20.000000000","message":"This statement is a little confusing since someone could use UUID tokens with v3 API and a big service catalog and have no issues with header lengths.","commit_id":"ab6f0844aee43652fbab2bd10296435b62785e71"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e9501174020cdbc7c9cd1f7261255ed444a7f096","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    # Raise the default from 8192 to accommodate large tokens"},{"line_number":77,"context_line":"    eventlet.wsgi.MAX_HEADER_LINE \u003d cfg.IntOpt(\u0027max_header_line\u0027,"},{"line_number":78,"context_line":"                                               default\u003d16384,"},{"line_number":79,"context_line":"                                               help\u003d\"Maximum line size of message headers to be accepted. \")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # NOTE(ldbragst): Explicitly declare what should be monkey patched and"},{"line_number":82,"context_line":"    # what shouldn\u0027t. Doing this allows for more readable code when"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_d631970c","line":79,"updated":"2015-03-24 00:30:59.000000000","message":"This will not work the way this is done in keystone. You will need to add the opt to keystone.common.config to register the option and reference the appropriate eventlet-specific location for options:\n\nCONF.\u003ceventlet group\u003e.max_header_line","commit_id":"8b2d14c0e04652e56ab0b5a27218a3647a7f9d66"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"627467372526210dd2c8ff071019ae3fb076578a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    # Raise the default from 8192 to accommodate large tokens"},{"line_number":77,"context_line":"    eventlet.wsgi.MAX_HEADER_LINE \u003d cfg.IntOpt(\u0027max_header_line\u0027,"},{"line_number":78,"context_line":"                                               default\u003d16384,"},{"line_number":79,"context_line":"                                               help\u003d\"Maximum line size of message headers to be accepted. \")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # NOTE(ldbragst): Explicitly declare what should be monkey patched and"},{"line_number":82,"context_line":"    # what shouldn\u0027t. Doing this allows for more readable code when"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af86dd1_0a52e913","line":79,"updated":"2015-06-12 11:34:23.000000000","message":"you should wrap it at 79 characters as per python coding convention.","commit_id":"8b2d14c0e04652e56ab0b5a27218a3647a7f9d66"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"1d347043b5e101e53163b5af0af14a890ecfa216","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    # Raise the default from 8192 to accommodate large tokens"},{"line_number":77,"context_line":"    eventlet.wsgi.MAX_HEADER_LINE \u003d cfg.IntOpt(\u0027max_header_line\u0027,"},{"line_number":78,"context_line":"                                               default\u003d16384,"},{"line_number":79,"context_line":"                                               help\u003d\"Maximum line size of message headers to be accepted. \")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # NOTE(ldbragst): Explicitly declare what should be monkey patched and"},{"line_number":82,"context_line":"    # what shouldn\u0027t. Doing this allows for more readable code when"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af86dd1_98cbd772","line":79,"in_reply_to":"1a6ced46_d631970c","updated":"2015-06-12 08:47:15.000000000","message":"Seems like this is not a correct way to fix the bug in keystone since this patch failed py27","commit_id":"8b2d14c0e04652e56ab0b5a27218a3647a7f9d66"}]}