)]}'
{"keystone/catalog/backends/sql.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"25f3aae274d881433a55825bebfd46fe5aa67f5c","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            try:"},{"line_number":293,"context_line":"                url \u003d core.format_url(endpoint[\u0027url\u0027], substitutions,"},{"line_number":294,"context_line":"                                      allow_substitution_keyerror)"},{"line_number":295,"context_line":"            except exception.MalformedEndpoint:"},{"line_number":296,"context_line":"                continue  # this failure is already logged in format_url()"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            region \u003d endpoint[\u0027region_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_a55bfa85","line":295,"updated":"2015-03-24 08:48:29.000000000","message":"I really like this approach, it looks better, but one concern from me is this will skip the service entirely. Although the endpoints is not needed but other attributes still needed or not? such as \"type\", \"name\" or \"id\". we can say the URL is not opened to client specific service but we cannot say the service is not existed, right?\n\nI am not pretty sure about this, the context seems like favor to drop other attributes as well.\n\nOnce this is confirmed, I will merge two patches together.\n\nThanks!","commit_id":"ee3842195e042d1af47e13e2e302c65b5b54b15f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"293586184b276cecadff32a47c1f9a09f94b8292","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            try:"},{"line_number":293,"context_line":"                url \u003d core.format_url(endpoint[\u0027url\u0027], substitutions,"},{"line_number":294,"context_line":"                                      allow_substitution_keyerror)"},{"line_number":295,"context_line":"            except exception.MalformedEndpoint:"},{"line_number":296,"context_line":"                continue  # this failure is already logged in format_url()"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            region \u003d endpoint[\u0027region_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_a0acc8a1","line":295,"in_reply_to":"1a6ced46_a55bfa85","updated":"2015-03-24 09:14:38.000000000","message":"So I think you are correct, that IF all the endpoints for a given service required a tenant ID, then the whole service would then be absent from the resulting catalog. I\u0027m not sure a service without endpoints would be much use to anyone...so my gut feel is that this is OK. We may want to run this past MorganFainberg/Dolphm, who had commented on this before...","commit_id":"ee3842195e042d1af47e13e2e302c65b5b54b15f"}]}
