)]}'
{"keystone/token/controllers.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"98d069b413077a73b0f8273b8c6f649720daf03d","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            if not role_list:"},{"line_number":391,"context_line":"                msg \u003d _LW(\u0027User %(u_id)s is unauthorized for tenant %(t_id)s\u0027)"},{"line_number":392,"context_line":"                msg \u003d msg % {\u0027u_id\u0027: user_id, \u0027t_id\u0027: tenant_id}"},{"line_number":393,"context_line":"                LOG.warning(msg)"},{"line_number":394,"context_line":"                raise exception.Unauthorized(msg)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        return (tenant_ref, role_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_eca33e9d","line":393,"updated":"2015-04-13 03:06:19.000000000","message":"Something wrong here. _(msg) should be used for the exception and _LW for the log message. Also params should be passed to warning function, not interpolated. \n\nIt\u0027s not particularly efficient but you might need to translate it twice, once for each mechanism.","commit_id":"55bb0e1cee1f56fb09031d452a55b9f0dee9bbaa"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"2b5bb4e75b9411b27c6f516a6be076a62dc5df3c","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                msg \u003d _LW(\u0027User %(u_id)s is unauthorized for tenant %(t_id)s\u0027)"},{"line_number":392,"context_line":"                msg \u003d msg % {\u0027u_id\u0027: user_id, \u0027t_id\u0027: tenant_id}"},{"line_number":393,"context_line":"                LOG.warning(msg)"},{"line_number":394,"context_line":"                raise exception.Unauthorized(msg)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        return (tenant_ref, role_list)"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_acf1b6cf","line":394,"updated":"2015-04-13 02:53:46.000000000","message":"It seams that this is wrong? https://github.com/openstack/oslo.i18n/blob/master/doc/source/guidelines.rst#choosing-a-marker-function","commit_id":"55bb0e1cee1f56fb09031d452a55b9f0dee9bbaa"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"064f1dbc29eab8f8d09c26e4ccf231af7804eb8c","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                msg \u003d _LW(\u0027User %(u_id)s is unauthorized for tenant %(t_id)s\u0027)"},{"line_number":392,"context_line":"                msg \u003d msg % {\u0027u_id\u0027: user_id, \u0027t_id\u0027: tenant_id}"},{"line_number":393,"context_line":"                LOG.warning(msg)"},{"line_number":394,"context_line":"                raise exception.Unauthorized(msg)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        return (tenant_ref, role_list)"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_ad23bba6","line":394,"in_reply_to":"7aaa499b_acf1b6cf","updated":"2015-04-14 11:50:25.000000000","message":"So looks like:\n\na) this should remain as _()\nb) the issue of not passing the params into LOG.warning() is different bug, and I will raise that separately","commit_id":"55bb0e1cee1f56fb09031d452a55b9f0dee9bbaa"}]}