)]}'
{"keystone/contrib/federation/controllers.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"558a5017fc4eeda88f01ed0860b1655821e86617","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            remote_id_name \u003d CONF.federation.remote_id_attribute"},{"line_number":272,"context_line":"            remote_id \u003d context[\u0027environment\u0027][remote_id_name]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            msg \u003d _LE(\u0027Missing entity ID from environment\u0027)"},{"line_number":275,"context_line":"            LOG.error(msg)"},{"line_number":276,"context_line":"            raise exception.Unauthorized(msg)"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_fc51c00f","line":274,"updated":"2015-04-16 00:42:05.000000000","message":"If the message is also going to the user, we need to keep using _().\n\n\nSee first example of \"Do not do this\"\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"47c44c53a69419734fb63472fd428f07c113e6c9"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7b3044253016c575a31c0bbfbb13d061a4a4fd67","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            remote_id_name \u003d CONF.federation.remote_id_attribute"},{"line_number":272,"context_line":"            remote_id \u003d context[\u0027environment\u0027][remote_id_name]"},{"line_number":273,"context_line":"        except KeyError:"},{"line_number":274,"context_line":"            msg \u003d _LE(\u0027Missing entity ID from environment\u0027)"},{"line_number":275,"context_line":"            LOG.error(msg)"},{"line_number":276,"context_line":"            raise exception.Unauthorized(msg)"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_90594c5d","line":274,"in_reply_to":"5aa745d1_fc51c00f","updated":"2015-05-01 01:34:55.000000000","message":"++ nice catch Lin\n\nNice to know this.","commit_id":"47c44c53a69419734fb63472fd428f07c113e6c9"}],"keystone/contrib/federation/idp.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"558a5017fc4eeda88f01ed0860b1655821e86617","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                return sigver.read_cert_from_file(CONF.saml.certfile, \u0027pem\u0027)"},{"line_number":453,"context_line":"            except (IOError, sigver.CertificateError) as e:"},{"line_number":454,"context_line":"                msg \u003d _LE(\u0027Cannot open certificate %(cert_file)s. \u0027"},{"line_number":455,"context_line":"                          \u0027Reason: %(reason)s\u0027)"},{"line_number":456,"context_line":"                msg \u003d msg % {\u0027cert_file\u0027: CONF.saml.certfile, \u0027reason\u0027: e}"},{"line_number":457,"context_line":"                LOG.error(msg)"},{"line_number":458,"context_line":"                raise IOError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_7c3ed0b9","line":455,"updated":"2015-04-16 00:42:05.000000000","message":"Same here keep _()","commit_id":"47c44c53a69419734fb63472fd428f07c113e6c9"}],"keystone/notifications.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"558a5017fc4eeda88f01ed0860b1655821e86617","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    for callback in callbacks:"},{"line_number":278,"context_line":"        if not callable(callback):"},{"line_number":279,"context_line":"            msg \u003d _LE(\u0027Method not callable: %s\u0027) % callback"},{"line_number":280,"context_line":"            LOG.error(msg)"},{"line_number":281,"context_line":"            raise TypeError(msg)"},{"line_number":282,"context_line":"        _SUBSCRIBERS.setdefault(event, {}).setdefault(resource_type, set())"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_5c4b145a","line":279,"updated":"2015-04-16 00:42:05.000000000","message":"Same here keep _()","commit_id":"47c44c53a69419734fb63472fd428f07c113e6c9"}],"keystone/token/providers/common.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"558a5017fc4eeda88f01ed0860b1655821e86617","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        elif isinstance(audit_info, list):"},{"line_number":405,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d audit_info"},{"line_number":406,"context_line":"        else:"},{"line_number":407,"context_line":"            msg \u003d (_LE(\u0027Invalid audit info data type: %(data)s (%(type)s)\u0027) %"},{"line_number":408,"context_line":"                   {\u0027data\u0027: audit_info, \u0027type\u0027: type(audit_info)})"},{"line_number":409,"context_line":"            LOG.error(msg)"},{"line_number":410,"context_line":"            raise exception.UnexpectedError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_1c746c9a","line":407,"updated":"2015-04-16 00:42:05.000000000","message":"Same here keep _()","commit_id":"47c44c53a69419734fb63472fd428f07c113e6c9"}],"keystone/token/providers/fernet/utils.py":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"7b3044253016c575a31c0bbfbb13d061a4a4fd67","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    try:"},{"line_number":60,"context_line":"        id_int \u003d int(id_value)"},{"line_number":61,"context_line":"    except ValueError as e:"},{"line_number":62,"context_line":"        msg \u003d _LE(\u0027Unable to convert Keystone user or group ID. Error: %s\u0027)"},{"line_number":63,"context_line":"        LOG.error(msg, e)"},{"line_number":64,"context_line":"        raise"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_b021e8b6","line":62,"updated":"2015-05-01 01:34:55.000000000","message":"Yes, this one, as it is just using the message for logging, _LE is pretty appropriate.","commit_id":"47c44c53a69419734fb63472fd428f07c113e6c9"}]}
