)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8037b4431bb187da512e499a547e0313ea884d8e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For backward compatiblity, old and new format of event"},{"line_number":10,"context_line":"type will still be sent. The old format is marked as"},{"line_number":11,"context_line":"deprecated and to be remove in the next release."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Lin Hua Cheng \u003cos.lcheng@gmail.com\u003e"},{"line_number":14,"context_line":"Change-Id: Ic19e8e6983e63789b42d8fb9677ffd115a40fc9e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6ced46_14bf39ab","line":11,"updated":"2015-03-26 09:21:14.000000000","message":"(nit): s/remove/removed","commit_id":"b602f58d18924821363fab0f95b71ef8a4ca223c"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"df03b2cfcbf20bbe199569496a7aa76579e113fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename notification for create/delete grants"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For backward compatiblity, old and new format of event"},{"line_number":10,"context_line":"type will still be sent. The old format is marked as"},{"line_number":11,"context_line":"deprecated and to be removed in the next release."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da9b358b_94b6e388","line":9,"updated":"2015-03-30 19:45:12.000000000","message":"I put a note about this in the bug report, but how does this impact the reporting/monitoring people. It would be nice to have a link to the discussion in the bug.","commit_id":"c79fc1c4007d5dc5d6547e61337a836dfac05168"}],"keystone/notifications.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"302d80596ba94b4b21ce3987d977707e28be42b6","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        self.deprecated_event_type \u003d \u0027%s.%s.%s\u0027 % (SERVICE, operation,"},{"line_number":528,"context_line":"                                                   self.ROLE_ASSIGNMENT)"},{"line_number":529,"context_line":"        self.event_type \u003d \u0027%s.%s.%s\u0027 % (SERVICE, self.ROLE_ASSIGNMENT,"},{"line_number":530,"context_line":"                                        operation)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    def __call__(self, f):"},{"line_number":533,"context_line":"        def wrapper(wrapped_self, role_id, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_4d94ed42","line":530,"updated":"2015-03-25 13:37:41.000000000","message":"nit: I think it might be better if you keep the same parameters order .","commit_id":"def8e559f3d9d3cec1c9f2983bd27a6df500c8bf"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15024ceab63d45a0ac5343c668ea4dd170212e2a","unresolved":false,"context_lines":[{"line_number":527,"context_line":"        self.deprecated_event_type \u003d \u0027%s.%s.%s\u0027 % (SERVICE, operation,"},{"line_number":528,"context_line":"                                                   self.ROLE_ASSIGNMENT)"},{"line_number":529,"context_line":"        self.event_type \u003d \u0027%s.%s.%s\u0027 % (SERVICE, self.ROLE_ASSIGNMENT,"},{"line_number":530,"context_line":"                                        operation)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    def __call__(self, f):"},{"line_number":533,"context_line":"        def wrapper(wrapped_self, role_id, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_2b7234ad","line":530,"in_reply_to":"1a6ced46_4d94ed42","updated":"2015-03-25 15:50:39.000000000","message":"the point of the patch is to swap the order.\n\nfrom identity.role_assignment.created to identity.created.role_assignment","commit_id":"def8e559f3d9d3cec1c9f2983bd27a6df500c8bf"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"35d5ab9938c5280eb3ca8d26c17be626eca8596e","unresolved":false,"context_lines":[{"line_number":586,"context_line":""},{"line_number":587,"context_line":"            # For backward compatability, send both old and new event_type."},{"line_number":588,"context_line":"            # Deprecate old format and remove it in the next release."},{"line_number":589,"context_line":"            event_types \u003d [self.event_type, self.deprecated_event_type]"},{"line_number":590,"context_line":"            versionutils.deprecated("},{"line_number":591,"context_line":"                as_of\u003dversionutils.deprecated.KILO,"},{"line_number":592,"context_line":"                remove_in\u003d+1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_6b8095c0","line":589,"updated":"2015-03-26 02:59:10.000000000","message":"you might have to flip the order here, to satisfy the tests; or change the tests around (since it only saves the most recent notification).\n\nI think it\u0027s safe to flip the order of the notifications, it shouldn\u0027t matter which event goes off first.","commit_id":"1e42a340225b0819ed6c604b86c04ce77d575723"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ed4542de40983232e5696cda7e6979c0aaf16851","unresolved":false,"context_lines":[{"line_number":586,"context_line":""},{"line_number":587,"context_line":"            # For backward compatability, send both old and new event_type."},{"line_number":588,"context_line":"            # Deprecate old format and remove it in the next release."},{"line_number":589,"context_line":"            event_types \u003d [self.event_type, self.deprecated_event_type]"},{"line_number":590,"context_line":"            versionutils.deprecated("},{"line_number":591,"context_line":"                as_of\u003dversionutils.deprecated.KILO,"},{"line_number":592,"context_line":"                remove_in\u003d+1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_4633d013","line":589,"in_reply_to":"1a6ced46_6b8095c0","updated":"2015-03-26 04:25:32.000000000","message":"yup, it should be fine. Thanks!","commit_id":"1e42a340225b0819ed6c604b86c04ce77d575723"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"8037b4431bb187da512e499a547e0313ea884d8e","unresolved":false,"context_lines":[{"line_number":590,"context_line":"            versionutils.deprecated("},{"line_number":591,"context_line":"                as_of\u003dversionutils.deprecated.KILO,"},{"line_number":592,"context_line":"                remove_in\u003d+1,"},{"line_number":593,"context_line":"                what\u003d(\u0027sending %s notification event type\u0027 %"},{"line_number":594,"context_line":"                      self.deprecated_event_type),"},{"line_number":595,"context_line":"                in_favor_of\u003d\u0027%s notification event type\u0027 % self.event_type)"},{"line_number":596,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_5419b1d5","line":593,"updated":"2015-03-26 09:21:14.000000000","message":"maybe say \"sending duplicate %s notification....\"?","commit_id":"b602f58d18924821363fab0f95b71ef8a4ca223c"}]}