)]}'
{"keystone/common/sql/migration_helpers.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"a05238dcd59e3d0102e31d36b9e258976ece1f50","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    if version is not None:"},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            current_ver \u003d int(six.text_type(get_db_version(extension)))"},{"line_number":184,"context_line":"            if version \u003c current_ver:"},{"line_number":185,"context_line":"                raise migration.exception.DbMigrationError()"},{"line_number":186,"context_line":"        except exceptions.DatabaseNotControlledError:"},{"line_number":187,"context_line":"            # NOTE(morganfainberg): The database is not controlled, this action"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_d9007aad","line":184,"updated":"2015-03-26 08:38:54.000000000","message":"version is str here, current_ver is str. If version is \u002745\u0027 and current_version is 60, version \u003c current_ver will be False. You can start ranting about Python2 now.","commit_id":"190ce5f783468311b886ed1795d255160b886e59"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"7d1a759e3a654c6163259546ad987795de08aa4d","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    if version is not None:"},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            current_ver \u003d int(six.text_type(get_db_version(extension)))"},{"line_number":184,"context_line":"            if version \u003c current_ver:"},{"line_number":185,"context_line":"                raise migration.exception.DbMigrationError()"},{"line_number":186,"context_line":"        except exceptions.DatabaseNotControlledError:"},{"line_number":187,"context_line":"            # NOTE(morganfainberg): The database is not controlled, this action"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_103b26ed","line":184,"in_reply_to":"1a6ced46_79b786f5","updated":"2015-03-26 19:10:24.000000000","message":"Done\n\nThis will need to change when we have Alembic.","commit_id":"190ce5f783468311b886ed1795d255160b886e59"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"aa1dd2d61942d6c19f5c6c05e921bc914b59d7ec","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    if version is not None:"},{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            current_ver \u003d int(six.text_type(get_db_version(extension)))"},{"line_number":184,"context_line":"            if version \u003c current_ver:"},{"line_number":185,"context_line":"                raise migration.exception.DbMigrationError()"},{"line_number":186,"context_line":"        except exceptions.DatabaseNotControlledError:"},{"line_number":187,"context_line":"            # NOTE(morganfainberg): The database is not controlled, this action"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_79b786f5","line":184,"in_reply_to":"1a6ced46_d9007aad","updated":"2015-03-26 08:40:36.000000000","message":"sorry. version is str here, current_ver is int.","commit_id":"190ce5f783468311b886ed1795d255160b886e59"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"3ee51b92a01903b86821258058f38343bd73b2b0","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        try:"},{"line_number":183,"context_line":"            current_ver \u003d int(six.text_type(get_db_version(extension)))"},{"line_number":184,"context_line":"            if int(version) \u003c current_ver:"},{"line_number":185,"context_line":"                raise migration.exception.DbMigrationError()"},{"line_number":186,"context_line":"        except exceptions.DatabaseNotControlledError:"},{"line_number":187,"context_line":"            # NOTE(morganfainberg): The database is not controlled, this action"},{"line_number":188,"context_line":"            # cannot be a downgrade."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_5f48995b","line":185,"updated":"2015-03-26 20:54:46.000000000","message":"I\u0027d like to see here a more descriptive message. It can be addressed in a follow-up though.","commit_id":"0d08cac3957fcc5259c2500496e067ddcf124d2d"}],"keystone/tests/unit/test_sql_migrate_extensions.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"f4b67826ce0d80b13be2e39700cc5c5eb36c3167","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"class RevokeExtension(test_sql_upgrade.SqlMigrateBase):"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    _REVOKE_COLUMN_NAMES \u003d [\u0027id\u0027, \u0027domain_id\u0027, \u0027project_id\u0027, \u0027user_id\u0027,"},{"line_number":317,"context_line":"                            \u0027role_id\u0027, \u0027trust_id\u0027, \u0027consumer_id\u0027,"},{"line_number":318,"context_line":"                            \u0027access_token_id\u0027, \u0027issued_before\u0027, \u0027expires_at\u0027,"},{"line_number":319,"context_line":"                            \u0027revoked_at\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_501763a3","line":316,"updated":"2015-03-27 01:27:42.000000000","message":"should be able to just call it COLUMN_NAMES now.","commit_id":"0d08cac3957fcc5259c2500496e067ddcf124d2d"}]}