)]}'
{"keystone/contrib/federation/migrate_repo/versions/007_add_remote_id_table.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ab1d40ba42760c2dcc4d9cd5de3de158c1ba2297","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                      idp_table.c.remote_id):"},{"line_number":40,"context_line":"            remote_idp_entry \u003d {\u0027idp_id\u0027: identity.id,"},{"line_number":41,"context_line":"                                \u0027remote_id\u0027: identity.remote_id}"},{"line_number":42,"context_line":"            new_session \u003d sessionmaker(bind\u003dmigrate_engine)()"},{"line_number":43,"context_line":"            remote_id_table.insert(remote_idp_entry).execute()"},{"line_number":44,"context_line":"            new_session.commit()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_4d46a124","line":42,"updated":"2015-03-27 09:37:30.000000000","message":"do you need to create a new session everytime? In general I agree with a belt-and-braces approach and not trying to be clever in these kind of things...so not really objecting....","commit_id":"c1ec463931f557bd7fe5c98b9c63153c0c9cbc7e"},{"author":{"_account_id":10335,"name":"Marco Fargetta","email":"marco.fargetta@ct.infn.it","username":"fmarco76"},"change_message_id":"2a93542f10f329f86fb6452a3647039364212de2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                      idp_table.c.remote_id):"},{"line_number":40,"context_line":"            remote_idp_entry \u003d {\u0027idp_id\u0027: identity.id,"},{"line_number":41,"context_line":"                                \u0027remote_id\u0027: identity.remote_id}"},{"line_number":42,"context_line":"            new_session \u003d sessionmaker(bind\u003dmigrate_engine)()"},{"line_number":43,"context_line":"            remote_id_table.insert(remote_idp_entry).execute()"},{"line_number":44,"context_line":"            new_session.commit()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_786ec5ca","line":42,"in_reply_to":"fa963961_4d46a124","updated":"2015-03-27 10:09:06.000000000","message":"I agree with henry-nash. Create new session is a waste. Additionally, I think the session is not used here so you do not need to create a session and commit the session because the insert is not in a transaction but only the query.\n\nI have tested without line 42 and 44 and it works properly.","commit_id":"c1ec463931f557bd7fe5c98b9c63153c0c9cbc7e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8372128f1cad20770628c5d6cebe1371fb39b1d6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                      idp_table.c.remote_id):"},{"line_number":40,"context_line":"            remote_idp_entry \u003d {\u0027idp_id\u0027: identity.id,"},{"line_number":41,"context_line":"                                \u0027remote_id\u0027: identity.remote_id}"},{"line_number":42,"context_line":"            new_session \u003d sessionmaker(bind\u003dmigrate_engine)()"},{"line_number":43,"context_line":"            remote_id_table.insert(remote_idp_entry).execute()"},{"line_number":44,"context_line":"            new_session.commit()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_a109a62e","line":42,"in_reply_to":"fa963961_786ec5ca","updated":"2015-03-27 17:41:28.000000000","message":"Done, thanks everyone","commit_id":"c1ec463931f557bd7fe5c98b9c63153c0c9cbc7e"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"4afdb8a7e19e6693497393a7873ea863c9bd2d91","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                      idp_table.c.remote_id):"},{"line_number":40,"context_line":"            remote_idp_entry \u003d {\u0027idp_id\u0027: identity.id,"},{"line_number":41,"context_line":"                                \u0027remote_id\u0027: identity.remote_id}"},{"line_number":42,"context_line":"            new_session \u003d sessionmaker(bind\u003dmigrate_engine)()"},{"line_number":43,"context_line":"            remote_id_table.insert(remote_idp_entry).execute()"},{"line_number":44,"context_line":"            new_session.commit()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_2a2578aa","line":42,"in_reply_to":"fa963961_786ec5ca","updated":"2015-03-27 14:35:10.000000000","message":"Who cares? It\u0027s a migration!","commit_id":"c1ec463931f557bd7fe5c98b9c63153c0c9cbc7e"}]}