)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7810ca58c89516adeb5e8eade87004f03441fcef","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Extract response headers to private method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both create_saml_assertion() and create_ecp_assertion() methods"},{"line_number":10,"context_line":"returns the same headers, this patch extracts the creation of"},{"line_number":11,"context_line":"these headers to a private method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7f6a3664b3aea9c1ef6aeb44530ff3b279ebc6b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_29a6bfc1","line":10,"updated":"2015-03-30 00:51:36.000000000","message":"change \"returns\" to \"return\"","commit_id":"8310f3097e26b5f4627452f467cc3b013ecfa63a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3d142ff582c67990080e85c2e2f9b623e2dfa28c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Extract response headers to private method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both create_saml_assertion() and create_ecp_assertion() methods"},{"line_number":10,"context_line":"returns the same headers, this patch extracts the creation of"},{"line_number":11,"context_line":"these headers to a private method."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I7f6a3664b3aea9c1ef6aeb44530ff3b279ebc6b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_c954f355","line":10,"in_reply_to":"da9b358b_29a6bfc1","updated":"2015-03-30 01:19:06.000000000","message":"Done","commit_id":"8310f3097e26b5f4627452f467cc3b013ecfa63a"}],"keystone/contrib/federation/controllers.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7810ca58c89516adeb5e8eade87004f03441fcef","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        t \u003d self._create_base_saml_assertion(context, auth)"},{"line_number":352,"context_line":"        (response, service_provider) \u003d t"},{"line_number":353,"context_line":"        sp_url \u003d service_provider.get(\u0027sp_url\u0027)"},{"line_number":354,"context_line":"        auth_url \u003d service_provider.get(\u0027auth_url\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        headers \u003d self._build_response_headers(auth_url, sp_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_298d9f31","line":353,"updated":"2015-03-30 00:51:36.000000000","message":"(unrelated) is this really supposed be be get()? This will potentially set sp_url to None and then the header will be set to \"None\".","commit_id":"8310f3097e26b5f4627452f467cc3b013ecfa63a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3d142ff582c67990080e85c2e2f9b623e2dfa28c","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        t \u003d self._create_base_saml_assertion(context, auth)"},{"line_number":352,"context_line":"        (response, service_provider) \u003d t"},{"line_number":353,"context_line":"        sp_url \u003d service_provider.get(\u0027sp_url\u0027)"},{"line_number":354,"context_line":"        auth_url \u003d service_provider.get(\u0027auth_url\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        headers \u003d self._build_response_headers(auth_url, sp_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_095adb83","line":353,"in_reply_to":"da9b358b_298d9f31","updated":"2015-03-30 01:19:06.000000000","message":"++ the value can not be None (they aren\u0027t nullable)","commit_id":"8310f3097e26b5f4627452f467cc3b013ecfa63a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7810ca58c89516adeb5e8eade87004f03441fcef","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        sp_url \u003d service_provider.get(\u0027sp_url\u0027)"},{"line_number":354,"context_line":"        auth_url \u003d service_provider.get(\u0027auth_url\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        headers \u003d self._build_response_headers(auth_url, sp_url)"},{"line_number":357,"context_line":"        return wsgi.render_response(body\u003dresponse.to_string(),"},{"line_number":358,"context_line":"                                    status\u003d(\u0027200\u0027, \u0027OK\u0027),"},{"line_number":359,"context_line":"                                    headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_899f0b5f","line":356,"updated":"2015-03-30 00:51:36.000000000","message":"pass service_provider into this method instead.","commit_id":"8310f3097e26b5f4627452f467cc3b013ecfa63a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3d142ff582c67990080e85c2e2f9b623e2dfa28c","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        sp_url \u003d service_provider.get(\u0027sp_url\u0027)"},{"line_number":354,"context_line":"        auth_url \u003d service_provider.get(\u0027auth_url\u0027)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        headers \u003d self._build_response_headers(auth_url, sp_url)"},{"line_number":357,"context_line":"        return wsgi.render_response(body\u003dresponse.to_string(),"},{"line_number":358,"context_line":"                                    status\u003d(\u0027200\u0027, \u0027OK\u0027),"},{"line_number":359,"context_line":"                                    headers\u003dheaders)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_e95e9775","line":356,"in_reply_to":"da9b358b_899f0b5f","updated":"2015-03-30 01:19:06.000000000","message":"Done","commit_id":"8310f3097e26b5f4627452f467cc3b013ecfa63a"}]}