)]}'
{"keystone/auth/controllers.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"84903186eb19cc6c42b8c8b6c955e7078907811f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    # have setup all the appropriate configuration options we may need."},{"line_number":52,"context_line":"    config.setup_authentication()"},{"line_number":53,"context_line":"    for plugin in CONF.auth.methods:"},{"line_number":54,"context_line":"        plugin_class \u003d CONF.auth[plugin]"},{"line_number":55,"context_line":"        driver \u003d importutils.import_object(plugin_class)"},{"line_number":56,"context_line":"        if plugin in AUTH_METHODS:"},{"line_number":57,"context_line":"            raise ValueError(_(\u0027Auth plugin %(plugin)s is requesting \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_fbd1a4fc","line":54,"updated":"2015-04-23 14:21:34.000000000","message":"should wrap this with a try/except to raise a friendly (critical) error message in the event a plugin appears in [auth] methods but isn\u0027t actually defined","commit_id":"883bd5c6cb2f6a988866a67cd580d098a8b6874d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c5542d79e64ddb8e14552e37616357c640e163ec","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    # have setup all the appropriate configuration options we may need."},{"line_number":52,"context_line":"    config.setup_authentication()"},{"line_number":53,"context_line":"    for plugin in CONF.auth.methods:"},{"line_number":54,"context_line":"        plugin_class \u003d CONF.auth[plugin]"},{"line_number":55,"context_line":"        driver \u003d importutils.import_object(plugin_class)"},{"line_number":56,"context_line":"        if plugin in AUTH_METHODS:"},{"line_number":57,"context_line":"            raise ValueError(_(\u0027Auth plugin %(plugin)s is requesting \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_9d768ed5","line":54,"in_reply_to":"bab921fb_fbd1a4fc","updated":"2015-04-26 15:35:57.000000000","message":"I\u0027m not sure what\u0027s meant here -- do you want the server to log an error and continue on, or log an error and fail to start?","commit_id":"883bd5c6cb2f6a988866a67cd580d098a8b6874d"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"fda420c688f0983f0199dd626d1891c6c19ac7af","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            plugin_name \u003d driver.method"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            plugin_name \u003d plugin"},{"line_number":68,"context_line":"            plugin_class \u003d CONF.auth[plugin]"},{"line_number":69,"context_line":"            driver \u003d importutils.import_object(plugin_class)"},{"line_number":70,"context_line":"        if plugin_name in AUTH_METHODS:"},{"line_number":71,"context_line":"            raise ValueError(_(\u0027Auth plugin %(plugin)s is requesting \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_80456218","line":68,"updated":"2015-05-02 21:25:10.000000000","message":"I think we should check if the provided plugin is supported. If it isnt\u0027t we should raise an exception, instead of expecting a python error when accessing this key (or when loading the driver, as it was before).","commit_id":"c12b24e85a228eaf26f8e42086ee69de0c3aacec"}]}