)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"56f93a1eb57de4c132e12ef2fc3f425cdc7ea714","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave Chen \u003cwei.d.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-05 10:25:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Minor change in the docstring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docstring for class: MemcachedBackend is not accurate enough."},{"line_number":10,"context_line":"- The name of the argument is `memcached_backend` instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_01a90424","line":7,"updated":"2015-05-30 12:47:14.000000000","message":"\"Minor changes to rename driver to backend\" since you change more than the docstring","commit_id":"2ec715a12a1b33075068ab4f5fb2ded0a066bda2"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"01ecc50a8626b7ba8b61018921bc416904b50612","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave Chen \u003cwei.d.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-05 10:25:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Minor change in the docstring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docstring for class: MemcachedBackend is not accurate enough."},{"line_number":10,"context_line":"- The name of the argument is `memcached_backend` instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_444eea3b","line":7,"in_reply_to":"7a016987_01a90424","updated":"2015-05-30 13:48:33.000000000","message":"Done","commit_id":"2ec715a12a1b33075068ab4f5fb2ded0a066bda2"}],"keystone/common/kvs/backends/memcached.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"103e957422c2fd10590b740c746a476332863587","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` are valid) or `memcached` based"},{"line_number":81,"context_line":"    `pooled_memcached`."},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    def __init__(self, arguments):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_57d57e19","line":80,"updated":"2015-04-10 08:40:26.000000000","message":"I think you can simply add pooled_memcached to the valid tuple","commit_id":"88db6d8ddb88f34e2d2457291d7bb6c058898af9"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"81d54b9e67a7c7780bc023e5d05781fcef18b5ba","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` are valid) or `memcached` based"},{"line_number":81,"context_line":"    `pooled_memcached`."},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    def __init__(self, arguments):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_bf4c1343","line":80,"in_reply_to":"7aaa499b_c18f0722","updated":"2015-04-14 02:10:37.000000000","message":"Hmm, the change here looks ambiguously, indeed. I am going to re-version this change and submit for review again.\n\nFor your question, per my understanding, dogpile.cache has three basic memcached driver: `memcached`, `bmemcached` and `pylibmc`. As to `pooled_memcached\u0027, it\u0027s provided by Keystone but it\u0027s based on dogpile.cache\u0027s `memcached` driver. Not sure whether it\u0027s more clear. :)\n\nI am also considering to describe it in some docs to echo Lance\u0027s comment.\n\nThanks!","commit_id":"88db6d8ddb88f34e2d2457291d7bb6c058898af9"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"f851a1659e14e008c6b707018b9a9f7dcd6afe12","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` are valid) or `memcached` based"},{"line_number":81,"context_line":"    `pooled_memcached`."},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    def __init__(self, arguments):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_c18f0722","line":80,"in_reply_to":"7aaa499b_fe8e6126","updated":"2015-04-13 21:36:47.000000000","message":"Dave: the amendment to this sentence does not make sense to me, as it is an now an incomplete / run on sentence.\n\nThe original sentence reads \"To achieve X, you need a Y (such as A, B, or C).\" I don\u0027t know how to read the amendment: is `memcached` an option \"D,\" or is it instead of a \"Y\"?\n\nIs there supposed to be a hyphen in `memcached`-based? Is `pooled_memcached` a potential value of `memcached_backend`? To add to my confusion, `memcached` is already in the list provided in parens.\n\nI really don\u0027t understand the intent of the change, so it\u0027s hard for me to suggest edits :(","commit_id":"88db6d8ddb88f34e2d2457291d7bb6c058898af9"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"42ade301e1c3a072ef2dac809aa0dc41552b9c70","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` are valid) or `memcached` based"},{"line_number":81,"context_line":"    `pooled_memcached`."},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    def __init__(self, arguments):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_b24a9824","line":80,"in_reply_to":"9aa53dc9_57d57e19","updated":"2015-04-10 09:09:55.000000000","message":"ZhiQiang, \u0027pooled_memcached\u0027 is not the driver provided by dogpile.cache directly, it should be different with other three drivers in my opinion, let\u0027s open this to others.","commit_id":"88db6d8ddb88f34e2d2457291d7bb6c058898af9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d9ec523db59c85e19382b55e0e82ef4a71dcb42e","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` are valid) or `memcached` based"},{"line_number":81,"context_line":"    `pooled_memcached`."},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    def __init__(self, arguments):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_fe8e6126","line":80,"in_reply_to":"9aa53dc9_b24a9824","updated":"2015-04-10 15:56:58.000000000","message":"Can we point this to some documentation describing the different or add it in here?","commit_id":"88db6d8ddb88f34e2d2457291d7bb6c058898af9"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"0c5e7e2aa90dc7e50654d62c9facd3ab8a3ffb9f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"class MemcachedBackend(object):"},{"line_number":76,"context_line":"    \"\"\"Pivot point to leverage the various dogpile.cache memcached backends."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` and `pooled_memcached` are"},{"line_number":81,"context_line":"    valid)."}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_82145444","line":78,"updated":"2015-05-01 18:40:57.000000000","message":"s/driver/backend in this line as well, to keep this consistent.","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c298f4b0f528aa8548482130c8767f7dd73ebb73","unresolved":false,"context_lines":[{"line_number":75,"context_line":"class MemcachedBackend(object):"},{"line_number":76,"context_line":"    \"\"\"Pivot point to leverage the various dogpile.cache memcached backends."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` and `pooled_memcached` are"},{"line_number":81,"context_line":"    valid)."}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_0e295ce6","line":78,"in_reply_to":"3acd31a7_82145444","updated":"2015-05-05 02:27:54.000000000","message":"Done","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"0c5e7e2aa90dc7e50654d62c9facd3ab8a3ffb9f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"Pivot point to leverage the various dogpile.cache memcached backends."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` and `pooled_memcached` are"},{"line_number":81,"context_line":"    valid)."},{"line_number":82,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_022724b7","line":79,"updated":"2015-05-01 18:40:57.000000000","message":"s/drivers/backends","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c298f4b0f528aa8548482130c8767f7dd73ebb73","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \"\"\"Pivot point to leverage the various dogpile.cache memcached backends."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    To specify a specific dogpile.cache memcached driver, pass the argument"},{"line_number":79,"context_line":"    `memcached_backend` set to one of the provided memcached drivers (at this"},{"line_number":80,"context_line":"    time `memcached`, `bmemcached`, `pylibmc` and `pooled_memcached` are"},{"line_number":81,"context_line":"    valid)."},{"line_number":82,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_ce1ec4ba","line":79,"in_reply_to":"3acd31a7_022724b7","updated":"2015-05-05 02:27:54.000000000","message":"Done","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"0c5e7e2aa90dc7e50654d62c9facd3ab8a3ffb9f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.driver \u003d VALID_DOGPILE_BACKENDS[\u0027memcached\u0027](arguments)"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            if backend not in VALID_DOGPILE_BACKENDS:"},{"line_number":107,"context_line":"                raise ValueError("},{"line_number":108,"context_line":"                    _(\u0027Backend `%(driver)s` is not a valid memcached \u0027"},{"line_number":109,"context_line":"                      \u0027backend. Valid drivers: %(driver_list)s\u0027) %"},{"line_number":110,"context_line":"                    {\u0027driver\u0027: backend,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_a2f630f7","line":107,"updated":"2015-05-01 18:40:57.000000000","message":"s/driver/backend","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c298f4b0f528aa8548482130c8767f7dd73ebb73","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            self.driver \u003d VALID_DOGPILE_BACKENDS[\u0027memcached\u0027](arguments)"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            if backend not in VALID_DOGPILE_BACKENDS:"},{"line_number":107,"context_line":"                raise ValueError("},{"line_number":108,"context_line":"                    _(\u0027Backend `%(driver)s` is not a valid memcached \u0027"},{"line_number":109,"context_line":"                      \u0027backend. Valid drivers: %(driver_list)s\u0027) %"},{"line_number":110,"context_line":"                    {\u0027driver\u0027: backend,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_8e7b2cf5","line":107,"in_reply_to":"3acd31a7_a2f630f7","updated":"2015-05-05 02:27:54.000000000","message":"Done","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"0c5e7e2aa90dc7e50654d62c9facd3ab8a3ffb9f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            if backend not in VALID_DOGPILE_BACKENDS:"},{"line_number":107,"context_line":"                raise ValueError("},{"line_number":108,"context_line":"                    _(\u0027Backend `%(driver)s` is not a valid memcached \u0027"},{"line_number":109,"context_line":"                      \u0027backend. Valid drivers: %(driver_list)s\u0027) %"},{"line_number":110,"context_line":"                    {\u0027driver\u0027: backend,"},{"line_number":111,"context_line":"                     \u0027driver_list\u0027: \u0027,\u0027.join(VALID_DOGPILE_BACKENDS.keys())})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_42e87c10","line":108,"updated":"2015-05-01 18:40:57.000000000","message":"s/drivers/backends\n\ns/driver_list/backend_list","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c298f4b0f528aa8548482130c8767f7dd73ebb73","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            if backend not in VALID_DOGPILE_BACKENDS:"},{"line_number":107,"context_line":"                raise ValueError("},{"line_number":108,"context_line":"                    _(\u0027Backend `%(driver)s` is not a valid memcached \u0027"},{"line_number":109,"context_line":"                      \u0027backend. Valid drivers: %(driver_list)s\u0027) %"},{"line_number":110,"context_line":"                    {\u0027driver\u0027: backend,"},{"line_number":111,"context_line":"                     \u0027driver_list\u0027: \u0027,\u0027.join(VALID_DOGPILE_BACKENDS.keys())})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_0e703c0a","line":108,"in_reply_to":"3acd31a7_42e87c10","updated":"2015-05-05 02:27:54.000000000","message":"Done","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"0c5e7e2aa90dc7e50654d62c9facd3ab8a3ffb9f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            if backend not in VALID_DOGPILE_BACKENDS:"},{"line_number":107,"context_line":"                raise ValueError("},{"line_number":108,"context_line":"                    _(\u0027Backend `%(driver)s` is not a valid memcached \u0027"},{"line_number":109,"context_line":"                      \u0027backend. Valid drivers: %(driver_list)s\u0027) %"},{"line_number":110,"context_line":"                    {\u0027driver\u0027: backend,"},{"line_number":111,"context_line":"                     \u0027driver_list\u0027: \u0027,\u0027.join(VALID_DOGPILE_BACKENDS.keys())})"},{"line_number":112,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_22e34035","line":109,"updated":"2015-05-01 18:40:57.000000000","message":"s/driver/backend\n\ns/driver_list/backend-list","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"c298f4b0f528aa8548482130c8767f7dd73ebb73","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            if backend not in VALID_DOGPILE_BACKENDS:"},{"line_number":107,"context_line":"                raise ValueError("},{"line_number":108,"context_line":"                    _(\u0027Backend `%(driver)s` is not a valid memcached \u0027"},{"line_number":109,"context_line":"                      \u0027backend. Valid drivers: %(driver_list)s\u0027) %"},{"line_number":110,"context_line":"                    {\u0027driver\u0027: backend,"},{"line_number":111,"context_line":"                     \u0027driver_list\u0027: \u0027,\u0027.join(VALID_DOGPILE_BACKENDS.keys())})"},{"line_number":112,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_ce75a4fa","line":109,"in_reply_to":"3acd31a7_22e34035","updated":"2015-05-05 02:27:54.000000000","message":"Done","commit_id":"31f74386b3c33e33a120fc9a6eb54cbe26a9c88f"}]}