)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"39824ca38d3e94ec0a04a6908477819ae7f5d14f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change updates the signed_saml2_assertion.xml fixture with"},{"line_number":10,"context_line":"the current attributes/values used by keystone: openstack_user,"},{"line_number":11,"context_line":"openstack_roles, openstack_project."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia296fe26434f43054e32a98ad4af25148aac5da2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_d33a76e7","line":11,"updated":"2015-04-10 20:08:10.000000000","message":"doesn\u0027t that patch just correct the name of openstack_project ?","commit_id":"028ffa39ed322da9c586a4fdb96883e9447afba0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"121b2a7b8bb4d738846d4908a5fa5e4e37678c5f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change updates the signed_saml2_assertion.xml fixture with"},{"line_number":10,"context_line":"the current attributes/values used by keystone: openstack_user,"},{"line_number":11,"context_line":"openstack_roles, openstack_project."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia296fe26434f43054e32a98ad4af25148aac5da2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_e58125fd","line":11,"in_reply_to":"7aaa499b_d33a76e7","updated":"2015-04-10 20:23:12.000000000","message":"it fixes all 3 in the fixture file, but in the docstring removes only the \"s\" from openstac_projects.","commit_id":"028ffa39ed322da9c586a4fdb96883e9447afba0"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"9f2a62230095463da5b0b0b2df274a9a757d894a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change updates the signed_saml2_assertion.xml fixture with"},{"line_number":10,"context_line":"the current attributes/values used by keystone: openstack_user,"},{"line_number":11,"context_line":"openstack_roles, openstack_project."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia296fe26434f43054e32a98ad4af25148aac5da2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_e5afe57b","line":11,"in_reply_to":"7aaa499b_e58125fd","updated":"2015-04-10 20:25:19.000000000","message":"Ahh,sorry, I get it now...","commit_id":"028ffa39ed322da9c586a4fdb96883e9447afba0"}],"keystone/contrib/federation/idp.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"aeb535ca842f05c3ebd669191b39242da556da67","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def _create_attribute_statement(self, user, roles, project):"},{"line_number":157,"context_line":"        \"\"\"Create an object that represents a SAML AttributeStatement."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        \u003cns0:AttributeStatement"},{"line_number":160,"context_line":"            \u003cns0:Attribute Name\u003d\"openstack_user\"\u003e"},{"line_number":161,"context_line":"                \u003cns0:AttributeValue"},{"line_number":162,"context_line":"                  xsi:type\u003d\"xs:string\"\u003etest_user\u003c/ns0:AttributeValue\u003e"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_6c316e0b","line":159,"updated":"2015-04-13 03:59:46.000000000","message":"oops missed this one on the last review, missing  \"\u003e\"","commit_id":"0752aa0d7edc5b86d41391380ee9fd8f46104873"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"13045182c63ef43cae8ec9951fa061dfaaf67979","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def _create_attribute_statement(self, user, roles, project):"},{"line_number":157,"context_line":"        \"\"\"Create an object that represents a SAML AttributeStatement."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        \u003cns0:AttributeStatement"},{"line_number":160,"context_line":"            \u003cns0:Attribute Name\u003d\"openstack_user\"\u003e"},{"line_number":161,"context_line":"                \u003cns0:AttributeValue"},{"line_number":162,"context_line":"                  xsi:type\u003d\"xs:string\"\u003etest_user\u003c/ns0:AttributeValue\u003e"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_fcfc0540","line":159,"in_reply_to":"7aaa499b_6c316e0b","updated":"2015-04-13 11:15:33.000000000","message":"Done","commit_id":"0752aa0d7edc5b86d41391380ee9fd8f46104873"}],"keystone/tests/unit/saml2/signed_saml2_assertion.xml":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"cd59a89a7e52c398590cf2a36f81d69e30a843c4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  \u003c/ns0:AuthnStatement\u003e"},{"line_number":51,"context_line":"  \u003cns0:AttributeStatement"},{"line_number":52,"context_line":"      xmlns:ns0\u003d\"urn:oasis:names:tc:SAML:2.0:assertion\""},{"line_number":53,"context_line":"      xmlns:xsi\u003d\"http://www.w3.org/2001/XMLSchema-instance\"\u003e"},{"line_number":54,"context_line":"      \u003cns0:Attribute Name\u003d\"openstack_user\"\u003e"},{"line_number":55,"context_line":"          \u003cns0:AttributeValue"},{"line_number":56,"context_line":"              xsi:type\u003d\"xs:string\"\u003etest_user\u003c/ns0:AttributeValue\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"7aaa499b_3e315eed","line":53,"updated":"2015-04-10 22:58:55.000000000","message":"we don\u0027t really set this two attributes when we construct the \u003cAttributeStatement\u003e here: https://github.com/openstack/keystone/blob/master/keystone/contrib/federation/idp.py#L204\n\nMaybe the sample in https://github.com/openstack/keystone/blob/master/keystone/contrib/federation/idp.py#L160-L161  needs to be cleaned up instead.","commit_id":"028ffa39ed322da9c586a4fdb96883e9447afba0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"47e8dd673c4ef0accf75a4beb91f599cf36ba11a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  \u003c/ns0:AuthnStatement\u003e"},{"line_number":51,"context_line":"  \u003cns0:AttributeStatement"},{"line_number":52,"context_line":"      xmlns:ns0\u003d\"urn:oasis:names:tc:SAML:2.0:assertion\""},{"line_number":53,"context_line":"      xmlns:xsi\u003d\"http://www.w3.org/2001/XMLSchema-instance\"\u003e"},{"line_number":54,"context_line":"      \u003cns0:Attribute Name\u003d\"openstack_user\"\u003e"},{"line_number":55,"context_line":"          \u003cns0:AttributeValue"},{"line_number":56,"context_line":"              xsi:type\u003d\"xs:string\"\u003etest_user\u003c/ns0:AttributeValue\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"7aaa499b_dee6fae7","line":53,"in_reply_to":"7aaa499b_3e315eed","updated":"2015-04-10 23:51:56.000000000","message":"cleaned both","commit_id":"028ffa39ed322da9c586a4fdb96883e9447afba0"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"3b26748bd1a3f86b3edc5d53e9134e4752a94d8e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \u003c/ns0:AuthnContext\u003e"},{"line_number":50,"context_line":"  \u003c/ns0:AuthnStatement\u003e"},{"line_number":51,"context_line":"  \u003cns0:AttributeStatement\u003e"},{"line_number":52,"context_line":"    \u003cns0:Attribute FriendlyName\u003d\"openstack_user\" Name\u003d\"user\" NameFormat\u003d\"urn:oasis:names:tc:SAML:2.0:attrname-format:uri\"\u003e"},{"line_number":53,"context_line":"      \u003cns0:AttributeValue xsi:type\u003d\"xs:string\"\u003etest_user\u003c/ns0:AttributeValue\u003e"},{"line_number":54,"context_line":"    \u003c/ns0:Attribute\u003e"},{"line_number":55,"context_line":"    \u003cns0:Attribute FriendlyName\u003d\"openstack_roles\" Name\u003d\"roles\" NameFormat\u003d\"urn:oasis:names:tc:SAML:2.0:attrname-format:uri\"\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"7aaa499b_d54b702a","line":52,"updated":"2015-04-11 23:11:31.000000000","message":"Should be Name\u003d\"openstack_user\"\n\nYou already have it right on Patch Set 2, why reverted it back?","commit_id":"ae4c7bc34f9a8d0dcae0e5222eee3b5625ec4399"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"156d3f173bc04ea759e278a1973f79cef6fd7091","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \u003c/ns0:AuthnContext\u003e"},{"line_number":50,"context_line":"  \u003c/ns0:AuthnStatement\u003e"},{"line_number":51,"context_line":"  \u003cns0:AttributeStatement\u003e"},{"line_number":52,"context_line":"    \u003cns0:Attribute FriendlyName\u003d\"openstack_user\" Name\u003d\"user\" NameFormat\u003d\"urn:oasis:names:tc:SAML:2.0:attrname-format:uri\"\u003e"},{"line_number":53,"context_line":"      \u003cns0:AttributeValue xsi:type\u003d\"xs:string\"\u003etest_user\u003c/ns0:AttributeValue\u003e"},{"line_number":54,"context_line":"    \u003c/ns0:Attribute\u003e"},{"line_number":55,"context_line":"    \u003cns0:Attribute FriendlyName\u003d\"openstack_roles\" Name\u003d\"roles\" NameFormat\u003d\"urn:oasis:names:tc:SAML:2.0:attrname-format:uri\"\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"7aaa499b_21049213","line":52,"in_reply_to":"7aaa499b_40dd5c13","updated":"2015-04-12 14:04:47.000000000","message":"patch set 2 didn\u0027t pass the tests because it wasn\u0027t a valid SAML. Changing FriendlyName instead of Name was an error made after reverting to the original file, will fix that.","commit_id":"ae4c7bc34f9a8d0dcae0e5222eee3b5625ec4399"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f4b30a743d52b8dd2dfa931bb2c38c4ba9e32303","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \u003c/ns0:AuthnContext\u003e"},{"line_number":50,"context_line":"  \u003c/ns0:AuthnStatement\u003e"},{"line_number":51,"context_line":"  \u003cns0:AttributeStatement\u003e"},{"line_number":52,"context_line":"    \u003cns0:Attribute FriendlyName\u003d\"openstack_user\" Name\u003d\"user\" NameFormat\u003d\"urn:oasis:names:tc:SAML:2.0:attrname-format:uri\"\u003e"},{"line_number":53,"context_line":"      \u003cns0:AttributeValue xsi:type\u003d\"xs:string\"\u003etest_user\u003c/ns0:AttributeValue\u003e"},{"line_number":54,"context_line":"    \u003c/ns0:Attribute\u003e"},{"line_number":55,"context_line":"    \u003cns0:Attribute FriendlyName\u003d\"openstack_roles\" Name\u003d\"roles\" NameFormat\u003d\"urn:oasis:names:tc:SAML:2.0:attrname-format:uri\"\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"7aaa499b_40dd5c13","line":52,"in_reply_to":"7aaa499b_d54b702a","updated":"2015-04-12 06:27:37.000000000","message":"++ oops. missed that revert...","commit_id":"ae4c7bc34f9a8d0dcae0e5222eee3b5625ec4399"}]}