)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8fd33cf6cec26883df2bbd78b2c359dc6cbf7814","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix mysql_engine and FK in project_endpoint_group table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Table project_endpoint_group was created with foreign key and this was"},{"line_number":10,"context_line":"mentioned in model description as well. But table was created without"},{"line_number":11,"context_line":"mysql_engine argument, so database creates table with default engine."},{"line_number":12,"context_line":"In MySQL 5.5 default engine is MyISAM, so table creates without any"},{"line_number":13,"context_line":"foreign keys."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_34a1ce46","line":10,"updated":"2015-06-10 15:57:39.000000000","message":"Is there a link to where this is mentioned? Suggest removing the \u0027and this was mentioned in model description as well\u0027 part if we don\u0027t have a link to extra context.","commit_id":"77bc002cb9e177f09b20a5d37c3d44422d9bf6b3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8fd33cf6cec26883df2bbd78b2c359dc6cbf7814","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Table project_endpoint_group was created with foreign key and this was"},{"line_number":10,"context_line":"mentioned in model description as well. But table was created without"},{"line_number":11,"context_line":"mysql_engine argument, so database creates table with default engine."},{"line_number":12,"context_line":"In MySQL 5.5 default engine is MyISAM, so table creates without any"},{"line_number":13,"context_line":"foreign keys."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Added migration to fix mysql_engine and add foreign key."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_14b4927d","line":12,"updated":"2015-06-10 15:57:39.000000000","message":"What do we want it to be?","commit_id":"77bc002cb9e177f09b20a5d37c3d44422d9bf6b3"}],"keystone/contrib/endpoint_filter/migrate_repo/versions/003_fix_endpoint_groups_mysql_engine.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8fd33cf6cec26883df2bbd78b2c359dc6cbf7814","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    project_endpoint_group \u003d sql.Table(\u0027project_endpoint_group\u0027,"},{"line_number":29,"context_line":"                                       meta, autoload\u003dTrue)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    if project_endpoint_group.dialect_options[\u0027mysql\u0027][\u0027engine\u0027] !\u003d \u0027InnoDB\u0027:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        migrate_engine.execute(\"ALTER TABLE endpoint_group Engine\u003dInnoDB\")"},{"line_number":34,"context_line":"        migrate_engine.execute("}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_d7339cf4","line":31,"updated":"2015-06-10 15:57:39.000000000","message":"Is there a way to test this? Can we create the project_endpoint_group table with something other than the InnoDB engine and call an assertion after upgrade to know that it was changed?","commit_id":"77bc002cb9e177f09b20a5d37c3d44422d9bf6b3"}]}
