)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"90cc64eb7aedb499621dae9a56012f2804c01318","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Stanek \u003cdstanek@dstanek.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-16 22:52:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds proper isolation the templated catalog tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously the templated catalog implementation wasn\u0027t really being"},{"line_number":10,"context_line":"tested properly. The read/write tests, while passing, tested the KVS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ab451fb_f4130e0c","line":7,"updated":"2015-04-17 08:37:42.000000000","message":"nit: to the?","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e3fcc73285e0c253e2922c8ee509e7351adeaea7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Stanek \u003cdstanek@dstanek.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-16 22:52:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds proper isolation the templated catalog tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously the templated catalog implementation wasn\u0027t really being"},{"line_number":10,"context_line":"tested properly. The read/write tests, while passing, tested the KVS"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dac4157f_bfc1e482","line":7,"in_reply_to":"3ab451fb_f4130e0c","updated":"2015-04-20 13:14:00.000000000","message":"That\u0027s what I had, but it was too long. I meant to take out the \u0027the\u0027 and leave the \u0027to\u0027, but looks like I failed.","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"90cc64eb7aedb499621dae9a56012f2804c01318","unresolved":false,"context_lines":[{"line_number":10,"context_line":"tested properly. The read/write tests, while passing, tested the KVS"},{"line_number":11,"context_line":"implementation that will soon be removed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A bad side effect of use KVS as a base is that the read operations"},{"line_number":14,"context_line":"don\u0027t use the data from the template. They use only the data that"},{"line_number":15,"context_line":"was modified by crud. This is why we didn\u0027t realize that the read"},{"line_number":16,"context_line":"operations were incorrect."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ab451fb_343176a3","line":13,"updated":"2015-04-17 08:37:42.000000000","message":"nit: s/use/using/","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e3fcc73285e0c253e2922c8ee509e7351adeaea7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"tested properly. The read/write tests, while passing, tested the KVS"},{"line_number":11,"context_line":"implementation that will soon be removed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A bad side effect of use KVS as a base is that the read operations"},{"line_number":14,"context_line":"don\u0027t use the data from the template. They use only the data that"},{"line_number":15,"context_line":"was modified by crud. This is why we didn\u0027t realize that the read"},{"line_number":16,"context_line":"operations were incorrect."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dac4157f_5f3768b0","line":13,"in_reply_to":"3ab451fb_343176a3","updated":"2015-04-20 13:14:00.000000000","message":"Done","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"}],"keystone/tests/unit/test_backend_templated.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"8327d40f5fc2d3c19dc6db77676a932cf7573ff0","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def test_service_filtering(self):"},{"line_number":151,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support filtering\")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# overridden from test_backend.TestCatalog"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_region_crud(self):"},{"line_number":156,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_b648d15c","line":153,"updated":"2015-04-17 19:43:08.000000000","message":"test_backend.CatalogTests","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e3fcc73285e0c253e2922c8ee509e7351adeaea7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def test_service_filtering(self):"},{"line_number":151,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support filtering\")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# overridden from test_backend.TestCatalog"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_region_crud(self):"},{"line_number":156,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_ff451c17","line":153,"in_reply_to":"3ab451fb_b648d15c","updated":"2015-04-20 13:14:00.000000000","message":"Done","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"8327d40f5fc2d3c19dc6db77676a932cf7573ff0","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# overridden from test_backend.TestCatalog"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_region_crud(self):"},{"line_number":156,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @tests.skip_if_cache_disabled(\u0027catalog\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_16730582","line":155,"updated":"2015-04-17 19:43:08.000000000","message":"Actually all of the method that have been skipped above is overridden from the test_backend.CatalogTests.  \n\nShould we just move them down here too for clarity?","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e3fcc73285e0c253e2922c8ee509e7351adeaea7","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# overridden from test_backend.TestCatalog"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def test_region_crud(self):"},{"line_number":156,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @tests.skip_if_cache_disabled(\u0027catalog\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_7f522cdf","line":155,"in_reply_to":"3ab451fb_16730582","updated":"2015-04-20 13:14:00.000000000","message":"This comment was meant of all of the methods below. I clarified in newest patch.","commit_id":"836012209a28f47970232b1764c034f03f3cef3d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b5f33ad8fe8dc02691c386970e21936ba75f963a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support filtering\")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":154,"context_line":"    # from test_backend.CatalogTests"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_region_crud(self):"},{"line_number":157,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_edcb2471","line":154,"updated":"2015-04-20 18:44:05.000000000","message":"The following method are also overridden from:\n* test_backend.CatalogTests:\n* test_list_regions_filtered_by_parent_region_id()\n* test_service_filtering()\n* test_get_v3_catalog_endpoint_disabled()\n* test_get_catalog_endpoint_disabled\n\nShould those method  be moved down there too?","commit_id":"78cbd7dc7ffaa84eac11d1678ea89c52736d44e1"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"197706bed570f69d2d24115d0fb5e35631336e53","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":154,"context_line":"    # from test_backend.CatalogTests"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_region_crud(self):"},{"line_number":157,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @tests.skip_if_cache_disabled(\u0027catalog\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_4624300c","line":156,"updated":"2015-04-23 16:33:37.000000000","message":"...so the recent trend has been to rather than just skipTest, to actually expect the error a caller would get if they DID try and do the operation (e.g. some write call)....i.e. in this case \n\nself.assertRaises(NotImplemented.....)\n\nis there a reason we don\u0027t do that for all this....","commit_id":"78cbd7dc7ffaa84eac11d1678ea89c52736d44e1"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c3d3626c3dacc378984e89c569a73138a3675bb6","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":154,"context_line":"    # from test_backend.CatalogTests"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_region_crud(self):"},{"line_number":157,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @tests.skip_if_cache_disabled(\u0027catalog\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_8c88c072","line":156,"in_reply_to":"7a016987_537f0b17","updated":"2015-05-28 21:39:16.000000000","message":"Fixed in next push.","commit_id":"78cbd7dc7ffaa84eac11d1678ea89c52736d44e1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"52fe74e5171c6061e2fea1ed50f4303ac3068530","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":154,"context_line":"    # from test_backend.CatalogTests"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_region_crud(self):"},{"line_number":157,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @tests.skip_if_cache_disabled(\u0027catalog\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_537f0b17","line":156,"in_reply_to":"7a016987_807ac786","updated":"2015-05-28 20:15:17.000000000","message":"if the server is just doing weird stuff then I\u0027m ok with a skip. The comment needs to be accurate though -- in this case it seems like we\u0027re skipping because the server would raise not implemented, not that it exhibits weird behavior that we don\u0027t really care about.","commit_id":"78cbd7dc7ffaa84eac11d1678ea89c52736d44e1"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"72bffe8de69bbadfbc5e0e3f6a4ac5d695ddbf33","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":154,"context_line":"    # from test_backend.CatalogTests"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_region_crud(self):"},{"line_number":157,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @tests.skip_if_cache_disabled(\u0027catalog\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_807ac786","line":156,"in_reply_to":"7ad32947_b377e4d3","updated":"2015-05-28 19:27:41.000000000","message":"So this is an interesting question. Right now the templated catalog will successfully do most of these actions, but the result is never in the catalog. But the call never fails. Should I actively make the calls fail?","commit_id":"78cbd7dc7ffaa84eac11d1678ea89c52736d44e1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1e867cc0eca72911809e4b5b2162ac5264f7ae21","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":154,"context_line":"    # from test_backend.CatalogTests"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_region_crud(self):"},{"line_number":157,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support write operations\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @tests.skip_if_cache_disabled(\u0027catalog\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_b377e4d3","line":156,"in_reply_to":"bab921fb_4624300c","updated":"2015-04-27 22:54:27.000000000","message":"I agree. If we know it\u0027s going to raise NotImplemented then test that happens.","commit_id":"78cbd7dc7ffaa84eac11d1678ea89c52736d44e1"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8957ba3cca03bba23066d31d4027d7109ffdf43f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from six.moves import zip"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from keystone.catalog import core"},{"line_number":21,"context_line":"from keystone.tests import unit as tests"},{"line_number":22,"context_line":"from keystone.tests.unit import default_fixtures"},{"line_number":23,"context_line":"from keystone.tests.unit.ksfixtures import database"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_a75c5d4b","line":20,"updated":"2015-06-11 01:35:42.000000000","message":"use\n\n from keystone import catalog\n\nthe pattern is that the __init__.py imports core.*","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8957ba3cca03bba23066d31d4027d7109ffdf43f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        super(TestTemplatedCatalog, self).config_overrides()"},{"line_number":60,"context_line":"        self.config_fixture.config("},{"line_number":61,"context_line":"            group\u003d\u0027catalog\u0027,"},{"line_number":62,"context_line":"            driver\u003d\u0027keystone.catalog.backends.templated.Catalog\u0027,"},{"line_number":63,"context_line":"            template_file\u003dtests.dirs.tests(\u0027default_catalog.templates\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_catalog(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_c728799c","line":62,"updated":"2015-06-11 01:35:42.000000000","message":"this should be using stevedore now, so driver should be just \u0027templated\u0027","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9353ef3ca0747a9b5139e1b243972e9ddd7813d2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        super(TestTemplatedCatalog, self).config_overrides()"},{"line_number":60,"context_line":"        self.config_fixture.config("},{"line_number":61,"context_line":"            group\u003d\u0027catalog\u0027,"},{"line_number":62,"context_line":"            driver\u003d\u0027keystone.catalog.backends.templated.Catalog\u0027,"},{"line_number":63,"context_line":"            template_file\u003dtests.dirs.tests(\u0027default_catalog.templates\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_catalog(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_3261ca39","line":62,"in_reply_to":"3afb71cf_c728799c","updated":"2015-07-08 20:30:31.000000000","message":"Done","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f3a2e0b61d6c85361187be964f20807feb3829cc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.config_fixture.config("},{"line_number":61,"context_line":"            group\u003d\u0027catalog\u0027,"},{"line_number":62,"context_line":"            driver\u003d\u0027keystone.catalog.backends.templated.Catalog\u0027,"},{"line_number":63,"context_line":"            template_file\u003dtests.dirs.tests(\u0027default_catalog.templates\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_catalog(self):"},{"line_number":66,"context_line":"        catalog_ref \u003d self.catalog_api.get_catalog(\u0027foo\u0027, \u0027bar\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_5e8602dc","line":63,"updated":"2015-06-17 06:54:19.000000000","message":"Those config is redundant, see: https://github.com/openstack/keystone/blob/master/keystone/tests/unit/core.py#L288","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9353ef3ca0747a9b5139e1b243972e9ddd7813d2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.config_fixture.config("},{"line_number":61,"context_line":"            group\u003d\u0027catalog\u0027,"},{"line_number":62,"context_line":"            driver\u003d\u0027keystone.catalog.backends.templated.Catalog\u0027,"},{"line_number":63,"context_line":"            template_file\u003dtests.dirs.tests(\u0027default_catalog.templates\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_get_catalog(self):"},{"line_number":66,"context_line":"        catalog_ref \u003d self.catalog_api.get_catalog(\u0027foo\u0027, \u0027bar\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_32c8ea21","line":63,"in_reply_to":"fa32b979_5e8602dc","updated":"2015-07-08 20:30:31.000000000","message":"They won\u0027t be forever and this particular test case needs to ensure it\u0027s using the correct driver. If the default changes these test may (and probably will) still pass.","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f3a2e0b61d6c85361187be964f20807feb3829cc","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support filtering\")"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":159,"context_line":"    # from test_backend.CatalogTests"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_region_crud(self):"},{"line_number":162,"context_line":"        self.skipTest(BROKEN_WRITE_FUNCTIONALITY_MSG)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_3e58de89","line":159,"updated":"2015-06-17 06:54:19.000000000","message":"override or overridden from?","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9353ef3ca0747a9b5139e1b243972e9ddd7813d2","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.skipTest(\"Templated backend doesn\u0027t support filtering\")"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":159,"context_line":"    # from test_backend.CatalogTests"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_region_crud(self):"},{"line_number":162,"context_line":"        self.skipTest(BROKEN_WRITE_FUNCTIONALITY_MSG)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_d2d97ef4","line":159,"in_reply_to":"fa32b979_3e58de89","updated":"2015-07-08 20:30:31.000000000","message":"test_backend.CatalogTests","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f3a2e0b61d6c85361187be964f20807feb3829cc","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":159,"context_line":"    # from test_backend.CatalogTests"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_region_crud(self):"},{"line_number":162,"context_line":"        self.skipTest(BROKEN_WRITE_FUNCTIONALITY_MSG)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_1e54fa50","line":160,"updated":"2015-06-17 06:54:19.000000000","message":"The blank line here is intentional?","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9353ef3ca0747a9b5139e1b243972e9ddd7813d2","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    # NOTE(dstanek): the following methods have been overridden"},{"line_number":159,"context_line":"    # from test_backend.CatalogTests"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_region_crud(self):"},{"line_number":162,"context_line":"        self.skipTest(BROKEN_WRITE_FUNCTIONALITY_MSG)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_52cd6e2f","line":160,"in_reply_to":"fa32b979_1e54fa50","updated":"2015-07-08 20:30:31.000000000","message":"yes","commit_id":"cd7212c38b1d68dd29586902571f13d73747f345"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"76700b4f5fa88bb1d0e21565be5342c4a3f42ee0","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"BROKEN_WRITE_FUNCTIONALITY_MSG \u003d (\"Templated backend doesn\u0027t correctly \""},{"line_number":28,"context_line":"                                  \"implement write operations\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestTemplatedCatalog(tests.TestCase, test_backend.CatalogTests):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_b717faa1","line":28,"updated":"2015-07-09 02:12:47.000000000","message":"Is the word \"correctly\" needed? Templated backend really don\u0027t support write operations anyway.","commit_id":"bd1937d16c299550bcc03845e185b2beff53b676"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c0618deb31334d27b060468b63ba8d2cd9c802ba","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"BROKEN_WRITE_FUNCTIONALITY_MSG \u003d (\"Templated backend doesn\u0027t correctly \""},{"line_number":28,"context_line":"                                  \"implement write operations\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestTemplatedCatalog(tests.TestCase, test_backend.CatalogTests):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_a8ec0293","line":28,"in_reply_to":"3a50d1a3_a4444db7","updated":"2015-07-31 03:43:40.000000000","message":"ah right, because the class extends from the kvs catalog so it inherited the write operation but it won\u0027t the data being returned to the user.","commit_id":"bd1937d16c299550bcc03845e185b2beff53b676"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f5c347df79514897115b4c66e871348488e16da3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"BROKEN_WRITE_FUNCTIONALITY_MSG \u003d (\"Templated backend doesn\u0027t correctly \""},{"line_number":28,"context_line":"                                  \"implement write operations\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestTemplatedCatalog(tests.TestCase, test_backend.CatalogTests):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_c8662e29","line":28,"in_reply_to":"3a50d1a3_a8ec0293","updated":"2015-07-31 03:49:45.000000000","message":"I think one of the reviews a little later in this chain actually break that up.","commit_id":"bd1937d16c299550bcc03845e185b2beff53b676"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8756342404bcc7e547eeaa985ea52202faa72455","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"BROKEN_WRITE_FUNCTIONALITY_MSG \u003d (\"Templated backend doesn\u0027t correctly \""},{"line_number":28,"context_line":"                                  \"implement write operations\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestTemplatedCatalog(tests.TestCase, test_backend.CatalogTests):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_a4444db7","line":28,"in_reply_to":"ba3cc151_b717faa1","updated":"2015-07-30 12:48:01.000000000","message":"Depends on how you look at it. Templated actually lets you write, but it has no real effect.","commit_id":"bd1937d16c299550bcc03845e185b2beff53b676"}]}