)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"333cd6235f9dcfd76bfa217d0beba9c625596a90","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix mysql_engine and FK in *_token tables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migration 002 adds foreign keys to tables request_token and"},{"line_number":10,"context_line":"access_token. These FKs were mentioned in model description as well."},{"line_number":11,"context_line":"But these tables was created without mysql_engine argument, so"},{"line_number":12,"context_line":"database creates table with default engine."},{"line_number":13,"context_line":"In MySQL 5.5 default engine is MyISAM, so foreign keys can not be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_57f20c07","line":10,"updated":"2015-06-10 16:00:05.000000000","message":"Same comments apply here: \n\nhttps://review.openstack.org/#/c/174388/1//COMMIT_MSG","commit_id":"ffd8916aa0a640ed5910fd298de64d0fc5d00bc6"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e9b5fc85c97a44fd4f746ef2ecbf90b41081ba79","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix mysql_engine and FK in *_token tables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migration 002 adds foreign keys to tables request_token and"},{"line_number":10,"context_line":"access_token. These FKs were mentioned in model description as well."},{"line_number":11,"context_line":"But these tables was created without mysql_engine argument, so"},{"line_number":12,"context_line":"database creates table with default engine."},{"line_number":13,"context_line":"In MySQL 5.5 default engine is MyISAM, so foreign keys can not be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1af86dd1_1299fb6e","line":10,"in_reply_to":"3afb71cf_57f20c07","updated":"2015-06-12 13:54:21.000000000","message":"Done","commit_id":"ffd8916aa0a640ed5910fd298de64d0fc5d00bc6"}],"keystone/contrib/oauth1/migrate_repo/versions/006_fix_token_tables_engine.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"333cd6235f9dcfd76bfa217d0beba9c625596a90","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    access_token_table \u003d sql.Table(\u0027access_token\u0027, meta, autoload\u003dTrue)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    if consumer_table.dialect_options[\u0027mysql\u0027][\u0027engine\u0027] !\u003d \u0027InnoDB\u0027:"},{"line_number":29,"context_line":"        migrate_engine.execute(\"ALTER TABLE consumer Engine\u003dInnoDB\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    if request_token_table.dialect_options[\u0027mysql\u0027][\u0027engine\u0027] !\u003d \u0027InnoDB\u0027:"},{"line_number":32,"context_line":"        migrate_engine.execute(\"ALTER TABLE request_token Engine\u003dInnoDB\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_377e706a","line":29,"updated":"2015-06-10 16:00:05.000000000","message":"I think the same comment from a similar review should apply here: \n\nhttps://review.openstack.org/#/c/174388/1/keystone/contrib/endpoint_filter/migrate_repo/versions/003_fix_endpoint_groups_mysql_engine.py\n\nWe should try and find a way to test this.","commit_id":"ffd8916aa0a640ed5910fd298de64d0fc5d00bc6"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e9b5fc85c97a44fd4f746ef2ecbf90b41081ba79","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    access_token_table \u003d sql.Table(\u0027access_token\u0027, meta, autoload\u003dTrue)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    if consumer_table.dialect_options[\u0027mysql\u0027][\u0027engine\u0027] !\u003d \u0027InnoDB\u0027:"},{"line_number":29,"context_line":"        migrate_engine.execute(\"ALTER TABLE consumer Engine\u003dInnoDB\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    if request_token_table.dialect_options[\u0027mysql\u0027][\u0027engine\u0027] !\u003d \u0027InnoDB\u0027:"},{"line_number":32,"context_line":"        migrate_engine.execute(\"ALTER TABLE request_token Engine\u003dInnoDB\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_926ccb9d","line":29,"in_reply_to":"3afb71cf_377e706a","updated":"2015-06-12 13:54:21.000000000","message":"1) - It\u0027s not a big deal  to add a `test_all_tables_innodb()` check :)\n\n2) - This also implicitly tested by model-migration sync, because if the table will have not InnoDB engine, test will fail, because foreign keys will not created.","commit_id":"ffd8916aa0a640ed5910fd298de64d0fc5d00bc6"}]}