)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f445b7930e6e6a85c11410cf7880672e00a2c5f5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- rename to make the name reveal the test\u0027s intentions"},{"line_number":10,"context_line":"- simplify the implementation"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I52ee09f15130e15e25dd6e64bfdee1f480dbc6ed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3acd31a7_c6097933","line":11,"updated":"2015-04-30 03:49:28.000000000","message":"add link to bp here","commit_id":"6480ade9604d7d41b3886f3d775cf3bfcdb8371a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ab35c4aa192c949051c2d0c69e1fa8ed4fb7e31f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- rename to make the name reveal the test\u0027s intentions"},{"line_number":10,"context_line":"- simplify the implementation"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I52ee09f15130e15e25dd6e64bfdee1f480dbc6ed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_0b2ed642","line":11,"in_reply_to":"3acd31a7_81df7d0c","updated":"2015-05-20 18:54:57.000000000","message":"++ This is just in the same stream of changes. Not really a direct fix for Python 3. This refactoring sets up a fix that will be made in a later commit.","commit_id":"6480ade9604d7d41b3886f3d775cf3bfcdb8371a"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f91addde0d195fe0b5311e3cc16af535d0682511","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- rename to make the name reveal the test\u0027s intentions"},{"line_number":10,"context_line":"- simplify the implementation"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I52ee09f15130e15e25dd6e64bfdee1f480dbc6ed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3acd31a7_81df7d0c","line":11,"in_reply_to":"3acd31a7_c6097933","updated":"2015-05-05 03:26:18.000000000","message":"This may not tie directly with that bp, looks more likely the changing of the topic.","commit_id":"6480ade9604d7d41b3886f3d775cf3bfcdb8371a"}],"keystone/tests/unit/tests/test_core.py":[{"author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"change_message_id":"b179fbb1e748fade794e1fbfe2ca3505a95cfb6c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            lambda: warnings.warn(\u0027test sa warning error\u0027, exc.SAWarning),"},{"line_number":48,"context_line":"            matchers.raises(exc.SAWarning))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_deprecation_warnings_are_raised_as_exceptions_in_tests(self):"},{"line_number":51,"context_line":"        self.assertThat("},{"line_number":52,"context_line":"            lambda: warnings.warn(\u0027this is deprecated\u0027, DeprecationWarning),"},{"line_number":53,"context_line":"            matchers.raises(DeprecationWarning))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_7450d65e","line":50,"updated":"2015-05-01 17:48:45.000000000","message":"As said in the parent patch, this test isn\u0027t adding any value.\n\nThe test_sa_warning above tests the same, doesn\u0027t it ?\n\nWe could either remove this test or put it within the above one and do\n\n    for exception in (exc.SAWarning, DeprecationWarning)","commit_id":"6480ade9604d7d41b3886f3d775cf3bfcdb8371a"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f91addde0d195fe0b5311e3cc16af535d0682511","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            lambda: warnings.warn(\u0027test sa warning error\u0027, exc.SAWarning),"},{"line_number":48,"context_line":"            matchers.raises(exc.SAWarning))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_deprecation_warnings_are_raised_as_exceptions_in_tests(self):"},{"line_number":51,"context_line":"        self.assertThat("},{"line_number":52,"context_line":"            lambda: warnings.warn(\u0027this is deprecated\u0027, DeprecationWarning),"},{"line_number":53,"context_line":"            matchers.raises(DeprecationWarning))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_c1e335a3","line":50,"in_reply_to":"3acd31a7_7450d65e","updated":"2015-05-05 03:26:18.000000000","message":"++\nfocus on different warnings, but both is instance of Warning.","commit_id":"6480ade9604d7d41b3886f3d775cf3bfcdb8371a"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ab35c4aa192c949051c2d0c69e1fa8ed4fb7e31f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            lambda: warnings.warn(\u0027test sa warning error\u0027, exc.SAWarning),"},{"line_number":48,"context_line":"            matchers.raises(exc.SAWarning))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_deprecation_warnings_are_raised_as_exceptions_in_tests(self):"},{"line_number":51,"context_line":"        self.assertThat("},{"line_number":52,"context_line":"            lambda: warnings.warn(\u0027this is deprecated\u0027, DeprecationWarning),"},{"line_number":53,"context_line":"            matchers.raises(DeprecationWarning))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_cb231e57","line":50,"in_reply_to":"3acd31a7_c1e335a3","updated":"2015-05-20 18:54:57.000000000","message":"I really like them being explicit on what is expected.","commit_id":"6480ade9604d7d41b3886f3d775cf3bfcdb8371a"}]}
