)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"dc87ab391cb7af57f7baff90586684407a311c92","unresolved":false,"context_lines":[{"line_number":15,"context_line":"a short name that can be used rather than the qualified class."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"bp stevedore"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2484af32e9eb3703869cf441e4f9851b54b0db2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a016987_29037378","line":18,"updated":"2015-05-26 12:01:30.000000000","message":"it is better to add a doc impact hint here.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"36573bbd72807a53759891386b03955b187986d5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"a short name that can be used rather than the qualified class."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"bp stevedore"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2484af32e9eb3703869cf441e4f9851b54b0db2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3afb71cf_d71e5862","line":18,"in_reply_to":"7a016987_29037378","updated":"2015-06-09 00:27:31.000000000","message":"Done","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"}],"keystone/tests/unit/core.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"3c725527b97fd4e48896e11915307cbb6af9d4e0","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                method_classes \u003d dict("},{"line_number":330,"context_line":"                    external\u003d\u0027default\u0027,"},{"line_number":331,"context_line":"                    password\u003d\u0027default\u0027,"},{"line_number":332,"context_line":"                    token\u003d\u0027default\u0027,"},{"line_number":333,"context_line":"                )"},{"line_number":334,"context_line":"        self.config_fixture.config(group\u003d\u0027auth\u0027, methods\u003dmethods)"},{"line_number":335,"context_line":"        common_cfg.setup_authentication()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da1255d7_e911f5b0","line":332,"updated":"2015-05-11 23:57:13.000000000","message":"Sorry, but I don\u0027t know if I get it, If the user don\u0027t configure the auth plugin option, the user can authenticate using a password \"default\", or a token \"default\". This is right?","commit_id":"0295ad676f0f8ad708056d5d44df5ef37f11283e"}],"keystone/tests/unit/test_config.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"359d904e5649fc2a2f2200329f8800df2bbc4e66","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_config_default(self):"},{"line_number":49,"context_line":"        self.assertIs(None, CONF.auth.password)"},{"line_number":50,"context_line":"        self.assertIs(None, CONF.auth.token)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class DeprecatedTestCase(tests.TestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_f2ec2d2b","line":50,"updated":"2015-05-26 08:06:16.000000000","message":"Since `CONF.auth.password` and `CONF.auth.token` don\u0027t has default value anymore, we need test it with other config which has default value.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"36573bbd72807a53759891386b03955b187986d5","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_config_default(self):"},{"line_number":49,"context_line":"        self.assertIs(None, CONF.auth.password)"},{"line_number":50,"context_line":"        self.assertIs(None, CONF.auth.token)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class DeprecatedTestCase(tests.TestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_974ea06d","line":50,"in_reply_to":"7a016987_f2ec2d2b","updated":"2015-06-09 00:27:31.000000000","message":"This is testing the default config value for the plugins, which is now None. There\u0027s no need to test that oslo.config works correctly.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"}],"setup.cfg":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"359d904e5649fc2a2f2200329f8800df2bbc4e66","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    DefaultDomain \u003d keystone.auth.plugins.external:DefaultDomain"},{"line_number":73,"context_line":"    Domain \u003d keystone.auth.plugins.external:Domain"},{"line_number":74,"context_line":"    LegacyDefaultDomain \u003d keystone.auth.plugins.external:LegacyDefaultDomain"},{"line_number":75,"context_line":"    LegacyDomain \u003d keystone.auth.plugins.external:LegacyDomain"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"keystone.auth.kerberos \u003d"},{"line_number":78,"context_line":"    default \u003d keystone.auth.plugins.external:KerberosDomain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"7a016987_323085e8","line":75,"updated":"2015-05-26 08:06:16.000000000","message":"Shall we keep these deprecated method here? if so, why we not define `ExternalDefault` and `ExternalDomain`, if not, we need ignore `LegacyDefaultDomain` and `LegacyDomain` too.\n\nAnd we may need some testcases around this namespace since there is multiple plugins for this namespace.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"73bfa07bf99dddd2b9a1efb6b1049b7254e9166f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    DefaultDomain \u003d keystone.auth.plugins.external:DefaultDomain"},{"line_number":73,"context_line":"    Domain \u003d keystone.auth.plugins.external:Domain"},{"line_number":74,"context_line":"    LegacyDefaultDomain \u003d keystone.auth.plugins.external:LegacyDefaultDomain"},{"line_number":75,"context_line":"    LegacyDomain \u003d keystone.auth.plugins.external:LegacyDomain"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"keystone.auth.kerberos \u003d"},{"line_number":78,"context_line":"    default \u003d keystone.auth.plugins.external:KerberosDomain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"7a016987_fab40383","line":75,"in_reply_to":"7a016987_323085e8","updated":"2015-05-26 09:14:49.000000000","message":"Just submitted a patch to remove these deprecated method.\nhttps://review.openstack.org/#/c/185541/","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"36573bbd72807a53759891386b03955b187986d5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    DefaultDomain \u003d keystone.auth.plugins.external:DefaultDomain"},{"line_number":73,"context_line":"    Domain \u003d keystone.auth.plugins.external:Domain"},{"line_number":74,"context_line":"    LegacyDefaultDomain \u003d keystone.auth.plugins.external:LegacyDefaultDomain"},{"line_number":75,"context_line":"    LegacyDomain \u003d keystone.auth.plugins.external:LegacyDomain"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"keystone.auth.kerberos \u003d"},{"line_number":78,"context_line":"    default \u003d keystone.auth.plugins.external:KerberosDomain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"3afb71cf_b75e3c10","line":75,"in_reply_to":"7a016987_fab40383","updated":"2015-06-09 00:27:31.000000000","message":"Done","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"359d904e5649fc2a2f2200329f8800df2bbc4e66","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    LegacyDomain \u003d keystone.auth.plugins.external:LegacyDomain"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"keystone.auth.kerberos \u003d"},{"line_number":78,"context_line":"    default \u003d keystone.auth.plugins.external:KerberosDomain"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"keystone.auth.oauth1 \u003d"},{"line_number":81,"context_line":"    default \u003d keystone.auth.plugins.oauth1:OAuth"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"7a016987_524ae156","line":78,"updated":"2015-05-26 08:06:16.000000000","message":"why we not define this entrypoint in the `keystone.auth.external` instead?  checked from the code, kerberos is also a external method. Seems like the change like this will have little impact on the existing testcase, but it looks a little weird.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"36573bbd72807a53759891386b03955b187986d5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    LegacyDomain \u003d keystone.auth.plugins.external:LegacyDomain"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"keystone.auth.kerberos \u003d"},{"line_number":78,"context_line":"    default \u003d keystone.auth.plugins.external:KerberosDomain"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"keystone.auth.oauth1 \u003d"},{"line_number":81,"context_line":"    default \u003d keystone.auth.plugins.oauth1:OAuth"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"3afb71cf_779fa4b4","line":78,"in_reply_to":"7a016987_524ae156","updated":"2015-06-09 00:27:31.000000000","message":"I\u0027m not changing this.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"dc87ab391cb7af57f7baff90586684407a311c92","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    default \u003d keystone.auth.plugins.token:Token"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"keystone.auth.x509 \u003d"},{"line_number":96,"context_line":"    default \u003d keystone.auth.plugins.mapped:Mapped"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"keystone.catalog \u003d"},{"line_number":99,"context_line":"    kvs \u003d keystone.catalog.backends.kvs:Catalog"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"7a016987_49c46f5e","line":96,"updated":"2015-05-26 12:01:30.000000000","message":"can we define these auth plugins(oauth1, openid, password) in 1 section(e.g keystone.auth) ?","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"36573bbd72807a53759891386b03955b187986d5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    default \u003d keystone.auth.plugins.token:Token"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"keystone.auth.x509 \u003d"},{"line_number":96,"context_line":"    default \u003d keystone.auth.plugins.mapped:Mapped"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"keystone.catalog \u003d"},{"line_number":99,"context_line":"    kvs \u003d keystone.catalog.backends.kvs:Catalog"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"3afb71cf_b7b51c32","line":96,"in_reply_to":"7a016987_49c46f5e","updated":"2015-06-09 00:27:31.000000000","message":"Investigate it and then provide the answer yourself.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"2950d7eee5a29f6851d28052bf84ad4d1683f2cb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    default \u003d keystone.auth.plugins.token:Token"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"keystone.auth.x509 \u003d"},{"line_number":96,"context_line":"    default \u003d keystone.auth.plugins.mapped:Mapped"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"keystone.catalog \u003d"},{"line_number":99,"context_line":"    kvs \u003d keystone.catalog.backends.kvs:Catalog"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"7a016987_0224490a","line":96,"in_reply_to":"7a016987_49c46f5e","updated":"2015-06-01 14:20:41.000000000","message":"Seems not, since here need different namespace to distinguish each plugin.","commit_id":"b67c5b131b433695c086f2ed01ab36a4480f8c30"}]}