)]}'
{"keystone/service.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"87f636b0fd7763c29a181d3fa78d998dfb07b59a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    sub_routers \u003d []"},{"line_number":104,"context_line":"    _routers \u003d []"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    router_modules \u003d [auth, assignment, catalog, credential, identity, policy,"},{"line_number":107,"context_line":"                      resource]"},{"line_number":108,"context_line":"    if CONF.trust.enabled:"},{"line_number":109,"context_line":"        router_modules.append(trust)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_6d949ae1","line":106,"updated":"2015-05-13 18:27:51.000000000","message":"include a note above this about why auth is first, so it doesn\u0027t get re-sorted alphabetically","commit_id":"33efad86d54c27a77588909d655b6ecc46a404f1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4c069bad8c5015cb6cfa81acb3a17becc78cf6e6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    # NOTE(dstanek): Routers should be ordered by their frequency of use in"},{"line_number":107,"context_line":"    # a live system. This is due to the routes implementation. The most"},{"line_number":108,"context_line":"    # frequently used routers should appear first."},{"line_number":109,"context_line":"    router_modules \u003d [auth, assignment, catalog, credential, identity, policy,"},{"line_number":110,"context_line":"                      resource]"},{"line_number":111,"context_line":"    if CONF.trust.enabled:"},{"line_number":112,"context_line":"        router_modules.append(trust)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_657392e8","line":109,"updated":"2015-05-15 20:26:52.000000000","message":"If we\u0027re ordering by frequency of use, I think credential and policy should come last.","commit_id":"e8e4debc12d8f6b0d000142b6c93170684942c93"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b09153d27393aa80a9e07be1bac12b83965fcd2a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    # NOTE(dstanek): Routers should be ordered by their frequency of use in"},{"line_number":107,"context_line":"    # a live system. This is due to the routes implementation. The most"},{"line_number":108,"context_line":"    # frequently used routers should appear first."},{"line_number":109,"context_line":"    router_modules \u003d [auth, assignment, catalog, credential, identity, policy,"},{"line_number":110,"context_line":"                      resource]"},{"line_number":111,"context_line":"    if CONF.trust.enabled:"},{"line_number":112,"context_line":"        router_modules.append(trust)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_b9a86b21","line":109,"in_reply_to":"7a016987_00d0251e","updated":"2015-05-19 02:51:00.000000000","message":"I don\u0027t have any data to support it, but I think the credential and policy API are rarely used.  I would think lower than identity.  But you\u0027re probably right in that we should have some data to back that.","commit_id":"e8e4debc12d8f6b0d000142b6c93170684942c93"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6baafae3f6c5e0de30400fd860abeb4ac4c57e92","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    # NOTE(dstanek): Routers should be ordered by their frequency of use in"},{"line_number":107,"context_line":"    # a live system. This is due to the routes implementation. The most"},{"line_number":108,"context_line":"    # frequently used routers should appear first."},{"line_number":109,"context_line":"    router_modules \u003d [auth, assignment, catalog, credential, identity, policy,"},{"line_number":110,"context_line":"                      resource]"},{"line_number":111,"context_line":"    if CONF.trust.enabled:"},{"line_number":112,"context_line":"        router_modules.append(trust)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_00d0251e","line":109,"in_reply_to":"7a016987_657392e8","updated":"2015-05-18 18:35:01.000000000","message":"I don\u0027t have any data for that. My understanding is that in a live system auth routes are by far the most hit routes. If we can point to some references for this I\u0027d be happy to update.","commit_id":"e8e4debc12d8f6b0d000142b6c93170684942c93"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"402671cb1ffe23a43147474a9a7dedb4b7568c96","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    # NOTE(dstanek): Routers should be ordered by their frequency of use in"},{"line_number":107,"context_line":"    # a live system. This is due to the routes implementation. The most"},{"line_number":108,"context_line":"    # frequently used routers should appear first."},{"line_number":109,"context_line":"    router_modules \u003d [auth, assignment, catalog, credential, identity, policy,"},{"line_number":110,"context_line":"                      resource]"},{"line_number":111,"context_line":"    if CONF.trust.enabled:"},{"line_number":112,"context_line":"        router_modules.append(trust)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_a508f528","line":109,"in_reply_to":"7a016987_b9a86b21","updated":"2015-05-21 20:43:19.000000000","message":"this can be easily got by analysing a log of a regular deployment, but I support this change since \"auth\" is indeed hit a lot","commit_id":"e8e4debc12d8f6b0d000142b6c93170684942c93"}]}