)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"05376337536d9df6bb2ad3d07e115eca390dbc5c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The entry of keystone service tried to provide a default config file path"},{"line_number":10,"context_line":"to load config options, but the path is useless. Actually, the oslo_config"},{"line_number":11,"context_line":"lib can automatically find default config file or automatically load the"},{"line_number":12,"context_line":"config file specified by --config-file option. So the useless code should"},{"line_number":13,"context_line":"be removed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6639c7ec5d7ca9bc41b3e33ca86156b60be49e2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_3824310b","line":12,"updated":"2015-05-31 04:00:39.000000000","message":"`--config-file` can be used to specify a config file but we load \u0027keystone.conf\u0027 for example in the code as the default config, imo `--config-file option` is not a reason we should remove the default loading of config files? but oslo_config maybe a good reason to drop this.","commit_id":"8511a4a5e4ecc2ec4251757fd31c02dbf50e0e90"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"015aeb0f878d042f02d3b7176637bfc0ead5b8c6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The entry of keystone service tried to provide a default config file path"},{"line_number":10,"context_line":"to load config options, but the path is useless. Actually, the oslo_config"},{"line_number":11,"context_line":"lib can automatically find default config file or automatically load the"},{"line_number":12,"context_line":"config file specified by --config-file option. So the useless code should"},{"line_number":13,"context_line":"be removed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6639c7ec5d7ca9bc41b3e33ca86156b60be49e2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_39ac308b","line":12,"in_reply_to":"7a016987_3824310b","updated":"2015-06-01 01:23:10.000000000","message":"yes, this change has removed the process that generate the config file path in keystone code, like this: /opt/stack/keystone/etc/keystone.conf (in a devstack environment)\n\nI meant oslo_config lib can load config file specified by \"--config-file\" without explicit config file path.","commit_id":"8511a4a5e4ecc2ec4251757fd31c02dbf50e0e90"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e664a9aafae368180755bfa910642855f2d91047","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liu-sheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-01 09:31:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the useless config_files parameter of service entry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The entry of keystone service tried to provide a default config file path"},{"line_number":10,"context_line":"to load config options, but the path is useless. Actually, the oslo_config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_13494531","line":7,"updated":"2015-06-01 12:08:34.000000000","message":"s/useless/unused/","commit_id":"f427767c95aebb6dfc8baefd219ee5f549845148"}]}