)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"960fd5d5707fba416ffb984578dc1588126296e7","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"        if self.options_name is not None:"},{"line_number":1160,"context_line":"            self.suffix \u003d conf.ldap.suffix"},{"line_number":1161,"context_line":"            if self.suffix is None:"},{"line_number":1162,"context_line":"                self.suffix \u003d self.DEFAULT_SUFFIX"},{"line_number":1163,"context_line":"            dn \u003d \u0027%s_tree_dn\u0027 % self.options_name"},{"line_number":1164,"context_line":"            self.tree_dn \u003d (getattr(conf.ldap, dn)"},{"line_number":1165,"context_line":"                            or \u0027%s,%s\u0027 % (self.DEFAULT_OU, self.suffix))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_54122958","side":"PARENT","line":1162,"updated":"2015-06-18 07:46:17.000000000","message":"we got no chance and no possbility in the future that this constant is not set in config.py? seems it\u0027s more safe if keeping this instead of rely on what\u0027s it\u0027s defined in the config.py.","commit_id":"8bb63620b4d9ec71b0a60ed705938103d7d3c2c2"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"78dbeac0fabecb4acf3ab146cb62588755cf04e0","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"        if self.options_name is not None:"},{"line_number":1160,"context_line":"            self.suffix \u003d conf.ldap.suffix"},{"line_number":1161,"context_line":"            if self.suffix is None:"},{"line_number":1162,"context_line":"                self.suffix \u003d self.DEFAULT_SUFFIX"},{"line_number":1163,"context_line":"            dn \u003d \u0027%s_tree_dn\u0027 % self.options_name"},{"line_number":1164,"context_line":"            self.tree_dn \u003d (getattr(conf.ldap, dn)"},{"line_number":1165,"context_line":"                            or \u0027%s,%s\u0027 % (self.DEFAULT_OU, self.suffix))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_ee80c14b","side":"PARENT","line":1162,"in_reply_to":"fa32b979_54122958","updated":"2015-06-28 15:23:39.000000000","message":"I don\u0027t know what\u0027s going to happen in the future. If we\u0027re going to follow this policy consistently we\u0027d have a lot of code to change.","commit_id":"8bb63620b4d9ec71b0a60ed705938103d7d3c2c2"}]}