)]}'
{"keystone/token/persistence/backends/sql.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4dddaf36c63c2112f5d966535ed2d3373cc97166","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                        expiry_time)"},{"line_number":278,"context_line":"            row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":279,"context_line":"            total_removed +\u003d row_count"},{"line_number":280,"context_line":"            LOG.debug(\u0027Removed %d expired tokens\u0027, row_count)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        session.flush()"},{"line_number":283,"context_line":"        LOG.info(_LI(\u0027Total expired tokens removed: %d\u0027), total_removed)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a718b385","line":280,"updated":"2015-06-15 16:57:31.000000000","message":"Why do I care how many were removed this time through the loop? I can tell this from the existing message since it\u0027s just the difference from the last log message. Also, isn\u0027t it the same value every time?","commit_id":"c38a23a018530ca1d2b8ee3cf7720ef78734655f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b71578c572edccabe6ccc9a59f6cd18a14e2864c","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                        expiry_time)"},{"line_number":278,"context_line":"            row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":279,"context_line":"            total_removed +\u003d row_count"},{"line_number":280,"context_line":"            LOG.debug(\u0027Removed %d expired tokens\u0027, row_count)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        session.flush()"},{"line_number":283,"context_line":"        LOG.info(_LI(\u0027Total expired tokens removed: %d\u0027), total_removed)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_18a460a4","line":280,"in_reply_to":"fa32b979_785d6ce8","updated":"2015-06-15 17:40:02.000000000","message":"The \"Total expired tokens removed\" isn\u0027t redundant -- it tells me as a developer that the loop is completed. It\u0027s logged at INFO level rather than DEBUG, so I wouldn\u0027t expect to see the progress messages unless I was debugging.","commit_id":"c38a23a018530ca1d2b8ee3cf7720ef78734655f"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"130fb26c74d7a9cc06542c3ee543b600dcd8eca0","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                        expiry_time)"},{"line_number":278,"context_line":"            row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":279,"context_line":"            total_removed +\u003d row_count"},{"line_number":280,"context_line":"            LOG.debug(\u0027Removed %d expired tokens\u0027, row_count)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        session.flush()"},{"line_number":283,"context_line":"        LOG.info(_LI(\u0027Total expired tokens removed: %d\u0027), total_removed)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_785d6ce8","line":280,"in_reply_to":"fa32b979_a718b385","updated":"2015-06-15 17:34:11.000000000","message":"Brant, so according to the comment, its \"roughly equal\".\n\nhttps://review.openstack.org/#/c/191157/3/keystone/token/persistence/backends/sql.py#L57\n\nSo its roughly the same every time I suppose? Having two \"total\" token removed messages seem redundant.","commit_id":"c38a23a018530ca1d2b8ee3cf7720ef78734655f"}]}