)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"979cf75fae6b9de924a918821386eddd5115017f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This amends the existing rotation test to ensure that after each key"},{"line_number":10,"context_line":"rotation, a completely new set of keys exists on disk. This is just a"},{"line_number":11,"context_line":"paranoid test to ensure that they key rotation strategy isn\u0027t something"},{"line_number":12,"context_line":"terribly dumb like \"shuffle all key files on disk without creating any"},{"line_number":13,"context_line":"new ones.\""},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba3cc151_e3feec04","line":11,"updated":"2015-06-28 23:24:16.000000000","message":"(nit) change \"they\" to \"the\"","commit_id":"fdb55a52aaa526962f2f05f0229bfb318c198d53"}],"keystone/tests/unit/token/test_fernet_provider.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"3a7291950471a2aa23c9337e243823456e8af5e4","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            signature.update(key)"},{"line_number":368,"context_line":"        return signature.hexdigest()"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def assertUniqueRepositoryState(self, key_repo_signatures):"},{"line_number":371,"context_line":"        \"\"\"Ensures that the current key repo state has not been seen before.\"\"\""},{"line_number":372,"context_line":"        # This is assigned to a variable because it takes some work to"},{"line_number":373,"context_line":"        # calculate."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_1781788f","line":370,"updated":"2015-06-22 16:34:48.000000000","message":"I suggest to rename the method. The function is destructive for key_repo_signatures, while other assert* functions are not for their arguments.","commit_id":"fdb55a52aaa526962f2f05f0229bfb318c198d53"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"979cf75fae6b9de924a918821386eddd5115017f","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            signature.update(key)"},{"line_number":368,"context_line":"        return signature.hexdigest()"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def assertUniqueRepositoryState(self, key_repo_signatures):"},{"line_number":371,"context_line":"        \"\"\"Ensures that the current key repo state has not been seen before.\"\"\""},{"line_number":372,"context_line":"        # This is assigned to a variable because it takes some work to"},{"line_number":373,"context_line":"        # calculate."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_431a3870","line":370,"in_reply_to":"fa32b979_1781788f","updated":"2015-06-28 23:24:16.000000000","message":"Boris - propose a separate commit with the rename you have in mind.\n\nAlso, do we really have to pass around key_repo_signatures? suggest make an instance property. Or create a testools.Matcher.","commit_id":"fdb55a52aaa526962f2f05f0229bfb318c198d53"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3af70d9833e8d66f4331fea9800f0bdaa59a17dc","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                key_no +\u003d 1"},{"line_number":438,"context_line":"                self.assertEqual(exp_keys, self.keys)"},{"line_number":439,"context_line":"                self.assertUniqueRepositoryState()"},{"line_number":440,"context_line":"                self.assertEqual(self.key_repository_size, max_active_keys)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b08347ca","line":440,"updated":"2015-07-29 21:29:02.000000000","message":"if these assertions should always be checked together then suggest create an assertRespositoryState() or something.","commit_id":"d59e1b24ed55d45127f5f2062bc080622a25b839"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"c665cb20e09bff4902a42c207ab61bd22c540798","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                key_no +\u003d 1"},{"line_number":438,"context_line":"                self.assertEqual(exp_keys, self.keys)"},{"line_number":439,"context_line":"                self.assertUniqueRepositoryState()"},{"line_number":440,"context_line":"                self.assertEqual(self.key_repository_size, max_active_keys)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_f84875ce","line":440,"in_reply_to":"3a50d1a3_b08347ca","updated":"2015-07-31 16:52:20.000000000","message":"Done","commit_id":"d59e1b24ed55d45127f5f2062bc080622a25b839"}]}