)]}'
{"keystone/exception.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"24882a99f00d3bdbe2cdbb2a2020a1c0ef08a590","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Tests use this to make exception message format errors fatal"},{"line_number":26,"context_line":"_FATAL_EXCEPTION_FORMAT_ERRORS \u003d False"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class Error(StandardError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FrjU%3D","line":26,"updated":"2013-01-09 19:34:24.000000000","message":"I\u0027m assuming that the dependent change[1] that this is referencing can\u0027t be squashed with this one because of the fix to test_forbidden_action_exposure...\n\n[1]: https://review.openstack.org/#/c/19325/1/keystone/test.py","commit_id":"8507261996f3c2c12496141238f0e9707b4e57aa"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"3d75757dc5559984627741f99306b03decaf9399","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Tests use this to make exception message format errors fatal"},{"line_number":26,"context_line":"_FATAL_EXCEPTION_FORMAT_ERRORS \u003d False"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class Error(StandardError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fm9c%3D","line":26,"in_reply_to":"AAAAM3%2F%2FrjU%3D","updated":"2013-01-14 03:36:24.000000000","message":"Dolph: I think that is correct.","commit_id":"8507261996f3c2c12496141238f0e9707b4e57aa"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a2aabe5a0c8f36c0a5da7e920a4357ff44d7be00","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\"Use the doc string as the error message by default.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            message \u003d self._build_message(message, **kwargs)"},{"line_number":43,"context_line":"        except KeyError as e:"},{"line_number":44,"context_line":"            # if you see this warning in your logs, please raise a bug report"},{"line_number":45,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Focw%3D","line":42,"updated":"2013-01-11 21:19:58.000000000","message":"blk-u: the super() call at the bottom of the method may also consume the value assigned here, so that call can\u0027t be moved","commit_id":"8507261996f3c2c12496141238f0e9707b4e57aa"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"23c80e8423ebe19859b730bbda0c5f3e63ef2fb0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                raise e"},{"line_number":47,"context_line":"            else:"},{"line_number":48,"context_line":"                LOG.warning(\u0027missing exception kwargs (programmer error)\u0027)"},{"line_number":49,"context_line":"                message \u003d self.__doc__"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        super(Error, self).__init__(message)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Foj8%3D","line":49,"updated":"2013-01-11 20:18:58.000000000","message":"suggestion - change the text of the warning to the comment and remove the comment, like \u0027\u0027missing exception kwargs - if you if you see this, please raise a bug report\u0027.\n\nshould the message also be logged in the _FATAL_EXCEPTION_FORMAT_ERRORS case? In case the exception is caught somewhere and ignored.\n\ncould remove the else: since the raise will break out of the message, and it\u0027s confusing because it skips not just the code in the else: but also the super() call below (or move the super() call into the else block).","commit_id":"8507261996f3c2c12496141238f0e9707b4e57aa"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"3d75757dc5559984627741f99306b03decaf9399","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                raise e"},{"line_number":47,"context_line":"            else:"},{"line_number":48,"context_line":"                LOG.warning(\u0027missing exception kwargs (programmer error)\u0027)"},{"line_number":49,"context_line":"                message \u003d self.__doc__"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        super(Error, self).__init__(message)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fm9U%3D","line":49,"in_reply_to":"AAAAM3%2F%2Foj8%3D","updated":"2013-01-14 03:36:24.000000000","message":"blk-u: The primary goal of this change is to make it possible for our keystone unit tests to fail if there are kwarg errors. In the case that an exception is thrown the error should be very clear (kwargs failed...) and I don\u0027t think the extra log message will be that helpful.","commit_id":"8507261996f3c2c12496141238f0e9707b4e57aa"}]}