)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"855dbd09bbe5b2b96daab866837bbc20a8cc7abf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There was some unused code in the file-based code path for"},{"line_number":10,"context_line":"domain specific configs. This patch removes it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixes Bug 1466772"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7fc2f6a6aa78984cfd403416a1237561a5c014d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_dec01a7f","line":12,"updated":"2015-07-21 02:57:14.000000000","message":"Fixes-Bug: #","commit_id":"ca12ede747e21f338f78b5fd5b05c30d7a28f774"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6b5477fe4edffd34b721d7a5728631bdd0d3f1e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There was some unused code in the file-based code path for"},{"line_number":10,"context_line":"domain specific configs. This patch removes it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixes Bug 1466772"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7fc2f6a6aa78984cfd403416a1237561a5c014d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_5f84e8d2","line":12,"in_reply_to":"3a50d1a3_dec01a7f","updated":"2015-07-21 14:12:35.000000000","message":"Done","commit_id":"ca12ede747e21f338f78b5fd5b05c30d7a28f774"}],"keystone/identity/core.py":[{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"975c195da0508c397a307cf1e0b732b11a3cb8b6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"},{"line_number":136,"context_line":"        _assert_no_more_than_one_sql_driver(domain_ref[\u0027id\u0027],"},{"line_number":137,"context_line":"                                            domain_config,"},{"line_number":138,"context_line":"                                            config_file\u003dfile_list)"},{"line_number":139,"context_line":"        self[domain_ref[\u0027id\u0027]] \u003d domain_config"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _setup_domain_drivers_from_files(self, standard_driver, resource_api):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_de857aad","line":138,"updated":"2015-07-21 03:18:31.000000000","message":"config_file is not an optional parameter of \u0027_assert_no_more_than_one_sql_driver\u0027 anymore, so it\u0027s enough to have \u0027file_list\u0027 as the last argument, instead of the named config_file\u003dfile_list.","commit_id":"ca12ede747e21f338f78b5fd5b05c30d7a28f774"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6b5477fe4edffd34b721d7a5728631bdd0d3f1e5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"},{"line_number":136,"context_line":"        _assert_no_more_than_one_sql_driver(domain_ref[\u0027id\u0027],"},{"line_number":137,"context_line":"                                            domain_config,"},{"line_number":138,"context_line":"                                            config_file\u003dfile_list)"},{"line_number":139,"context_line":"        self[domain_ref[\u0027id\u0027]] \u003d domain_config"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _setup_domain_drivers_from_files(self, standard_driver, resource_api):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_3f231c07","line":138,"in_reply_to":"3a50d1a3_de857aad","updated":"2015-07-21 14:12:35.000000000","message":"Done","commit_id":"ca12ede747e21f338f78b5fd5b05c30d7a28f774"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"526694f2edf134dd2738997e00ec36fe54c9f2bc","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        def _assert_no_more_than_one_sql_driver(domain_id, new_config,"},{"line_number":103,"context_line":"                                                config_file):"},{"line_number":104,"context_line":"            \"\"\"Ensure there is more than one sql driver."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            Check to see if the addition of the driver in this new config"},{"line_number":107,"context_line":"            would cause there to now be more than one sql driver."}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_9d50ca33","line":104,"updated":"2015-07-23 08:57:43.000000000","message":"the docstring should be changed, *no* more than one sql driver.","commit_id":"9e9fb4e9d4784d73edc4f345da6c91af0da66ee7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2fa63f80e9c859efd81d082c4c7a01ab45c58583","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        def _assert_no_more_than_one_sql_driver(domain_id, new_config,"},{"line_number":103,"context_line":"                                                config_file):"},{"line_number":104,"context_line":"            \"\"\"Ensure there is more than one sql driver."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            Check to see if the addition of the driver in this new config"},{"line_number":107,"context_line":"            would cause there to now be more than one sql driver."}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_71b9c9eb","line":104,"in_reply_to":"3a50d1a3_9d50ca33","updated":"2015-08-01 12:58:36.000000000","message":"Done","commit_id":"9e9fb4e9d4784d73edc4f345da6c91af0da66ee7"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"526694f2edf134dd2738997e00ec36fe54c9f2bc","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            \"\"\"Ensure there is more than one sql driver."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            Check to see if the addition of the driver in this new config"},{"line_number":107,"context_line":"            would cause there to now be more than one sql driver."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            \"\"\""},{"line_number":110,"context_line":"            if (new_config[\u0027driver\u0027].is_sql and"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_3d3ad6e7","line":107,"updated":"2015-07-23 08:57:43.000000000","message":"cause there to be more than..., remove \"now\".","commit_id":"9e9fb4e9d4784d73edc4f345da6c91af0da66ee7"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2fa63f80e9c859efd81d082c4c7a01ab45c58583","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            \"\"\"Ensure there is more than one sql driver."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            Check to see if the addition of the driver in this new config"},{"line_number":107,"context_line":"            would cause there to now be more than one sql driver."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            \"\"\""},{"line_number":110,"context_line":"            if (new_config[\u0027driver\u0027].is_sql and"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_91bc95dc","line":107,"in_reply_to":"3a50d1a3_3d3ad6e7","updated":"2015-08-01 12:58:36.000000000","message":"Done","commit_id":"9e9fb4e9d4784d73edc4f345da6c91af0da66ee7"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"74a9b42c3dd94a9616264c21c7cf195d5de56ed1","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            LOG.warning("},{"line_number":125,"context_line":"                _LW(\u0027Invalid domain name (%s) found in config file name\u0027),"},{"line_number":126,"context_line":"                domain_name)"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Create a new entry in the domain config dict, which contains"},{"line_number":130,"context_line":"        # a new instance of both the conf environment and driver using"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_bac69b14","line":127,"updated":"2015-09-21 16:27:35.000000000","message":"Do you know the reason to only add a log instead to raise a exception in this case?","commit_id":"358fd907340f743fe47b5b56844c227981e44785"},{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"30de49a51206a2c75e8a91bfa6b5d1e06c267a68","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            LOG.warning("},{"line_number":125,"context_line":"                _LW(\u0027Invalid domain name (%s) found in config file name\u0027),"},{"line_number":126,"context_line":"                domain_name)"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Create a new entry in the domain config dict, which contains"},{"line_number":130,"context_line":"        # a new instance of both the conf environment and driver using"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a29b11f_b827b861","line":127,"in_reply_to":"3a29b11f_228ff975","updated":"2015-10-23 12:25:39.000000000","message":"Got it, thanks for the explanation.","commit_id":"358fd907340f743fe47b5b56844c227981e44785"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"84243730008d37a61a77b578a923bb7cbfc8ff64","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            LOG.warning("},{"line_number":125,"context_line":"                _LW(\u0027Invalid domain name (%s) found in config file name\u0027),"},{"line_number":126,"context_line":"                domain_name)"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # Create a new entry in the domain config dict, which contains"},{"line_number":130,"context_line":"        # a new instance of both the conf environment and driver using"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a29b11f_228ff975","line":127,"in_reply_to":"ba15a1d1_bac69b14","updated":"2015-10-23 11:30:21.000000000","message":"This code in _setup_domain_drivers_from_files() walks the filesystem to find what it thinks are config files based on a pattern. I\u0027m guessing that the author expected that there could be config files that matched the pattern that weren\u0027t domain configs. Like keystone.old.conf.","commit_id":"358fd907340f743fe47b5b56844c227981e44785"}]}