)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0c89cf9d487cae7acb0daca6d73e46e121b2cb80","unresolved":false,"context_lines":[{"line_number":1755,"context_line":"                satisfied_filters.append(filter_)"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        if filter_list:"},{"line_number":1758,"context_line":"            if query is None:"},{"line_number":1759,"context_line":"                # make sure query is a string"},{"line_number":1760,"context_line":"                query \u003d \u0027\u0027"},{"line_number":1761,"context_line":"            query \u003d u\u0027(\u0026%s%s)\u0027 % (query, \u0027\u0027.join(filter_list))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_7266a72a","line":1758,"updated":"2015-07-07 23:16:57.000000000","message":"Why not move this check up to the filter_query() method? Maybe line 1689.\n\n    query \u003d query or \u0027\u0027\n\nRight now we are doing this check in a loop, very far away from where the variable initially enters the method.","commit_id":"2988e92184f3636cbdce55bda1e80a614a78e625"}]}