)]}'
{"run_tests.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b22e6df0a77bb407cff49ffc4c8150018e30bd04","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    set -e"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    if [ \"${RESULT}\" -ne 0 ]; then"},{"line_number":104,"context_line":"        exit ${RESULT}"},{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    if [ $do_log -eq 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_ab608436","line":104,"updated":"2015-06-30 06:16:50.000000000","message":"What is purpose of doing \u0027set +e\u0027 and \u0027set -e\u0027 if going to exit anyway?\n\nShouldn\u0027t this be down below after the the errors are logged?","commit_id":"1ae7096ab6ffbcd127dc24a42622188384735b4b"},{"author":{"_account_id":17055,"name":"Nathan Jewell","email":"ncjewell@gmail.com","username":"ncjewell"},"change_message_id":"743638a4f28fc0a100723eac44c98e8ca6fba4ac","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    set -e"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    if [ \"${RESULT}\" -ne 0 ]; then"},{"line_number":104,"context_line":"        exit ${RESULT}"},{"line_number":105,"context_line":"    fi"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    if [ $do_log -eq 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_ddc031e3","line":104,"in_reply_to":"ba3cc151_ab608436","updated":"2015-07-06 16:48:39.000000000","message":"Moved to end of script in patch set 3.","commit_id":"1ae7096ab6ffbcd127dc24a42622188384735b4b"},{"author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"change_message_id":"0fb8f203ad351b2c761639f389b5eac2149760ae","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        echo \"Creating log file...\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if [ $log_all -eq 0 ]; then"},{"line_number":111,"context_line":"            ${wrapper}  testr last --subunit | subunit-filter --error \u003e run_tests.log"},{"line_number":112,"context_line":"        else"},{"line_number":113,"context_line":"            ${wrapper}  testr last --subunit \u003e run_tests.log"},{"line_number":114,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_9f74d69c","line":111,"updated":"2015-06-30 08:03:09.000000000","message":"\u003e?  log will be overwritten，I think it should be changed to \u0027\u003e\u003e\u0027.","commit_id":"1ae7096ab6ffbcd127dc24a42622188384735b4b"},{"author":{"_account_id":17055,"name":"Nathan Jewell","email":"ncjewell@gmail.com","username":"ncjewell"},"change_message_id":"2e4501d95eb3d397fbe82a7dd3ea0b2dcf89988f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        echo \"Creating log file...\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if [ $log_all -eq 0 ]; then"},{"line_number":111,"context_line":"            ${wrapper}  testr last --subunit | subunit-filter --error \u003e run_tests.log"},{"line_number":112,"context_line":"        else"},{"line_number":113,"context_line":"            ${wrapper}  testr last --subunit \u003e run_tests.log"},{"line_number":114,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_08f179cd","line":111,"in_reply_to":"ba3cc151_9f74d69c","updated":"2015-07-06 16:51:19.000000000","message":"I implemented the fix suggested by Malani in patch set 4 which should address your concerns as well.","commit_id":"1ae7096ab6ffbcd127dc24a42622188384735b4b"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"24312f84fbe9392911ee7adf68dcd7ac99e5bb56","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    RESULT\u003d$?"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    if [ \"${RESULT}\" -ne 0 ]; then"},{"line_number":103,"context_line":"        exit ${RESULT}"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [ $do_log -eq 1 ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba3cc151_84623bd7","line":103,"updated":"2015-07-07 06:13:02.000000000","message":"What is purpose of doing \u0027set +e\u0027 if just going to exit if get a failing result?\n\nAs it is, if there is a failing test the code just exits here and no logs are saved.  I would think if there is a failure we would want to save the logs.\n\nSo I would suggest moving this if block to after the saving of the log file.","commit_id":"5545c4f7017185d8bc653832ff1813d83107888c"},{"author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"change_message_id":"4234f35e6b44ade71066fd94fe740435657403bc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if [ -f run_tests.log ]; then"},{"line_number":110,"context_line":"            echo \"Found existing log file...\""},{"line_number":111,"context_line":"            echo \"Creating backup log file...\""},{"line_number":112,"context_line":"            cat run_tests.log \u003e run_tests.log.bak"},{"line_number":113,"context_line":"        fi"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if [ $log_all -eq 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba3cc151_3537dfb1","line":112,"updated":"2015-07-07 02:57:43.000000000","message":"But this also will make run_tests.log.bak also will be overwritten, log still can not be saved. Can I ask you why you don\u0027t want to change \u0027\u003e\u0027 to \u0027\u003e\u003e\u0027?","commit_id":"5545c4f7017185d8bc653832ff1813d83107888c"},{"author":{"_account_id":17055,"name":"Nathan Jewell","email":"ncjewell@gmail.com","username":"ncjewell"},"change_message_id":"6c66a90ca8953dcc0d7439c4f1a45319af88f77d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if [ -f run_tests.log ]; then"},{"line_number":110,"context_line":"            echo \"Found existing log file...\""},{"line_number":111,"context_line":"            echo \"Creating backup log file...\""},{"line_number":112,"context_line":"            cat run_tests.log \u003e run_tests.log.bak"},{"line_number":113,"context_line":"        fi"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        if [ $log_all -eq 0 ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ba3cc151_2fcbee54","line":112,"in_reply_to":"ba3cc151_3537dfb1","updated":"2015-07-07 15:59:01.000000000","message":"I agree, it would be nice to have the ability to keep many previous versions of the log file.  However, I think having different files makes comparing to tests much easier.  Perhaps I could implement a system that added an option to either create a separate log file or just append the new log to a master list.  But maybe that is getting complicated.  The other thing is that with the -a option, logs can be 50+ MB which, in one file, becomes unwieldy very quickly.  Given these considerations, what would you suggest?","commit_id":"5545c4f7017185d8bc653832ff1813d83107888c"}]}