)]}'
{"keystone/token/controllers.py":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"e348c19c199930ad55cea4ef5341a39ceaae4c89","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # NOTE(morganfainberg): The V3 Token issuance handles swapping the"},{"line_number":195,"context_line":"        # user_id in the token scope if there is an impersonation trust"},{"line_number":196,"context_line":"        # used."},{"line_number":197,"context_line":"        current_user_ref \u003d self.identity_api.get_user(user_id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not CONF.trust.enabled and \u0027trust_id\u0027 in auth:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_7c79fdfb","line":197,"updated":"2015-06-29 16:37:48.000000000","message":"I\u0027d rather leave it explicit. It breaks nothing and makes the code a bit more readable.","commit_id":"d2115c7f708f81ffdece25fafec4458ae7be4542"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3f33786c00baef5902115b1f419ce3dd6dcfa94e","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # NOTE(morganfainberg): The V3 Token issuance handles swapping the"},{"line_number":195,"context_line":"        # user_id in the token scope if there is an impersonation trust"},{"line_number":196,"context_line":"        # used."},{"line_number":197,"context_line":"        current_user_ref \u003d self.identity_api.get_user(user_id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not CONF.trust.enabled and \u0027trust_id\u0027 in auth:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f590a997","line":197,"in_reply_to":"ba3cc151_7c79fdfb","updated":"2015-06-30 04:30:50.000000000","message":"It actually will require a much much much bigger refactor to resolve this as the entire V3 pipeline assumes the V3 provider enforces this. Leaving the explicit here does break either the entire trust token issuance for impersonation or requires lifting all of that logic higher in the v3 issuance pipeline as well.\n\nI went for the least impactful version to V3 tokens (v2 tokens on on life support until V2 is removed, which is on the horizon).","commit_id":"d2115c7f708f81ffdece25fafec4458ae7be4542"},{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"2554111150dcbe3985cfde841ed74077cdefc4e7","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        # NOTE(morganfainberg): The V3 Token issuance handles swapping the"},{"line_number":195,"context_line":"        # user_id in the token scope if there is an impersonation trust"},{"line_number":196,"context_line":"        # used."},{"line_number":197,"context_line":"        current_user_ref \u003d self.identity_api.get_user(user_id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        if not CONF.trust.enabled and \u0027trust_id\u0027 in auth:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_4dba21c2","line":197,"in_reply_to":"ba3cc151_f590a997","updated":"2015-06-30 12:03:51.000000000","message":"Well, let\u0027s clean the mess later then.","commit_id":"d2115c7f708f81ffdece25fafec4458ae7be4542"}]}