)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"a6b500cd13e62afd18bce9d69834120f909c28ad","unresolved":false,"context_lines":[{"line_number":17,"context_line":"After putting these functions into AuthTestMixin, those test classes who"},{"line_number":18,"context_line":"inherit from AuthTestMixin can directly using"},{"line_number":19,"context_line":"self.build_role_assignment_* functions."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9c7d78fab6c4f6428523c3fec7e9d9d305313ae3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_f8da074b","line":20,"updated":"2015-07-10 09:55:21.000000000","message":"It would be better if you provide reference of a bug or bp here.","commit_id":"7be3a32940c13a6199ab0f28b8884493257ac633"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"e558d6306184decbad41e39d631b42ec19a16188","unresolved":false,"context_lines":[{"line_number":17,"context_line":"After putting these functions into AuthTestMixin, those test classes who"},{"line_number":18,"context_line":"inherit from AuthTestMixin can directly using"},{"line_number":19,"context_line":"self.build_role_assignment_* functions."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9c7d78fab6c4f6428523c3fec7e9d9d305313ae3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_e77fc215","line":20,"in_reply_to":"ba3cc151_c13ceec1","updated":"2015-07-10 11:53:46.000000000","message":"IMO If you are going to change something, there should be a bug associated with it.\n\nThis makes it easy to track the changes and if some wants to check in future why a change was made, he/she can go through bug description for detailed information.","commit_id":"7be3a32940c13a6199ab0f28b8884493257ac633"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"31f61fe7d936a07210eb2cbdf5e9a000f6526789","unresolved":false,"context_lines":[{"line_number":17,"context_line":"After putting these functions into AuthTestMixin, those test classes who"},{"line_number":18,"context_line":"inherit from AuthTestMixin can directly using"},{"line_number":19,"context_line":"self.build_role_assignment_* functions."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9c7d78fab6c4f6428523c3fec7e9d9d305313ae3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_99e3baa4","line":20,"in_reply_to":"ba3cc151_e77fc215","updated":"2015-07-10 12:20:41.000000000","message":"I don\u0027t think that this change requires a bugreport or a bp. This is a very small local refactoring.","commit_id":"7be3a32940c13a6199ab0f28b8884493257ac633"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7d1adccd8f1454b6583a138d9585332b6858d660","unresolved":false,"context_lines":[{"line_number":17,"context_line":"After putting these functions into AuthTestMixin, those test classes who"},{"line_number":18,"context_line":"inherit from AuthTestMixin can directly using"},{"line_number":19,"context_line":"self.build_role_assignment_* functions."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9c7d78fab6c4f6428523c3fec7e9d9d305313ae3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_5c868017","line":20,"in_reply_to":"ba3cc151_e77fc215","updated":"2015-07-10 12:36:58.000000000","message":"The commit message in this case has enough of the \u0027why\u0027. No need for a bug report to refactor tests. It\u0027s also somewhat frowned upon since bug reports are used to generate the changelog and not many users will case about changes like this.","commit_id":"7be3a32940c13a6199ab0f28b8884493257ac633"},{"author":{"_account_id":16165,"name":"Chenhong Liu","email":"liuchenhong@unitedstack.com","username":"liuchenhong"},"change_message_id":"e56dd2076698e256a252ecd32ea181c1aff1f778","unresolved":false,"context_lines":[{"line_number":17,"context_line":"After putting these functions into AuthTestMixin, those test classes who"},{"line_number":18,"context_line":"inherit from AuthTestMixin can directly using"},{"line_number":19,"context_line":"self.build_role_assignment_* functions."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9c7d78fab6c4f6428523c3fec7e9d9d305313ae3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_c13ceec1","line":20,"in_reply_to":"ba3cc151_f8da074b","updated":"2015-07-10 10:58:25.000000000","message":"I don\u0027t think this change is related to a bug. And, why did you think this change need to be describe by a bp?","commit_id":"7be3a32940c13a6199ab0f28b8884493257ac633"}],"keystone/tests/unit/test_v3.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"680deadbd45e9c68e85505385cc35e62b7286f72","unresolved":false,"context_lines":[{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"class AssignmentTestMixin(object):"},{"line_number":1360,"context_line":"    \"\"\"Toi hold assignment helper functions.\"\"\""},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    def build_role_assignment_query_url(self, effective\u003dFalse, **filters):"},{"line_number":1363,"context_line":"        \"\"\"Build and return a role assignment query url with provided params."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_17f43f85","line":1360,"updated":"2015-07-10 18:35:53.000000000","message":"s/Toi/To/","commit_id":"3826a89aef9a06557a8ca0c4150ec09e586bf422"}],"keystone/tests/unit/test_v3_assignment.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"ba704212881c3cc28090111c6234c732e5c2ddde","unresolved":false,"context_lines":[{"line_number":31,"context_line":"_build_role_assignment_link \u003d tests.utils.build_role_assignment_link"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_build_role_assignment_entity \u003d tests.utils.build_role_assignment_entity"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class AssignmentTestCase(test_v3.RestfulTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_5911b2ae","line":34,"updated":"2015-07-06 05:35:02.000000000","message":"you don\u0027t need to/shouldn\u0027t maintain backwards compatibility in tests. These are not public functions.","commit_id":"e228f604b0b7316bec58a13f7fb72bb755ee078b"},{"author":{"_account_id":16165,"name":"Chenhong Liu","email":"liuchenhong@unitedstack.com","username":"liuchenhong"},"change_message_id":"3e37abd3a81491f2b58562bda56e71e6133d7c59","unresolved":false,"context_lines":[{"line_number":31,"context_line":"_build_role_assignment_link \u003d tests.utils.build_role_assignment_link"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"_build_role_assignment_entity \u003d tests.utils.build_role_assignment_entity"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class AssignmentTestCase(test_v3.RestfulTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_9c4de8c6","line":34,"in_reply_to":"ba3cc151_5911b2ae","updated":"2015-07-06 06:41:00.000000000","message":"Done","commit_id":"e228f604b0b7316bec58a13f7fb72bb755ee078b"}],"keystone/tests/unit/utils.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"ba704212881c3cc28090111c6234c732e5c2ddde","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    if attribs.get(\u0027inherited_to_projects\u0027):"},{"line_number":173,"context_line":"        entity[\u0027scope\u0027][\u0027OS-INHERIT:inherited_to\u0027] \u003d \u0027projects\u0027"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    return entity"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_d925c20a","line":175,"updated":"2015-07-06 05:35:02.000000000","message":"this seems like the wrong place to me, not because it\u0027s wrong but because we have a bunch of functions like this and they currenlty live in test_v3.py so we should keep them together.","commit_id":"e228f604b0b7316bec58a13f7fb72bb755ee078b"},{"author":{"_account_id":16165,"name":"Chenhong Liu","email":"liuchenhong@unitedstack.com","username":"liuchenhong"},"change_message_id":"3e37abd3a81491f2b58562bda56e71e6133d7c59","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    if attribs.get(\u0027inherited_to_projects\u0027):"},{"line_number":173,"context_line":"        entity[\u0027scope\u0027][\u0027OS-INHERIT:inherited_to\u0027] \u003d \u0027projects\u0027"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    return entity"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_3cd5bcb8","line":175,"in_reply_to":"ba3cc151_d925c20a","updated":"2015-07-06 06:41:00.000000000","message":"OK. I move these functions to test_v3.py, put them in class TestAuthMixin.","commit_id":"e228f604b0b7316bec58a13f7fb72bb755ee078b"}]}