)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13055,"name":"Alexander Makarov","email":"ajiekcahdp.makapob@gmail.com","username":"amakarov"},"change_message_id":"6cf2dbd9a6e6a8442bc592726cafa9590d0aa364","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     henriquetruta \u003chenrique@lsd.ufcg.edu.br\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-09 19:29:54 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changing execption type to ValidationError instead of Forbidden"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes two points where a ForbiddenAction is thrown, instead of a"},{"line_number":10,"context_line":"ValidationError."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_263fdb88","line":7,"updated":"2015-07-10 17:15:33.000000000","message":"I suppose, it will be enough if you just specify the location: \"in project creation\"","commit_id":"265a836f5efdc8684c0f46a8608247231ab639a8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"32d0204e7b758318c95c337ef99fbe47c6da5f06","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changing execption type to ValidationError instead of Forbidden"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes two points where a ForbiddenAction is thrown, instead of a"},{"line_number":10,"context_line":"ValidationError."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie03fa2f71880230b59c3df9a972399ef05b104fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_a25a2180","line":9,"updated":"2015-07-09 22:52:59.000000000","message":"It\u0027s easy to see what you did by looking at the code. Can you add a note about \"why\" you did it?","commit_id":"265a836f5efdc8684c0f46a8608247231ab639a8"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"7ea2fdb83681622cacb07961721ec8c44d73486d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changing execption type to ValidationError instead of Forbidden"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes two points where a ForbiddenAction is thrown, instead of a"},{"line_number":10,"context_line":"ValidationError."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie03fa2f71880230b59c3df9a972399ef05b104fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_0908d1d8","line":9,"in_reply_to":"ba3cc151_a25a2180","updated":"2015-07-10 00:47:33.000000000","message":"ok. I\u0027ll do it.","commit_id":"265a836f5efdc8684c0f46a8608247231ab639a8"}],"keystone/resource/core.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"6c927c9b3376c9d20ec885602a6759ce6b615086","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            parents_list.append(parent_ref)"},{"line_number":97,"context_line":"            for ref in parents_list:"},{"line_number":98,"context_line":"                if ref.get(\u0027domain_id\u0027) !\u003d tenant.get(\u0027domain_id\u0027):"},{"line_number":99,"context_line":"                    raise exception.ValidationError("},{"line_number":100,"context_line":"                        message\u003d_(\u0027cannot create a project within a different \u0027"},{"line_number":101,"context_line":"                                  \u0027domain than its parents.\u0027))"},{"line_number":102,"context_line":"                if not ref.get(\u0027enabled\u0027, True):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_6cf7205a","line":99,"updated":"2015-07-10 08:58:11.000000000","message":"Rather than exception.ValidationError, I think exception.Forbidden is better in this context.\n\nMaybe there is some points I didn\u0027t catch, add it in the commit message or comments here,thx.","commit_id":"265a836f5efdc8684c0f46a8608247231ab639a8"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"39efa6873569fe3088b2ff06c89f74d39bb36dd0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            parents_list.append(parent_ref)"},{"line_number":97,"context_line":"            for ref in parents_list:"},{"line_number":98,"context_line":"                if ref.get(\u0027domain_id\u0027) !\u003d tenant.get(\u0027domain_id\u0027):"},{"line_number":99,"context_line":"                    raise exception.ValidationError("},{"line_number":100,"context_line":"                        message\u003d_(\u0027cannot create a project within a different \u0027"},{"line_number":101,"context_line":"                                  \u0027domain than its parents.\u0027))"},{"line_number":102,"context_line":"                if not ref.get(\u0027enabled\u0027, True):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_88184220","line":99,"in_reply_to":"ba3cc151_39706edc","updated":"2015-07-10 13:42:43.000000000","message":"Nice! David, thanks for the reference,  I need bury myself to read the whole RFC.","commit_id":"265a836f5efdc8684c0f46a8608247231ab639a8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"68f55091da7f78ff9f421721cf5588b2cb672999","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            parents_list.append(parent_ref)"},{"line_number":97,"context_line":"            for ref in parents_list:"},{"line_number":98,"context_line":"                if ref.get(\u0027domain_id\u0027) !\u003d tenant.get(\u0027domain_id\u0027):"},{"line_number":99,"context_line":"                    raise exception.ValidationError("},{"line_number":100,"context_line":"                        message\u003d_(\u0027cannot create a project within a different \u0027"},{"line_number":101,"context_line":"                                  \u0027domain than its parents.\u0027))"},{"line_number":102,"context_line":"                if not ref.get(\u0027enabled\u0027, True):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_39706edc","line":99,"in_reply_to":"ba3cc151_6cf7205a","updated":"2015-07-10 12:24:46.000000000","message":"Forbidden means that we are denying access to a resource due to credentials or auth issues. This is definitely not the case here. See https://tools.ietf.org/html/rfc7231#section-6.5.3","commit_id":"265a836f5efdc8684c0f46a8608247231ab639a8"}]}