)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1100d69924cea74b9ac4f8bdfe7e8456364dec8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave Chen \u003cwei.d.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-15 11:37:05 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Region creation with id given also need schema validation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the schema validation expects the resource to be validated is"},{"line_number":10,"context_line":"passed by dict, we need pass reqeust body region as dict accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a41bdd9_fcd565e4","line":7,"updated":"2015-07-15 15:34:31.000000000","message":"(nit) i think that this is too long","commit_id":"c7d5b9d58eb84e61dcc95bcdbe0055dc406cedf5"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f246692f80a177d39c6503ac33c5705e4525d8e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave Chen \u003cwei.d.chen@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-15 11:37:05 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Region creation with id given also need schema validation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the schema validation expects the resource to be validated is"},{"line_number":10,"context_line":"passed by dict, we need pass reqeust body region as dict accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a41bdd9_654f5934","line":7,"in_reply_to":"9a41bdd9_fcd565e4","updated":"2015-07-16 08:11:20.000000000","message":"sorry, I miss this in the latest PS, total characters is 58, it is not so bad :).\n\nI will update the title if another patch is needed, thanks.","commit_id":"c7d5b9d58eb84e61dcc95bcdbe0055dc406cedf5"}],"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"1100d69924cea74b9ac4f8bdfe7e8456364dec8f","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        request_to_validate \u003d {\u0027other_attr\u0027: uuid.uuid4().hex}"},{"line_number":853,"context_line":"        self.create_region_validator.validate(request_to_validate)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def test_validate_region_create_with_id_fails_with_invalid_value(self):"},{"line_number":856,"context_line":"        \"\"\"Validate create region with invalid values.\"\"\""},{"line_number":857,"context_line":"        self.controller \u003d catalog.controllers.RegionV3()"},{"line_number":858,"context_line":"        request_to_validate \u003d {\u0027id\u0027: 12345,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_9cb9b9ce","line":855,"updated":"2015-07-15 15:34:31.000000000","message":"This test is broken because the base class of this test doesn\u0027t setup the DI needed for it to run. I think you should create a new test class that inherits from a class that has the correct setUp code.","commit_id":"c7d5b9d58eb84e61dcc95bcdbe0055dc406cedf5"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"f246692f80a177d39c6503ac33c5705e4525d8e2","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        request_to_validate \u003d {\u0027other_attr\u0027: uuid.uuid4().hex}"},{"line_number":853,"context_line":"        self.create_region_validator.validate(request_to_validate)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    def test_validate_region_create_with_id_fails_with_invalid_value(self):"},{"line_number":856,"context_line":"        \"\"\"Validate create region with invalid values.\"\"\""},{"line_number":857,"context_line":"        self.controller \u003d catalog.controllers.RegionV3()"},{"line_number":858,"context_line":"        request_to_validate \u003d {\u0027id\u0027: 12345,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_658af965","line":855,"in_reply_to":"9a41bdd9_9cb9b9ce","updated":"2015-07-16 08:11:20.000000000","message":"Done","commit_id":"c7d5b9d58eb84e61dcc95bcdbe0055dc406cedf5"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ade3d96d1e5b38684d730caa78c68f595635508d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    def test_create_entity_with_id_as_argument(self):"},{"line_number":263,"context_line":"        \"\"\"Exception raised when passing with a invalid reference data."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        This test mimic the case when the API is invoked by another function"},{"line_number":266,"context_line":"        with \u0027id\u0027 as the input argument, such as"},{"line_number":267,"context_line":"        `keystone.catalog.controllers.RegionV3.create_region_with_id`."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_15bc76b9","line":265,"updated":"2015-07-16 09:55:03.000000000","message":"nit: s/mimic/mimics/","commit_id":"740c75c61271ca0e7f6353967ba1282512493d66"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"108a843f3a9630fd299bba9a8e72c1685f2c017e","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    def test_create_entity_with_id_as_argument(self):"},{"line_number":263,"context_line":"        \"\"\"Exception raised when passing with a invalid reference data."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        This test mimic the case when the API is invoked by another function"},{"line_number":266,"context_line":"        with \u0027id\u0027 as the input argument, such as"},{"line_number":267,"context_line":"        `keystone.catalog.controllers.RegionV3.create_region_with_id`."},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_7e3d9a29","line":265,"in_reply_to":"9a41bdd9_15bc76b9","updated":"2015-07-16 12:26:30.000000000","message":"Done","commit_id":"740c75c61271ca0e7f6353967ba1282512493d66"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"ade3d96d1e5b38684d730caa78c68f595635508d","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # TODO(davechen) Currently, the validation fetch the resource to be"},{"line_number":275,"context_line":"        # validated from the python dictionary instead of the positional"},{"line_number":276,"context_line":"        # argument, validation should change the logic to fetch the resource"},{"line_number":277,"context_line":"        # more wisely."},{"line_number":278,"context_line":"        # test the invalid email value"},{"line_number":279,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name,"},{"line_number":280,"context_line":"                               \u0027email\u0027: \u0027some invalid email value\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_95ae462c","line":277,"updated":"2015-07-16 09:55:03.000000000","message":"it set of feel like this comment is a repetition of the paragraph in the docstring above (or is that different?).  If it is a duplicate, and you plan to fix this problem with the TODO, then I would say it should not be duplicated in the doctoring (so that when you fix it, just the TODO goes away).","commit_id":"740c75c61271ca0e7f6353967ba1282512493d66"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"108a843f3a9630fd299bba9a8e72c1685f2c017e","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # TODO(davechen) Currently, the validation fetch the resource to be"},{"line_number":275,"context_line":"        # validated from the python dictionary instead of the positional"},{"line_number":276,"context_line":"        # argument, validation should change the logic to fetch the resource"},{"line_number":277,"context_line":"        # more wisely."},{"line_number":278,"context_line":"        # test the invalid email value"},{"line_number":279,"context_line":"        request_to_validate \u003d {\u0027name\u0027: self.resource_name,"},{"line_number":280,"context_line":"                               \u0027email\u0027: \u0027some invalid email value\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_1e480ecb","line":277,"in_reply_to":"9a41bdd9_95ae462c","updated":"2015-07-16 12:26:30.000000000","message":"Done","commit_id":"740c75c61271ca0e7f6353967ba1282512493d66"}]}