)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a0fa7748081debfd204ee9d475e081cb87ac2c82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Boris Bobrov \u003cbbobrov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-14 19:03:37 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove excess transformation to list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The transformation to list is already performed in the function where"},{"line_number":10,"context_line":"callbacks are passed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_102adfe7","line":7,"updated":"2015-07-31 14:47:13.000000000","message":"(nit) excessive may sound better","commit_id":"4ae0509db2ad989c429e55ec42243fbdc113bc1a"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"9ce7ef78309d7fa91959384408f669b9018b2765","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Boris Bobrov \u003cbbobrov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-14 19:03:37 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove excess transformation to list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The transformation to list is already performed in the function where"},{"line_number":10,"context_line":"callbacks are passed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_0e18e5d1","line":7,"in_reply_to":"3a50d1a3_102adfe7","updated":"2015-08-07 14:39:32.000000000","message":"Done","commit_id":"4ae0509db2ad989c429e55ec42243fbdc113bc1a"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e85b7934f164b664665692b46924373d1d8d4b17","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove excess transformation to list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The transformation to list is already performed in the function where"},{"line_number":10,"context_line":"callbacks are passed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I92d1a8be99e2c753bece0b22ab1d64d547247083"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_36babce2","line":10,"updated":"2015-08-03 19:51:29.000000000","message":"what function?","commit_id":"4ae0509db2ad989c429e55ec42243fbdc113bc1a"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"9ce7ef78309d7fa91959384408f669b9018b2765","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove excess transformation to list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The transformation to list is already performed in the function where"},{"line_number":10,"context_line":"callbacks are passed."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I92d1a8be99e2c753bece0b22ab1d64d547247083"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_6e2969e5","line":10,"in_reply_to":"1a4dcd0f_36babce2","updated":"2015-08-07 14:39:32.000000000","message":"Done","commit_id":"4ae0509db2ad989c429e55ec42243fbdc113bc1a"}],"keystone/notifications.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e85b7934f164b664665692b46924373d1d8d4b17","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            event_callbacks \u003d {"},{"line_number":314,"context_line":"                notifications.ACTIONS.created: {"},{"line_number":315,"context_line":"                    \u0027user\u0027: self._user_created_callback,"},{"line_number":316,"context_line":"                },"},{"line_number":317,"context_line":"                notifications.ACTIONS.deleted: {"},{"line_number":318,"context_line":"                    \u0027project\u0027: ["},{"line_number":319,"context_line":"                        self._project_deleted_callback,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_76f124cd","side":"PARENT","line":316,"updated":"2015-08-03 19:51:29.000000000","message":"won\u0027t this example fail now?","commit_id":"95a4689073bc6e10c616cceb46c4e8e78b8d96a6"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"2a14d371631c32cbe45a4b341943a963e4e51389","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            event_callbacks \u003d {"},{"line_number":314,"context_line":"                notifications.ACTIONS.created: {"},{"line_number":315,"context_line":"                    \u0027user\u0027: self._user_created_callback,"},{"line_number":316,"context_line":"                },"},{"line_number":317,"context_line":"                notifications.ACTIONS.deleted: {"},{"line_number":318,"context_line":"                    \u0027project\u0027: ["},{"line_number":319,"context_line":"                        self._project_deleted_callback,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8e24f50c","side":"PARENT","line":316,"in_reply_to":"1a4dcd0f_76f124cd","updated":"2015-08-07 14:39:28.000000000","message":"No, because _register_event_callbacks will call register_event_callback where this list wrapping happens again. I\u0027ve added tests here: https://review.openstack.org/#/c/210476/\n\nI just noticed that the docstring has an error so I fixed that here: https://review.openstack.org/210477","commit_id":"95a4689073bc6e10c616cceb46c4e8e78b8d96a6"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"9ce7ef78309d7fa91959384408f669b9018b2765","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            event_callbacks \u003d {"},{"line_number":314,"context_line":"                notifications.ACTIONS.created: {"},{"line_number":315,"context_line":"                    \u0027user\u0027: self._user_created_callback,"},{"line_number":316,"context_line":"                },"},{"line_number":317,"context_line":"                notifications.ACTIONS.deleted: {"},{"line_number":318,"context_line":"                    \u0027project\u0027: ["},{"line_number":319,"context_line":"                        self._project_deleted_callback,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8e6b951d","side":"PARENT","line":316,"in_reply_to":"1a4dcd0f_76f124cd","updated":"2015-08-07 14:39:32.000000000","message":"nope, it won\u0027t","commit_id":"95a4689073bc6e10c616cceb46c4e8e78b8d96a6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"437bc7430cb45bf399665618706b2de614656410","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                # Make sure we register the provider for each event it"},{"line_number":339,"context_line":"                # cares to call back."},{"line_number":340,"context_line":"                if not callbacks:"},{"line_number":341,"context_line":"                    continue"},{"line_number":342,"context_line":"                register_event_callback(event, resource_type, callbacks)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    cls.__init__ \u003d init_wrapper(cls.__init__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_b539f0f4","line":341,"updated":"2015-08-07 19:58:31.000000000","message":"seems like we could just as well raise an exception since why would there be no callbacks.","commit_id":"465f092a75c9067426656c0ce202bb05585e7359"}]}
