)]}'
{"keystone/service.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"cd3eace0265db8db5888869a75180ee50ef2b535","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import logging"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import versionutils"},{"line_number":18,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_38710b45","line":15,"updated":"2015-07-18 00:52:05.000000000","message":"This is not needed any more. If I miss something and it is needed, it should be oslo_log.","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7fa19cdf309faa45b76ac1a400ede0e612ad891e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import logging"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import versionutils"},{"line_number":18,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_4b46d1c0","line":15,"in_reply_to":"9a41bdd9_38710b45","updated":"2015-07-19 06:47:09.000000000","message":"Done","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"cd3eace0265db8db5888869a75180ee50ef2b535","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystone.version import service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def deprecated_to_version(f):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_7877933b","line":23,"updated":"2015-07-18 00:52:05.000000000","message":"This is not needed any more.","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7fa19cdf309faa45b76ac1a400ede0e612ad891e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystone.version import service"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def deprecated_to_version(f):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_eb11ddb0","line":23,"in_reply_to":"9a41bdd9_7877933b","updated":"2015-07-19 06:47:09.000000000","message":"Done","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"cd3eace0265db8db5888869a75180ee50ef2b535","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    @six.wraps(f)"},{"line_number":34,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":35,"context_line":"        x \u003d versionutils.deprecated("},{"line_number":36,"context_line":"            what\u003d\u0027keystone.service.\u0027 + f.__name__ + \u0027()\u0027,"},{"line_number":37,"context_line":"            as_of\u003dversionutils.deprecated.LIBERTY,"},{"line_number":38,"context_line":"            in_favor_of\u003d\u0027keystone.version.service.\u0027 + f.__name__ + \u0027()\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_d8049fc7","line":35,"updated":"2015-07-18 00:52:05.000000000","message":"remove_in should be added. I suggest remove_in\u003d+2.","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7fa19cdf309faa45b76ac1a400ede0e612ad891e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    @six.wraps(f)"},{"line_number":34,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":35,"context_line":"        x \u003d versionutils.deprecated("},{"line_number":36,"context_line":"            what\u003d\u0027keystone.service.\u0027 + f.__name__ + \u0027()\u0027,"},{"line_number":37,"context_line":"            as_of\u003dversionutils.deprecated.LIBERTY,"},{"line_number":38,"context_line":"            in_favor_of\u003d\u0027keystone.version.service.\u0027 + f.__name__ + \u0027()\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_0b1769a4","line":35,"in_reply_to":"9a41bdd9_d8049fc7","updated":"2015-07-19 06:47:09.000000000","message":"Done","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cfe4d47758446196bf72f07a83219ea8159c6940","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from keystone.version import service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def deprecated_to_version(f):"},{"line_number":22,"context_line":"    \"\"\"Specialized deprecation wrapper for service module."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    This wraps the standard deprecation wrapper and fills in the method"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_59aea7e8","line":21,"updated":"2015-10-11 17:11:11.000000000","message":"this reads like \"deprecating to what version?\". But since I think this will only be read by developers of Keystone, I don\u0027t think it\u0027s that big of a deal. \n\nCan\u0027t we use the in favor of code that dstanek wrote to do this too?","commit_id":"3e68f2b3605459448b88ae5886cd3bcc9988aeaf"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"07030666ef190771d39fa479efb3dba990046911","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from keystone.version import service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def deprecated_to_version(f):"},{"line_number":22,"context_line":"    \"\"\"Specialized deprecation wrapper for service module."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    This wraps the standard deprecation wrapper and fills in the method"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_5c1f7509","line":21,"in_reply_to":"7a2fa921_59aea7e8","updated":"2015-10-11 21:48:08.000000000","message":"hmm? it does call versionutils.deprecated at line 30, i think that\u0027s the bit that dstanek wrote","commit_id":"3e68f2b3605459448b88ae5886cd3bcc9988aeaf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ea5a4d596bb3255c053e556cdd9c8de2049362","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from keystone.version import service"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def deprecated_to_version(f):"},{"line_number":22,"context_line":"    \"\"\"Specialized deprecation wrapper for service module."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    This wraps the standard deprecation wrapper and fills in the method"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_de5607ce","line":21,"in_reply_to":"7a2fa921_5c1f7509","updated":"2015-10-12 14:15:20.000000000","message":"ah, you\u0027re right... \n\nnever mind!","commit_id":"3e68f2b3605459448b88ae5886cd3bcc9988aeaf"}],"keystone/version/service.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"cd3eace0265db8db5888869a75180ee50ef2b535","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return wsgi.ComposingRouter(routes.Mapper(),"},{"line_number":80,"context_line":"                                [identity.routers.Admin(),"},{"line_number":81,"context_line":"                                 assignment.routers.Admin(),"},{"line_number":82,"context_line":"                                    token.routers.Router(),"},{"line_number":83,"context_line":"                                    resource.routers.Admin(),"},{"line_number":84,"context_line":"                                    routers.VersionV2(\u0027admin\u0027),"},{"line_number":85,"context_line":"                                    routers.Extension()])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_98c937af","line":82,"updated":"2015-07-18 00:52:05.000000000","message":"padding should be fixed","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7fa19cdf309faa45b76ac1a400ede0e612ad891e","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    return wsgi.ComposingRouter(routes.Mapper(),"},{"line_number":80,"context_line":"                                [identity.routers.Admin(),"},{"line_number":81,"context_line":"                                 assignment.routers.Admin(),"},{"line_number":82,"context_line":"                                    token.routers.Router(),"},{"line_number":83,"context_line":"                                    resource.routers.Admin(),"},{"line_number":84,"context_line":"                                    routers.VersionV2(\u0027admin\u0027),"},{"line_number":85,"context_line":"                                    routers.Extension()])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_ab0bd57c","line":82,"in_reply_to":"9a41bdd9_98c937af","updated":"2015-07-19 06:47:09.000000000","message":"Done","commit_id":"03d9e4d63868d1eca561dade6db4d7c841e27e57"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cfe4d47758446196bf72f07a83219ea8159c6940","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_79ab63d7","line":1,"updated":"2015-10-11 17:11:11.000000000","message":"remove copyright?","commit_id":"3e68f2b3605459448b88ae5886cd3bcc9988aeaf"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"07030666ef190771d39fa479efb3dba990046911","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_fc2f613c","line":1,"in_reply_to":"7a2fa921_79ab63d7","updated":"2015-10-11 21:48:08.000000000","message":"it\u0027s pretty much a copy of keystone/service.py so i think we maintain the copyright","commit_id":"3e68f2b3605459448b88ae5886cd3bcc9988aeaf"}]}