)]}'
{"bin/keystone-all":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0b9fe9e8f49cac8129ab9602af07171143ed8161","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        paste_config \u003d CONF.config_file[0]"},{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        paste_config \u003d CONF.find_file(\u0027keystone.conf\u0027)"},{"line_number":92,"context_line":"        if not paste_config:"},{"line_number":93,"context_line":"            print \"No config files could be found.\""},{"line_number":94,"context_line":"            CONF.print_help()"},{"line_number":95,"context_line":"            sys.exit(1)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FLB8%3D","line":92,"updated":"2013-02-04 21:45:58.000000000","message":"Would it be better to move this check outside the if / else? (so would also check if not paste_config if CONF.config_file.) Maybe CONF.config_file[0] could be falsy. The code didn\u0027t check for it before, but would at least have less code in this else clause.","commit_id":"c669a6c583cdd4dd746fea6fc2c56ae4e7bf82c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5e5f715b0ca5c8255ee8d361bfb48bc0b68c6fe7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        paste_config \u003d CONF.config_file[0]"},{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        paste_config \u003d CONF.find_file(\u0027keystone.conf\u0027)"},{"line_number":92,"context_line":"        if not paste_config:"},{"line_number":93,"context_line":"            print \"No config files could be found.\""},{"line_number":94,"context_line":"            CONF.print_help()"},{"line_number":95,"context_line":"            sys.exit(1)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FK8U%3D","line":92,"in_reply_to":"AAAAM3%2F%2FLB8%3D","updated":"2013-02-04 22:32:55.000000000","message":"i don\u0027t believe moving the \u0027if not paste_config\u0027 check outside the if / else makes a difference given the simplicity of the check.  it doesn\u0027t check the validity of paste_config but rather if any value exists.","commit_id":"c669a6c583cdd4dd746fea6fc2c56ae4e7bf82c6"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0b9fe9e8f49cac8129ab9602af07171143ed8161","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        paste_config \u003d CONF.find_file(\u0027keystone.conf\u0027)"},{"line_number":92,"context_line":"        if not paste_config:"},{"line_number":93,"context_line":"            print \"No config files could be found.\""},{"line_number":94,"context_line":"            CONF.print_help()"},{"line_number":95,"context_line":"            sys.exit(1)"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FLCM%3D","line":93,"updated":"2013-02-04 21:45:58.000000000","message":"(nit) could we print out a more useful error message? like, \u0027The keystone.conf file could not be found in the configuration directories.\u0027","commit_id":"c669a6c583cdd4dd746fea6fc2c56ae4e7bf82c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5e5f715b0ca5c8255ee8d361bfb48bc0b68c6fe7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        paste_config \u003d CONF.find_file(\u0027keystone.conf\u0027)"},{"line_number":92,"context_line":"        if not paste_config:"},{"line_number":93,"context_line":"            print \"No config files could be found.\""},{"line_number":94,"context_line":"            CONF.print_help()"},{"line_number":95,"context_line":"            sys.exit(1)"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FK7k%3D","line":93,"in_reply_to":"AAAAM3%2F%2FLCM%3D","updated":"2013-02-04 22:32:55.000000000","message":"will update with more useful error message.","commit_id":"c669a6c583cdd4dd746fea6fc2c56ae4e7bf82c6"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"107fb7edb8836fafe411f67e0c50a7baf32081de","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        paste_config \u003d CONF.find_file(\u0027keystone.conf\u0027)"},{"line_number":92,"context_line":"        if not paste_config:"},{"line_number":93,"context_line":"            print \"The keystone.conf file could not be found in the \" \\"},{"line_number":94,"context_line":"                  \"configuration directories.\""},{"line_number":95,"context_line":"            CONF.print_help()"},{"line_number":96,"context_line":"            sys.exit(1)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FKkg%3D","line":93,"updated":"2013-02-05 03:22:58.000000000","message":"From HACKING:\n\n  Long lines should be wrapped in parentheses in preference to using a backslash for line continuation.\n\nhttps://github.com/openstack/keystone/blob/master/HACKING.rst#general","commit_id":"8c83a8eb1c6d6eccca9ba033045aaccdec5d26ff"}]}