)]}'
{"id":"openstack%2Fkeystone~20518","triplet_id":"openstack%2Fkeystone~master~I1b7af9b9225fa06a9404d0a54cd1ef7b6e5cda80","project":"openstack/keystone","branch":"master","topic":"ldap_password_change","hashtags":[],"change_id":"I1b7af9b9225fa06a9404d0a54cd1ef7b6e5cda80","subject":"Fix bugs with set ldap password.","status":"MERGED","created":"2013-01-25 20:00:31.000000000","updated":"2013-02-16 06:18:14.000000000","submitted":"2013-02-16 06:18:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c601c7bb023e27a67cbd4a98b988c950db364361","_number":20518,"virtual_id_number":20518,"owner":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":1,"date":"2013-01-28 21:47:43.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2013-02-16 06:18:14.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"recommended":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"all":[{"value":0,"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"value":1,"date":"2013-02-14 16:06:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":2,"date":"2013-02-15 20:30:26.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":1,"date":"2013-02-08 18:37:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":1,"date":"2013-02-11 16:47:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-02-13 20:08:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"date":"2013-01-28 21:23:37.000000000","_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":1,"date":"2013-02-15 20:30:26.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"date":"2013-02-08 18:37:02.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-28 21:47:43.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-02-08 18:37:02.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-02-11 16:47:43.000000000","updated_by":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"reviewer":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"state":"REVIEWER"},{"updated":"2013-02-13 20:08:53.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2013-02-14 16:06:48.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2013-02-15 20:30:26.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-02-16 06:18:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"717d1ed3b1da2bbb28e5edb4e120531da7561918","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-25 20:20:26.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20518/1/check/gate-keystone-docs/1585 : SUCCESS\n- http://logs.openstack.org/20518/1/check/gate-keystone-pep8/3101 : SUCCESS\n- http://logs.openstack.org/20518/1/check/gate-keystone-python26/2126 : SUCCESS\n- http://logs.openstack.org/20518/1/check/gate-keystone-python27/2129 : SUCCESS\n- http://logs.openstack.org/20518/1/check/gate-tempest-devstack-vm/28347 : SUCCESS\n- http://logs.openstack.org/20518/1/check/gate-tempest-devstack-vm-quantum/2865 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"699544f00b03246be837fbb8b4d41ee0f741342f","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-25 20:25:22.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/67207\n","accounts_in_message":[],"_revision_number":1},{"id":"104d90f6d4d58a49ab22bea0778372b586dcb469","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-28 20:36:37.000000000","message":"Patch Set 1:\n\n\"bugs\"? are they documented? can you elaborate? can you add tests to illustrate and prevent a regression?\n\nthe first fix is kind of obvious, but i don\u0027t know what you\u0027re addressing in the second change.","accounts_in_message":[],"_revision_number":1},{"id":"d6850a0e3a3a008a2ede559442f3ea1721ab1ff5","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-01-28 20:36:41.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n^","accounts_in_message":[],"_revision_number":1},{"id":"dd0477a0b1c59cb20acf06f50503abe065d4b433","author":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"date":"2013-01-28 21:23:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"579c06489585820644b654e7d92a5d5f888e9221","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-01-28 21:23:44.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"6baa929cb358887df2d3da3516b1b94f80a3bdf8","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-28 21:47:43.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/67627\n","accounts_in_message":[],"_revision_number":2},{"id":"077f2df3938f50081a448fc02d9cd69f3e1010b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-28 22:03:46.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20518/2/check/gate-keystone-docs/1603 : SUCCESS\n- http://logs.openstack.org/20518/2/check/gate-keystone-pep8/3119 : SUCCESS\n- http://logs.openstack.org/20518/2/check/gate-keystone-python26/2144 : SUCCESS\n- http://logs.openstack.org/20518/2/check/gate-keystone-python27/2147 : SUCCESS\n- http://logs.openstack.org/20518/2/check/gate-tempest-devstack-vm/28526 : SUCCESS\n- http://logs.openstack.org/20518/2/check/gate-tempest-devstack-vm-quantum/3099 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"50bc8448d22b7a5f0e6d4953e72feea7bfad6af4","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2013-02-07 21:15:17.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nupdate_user in kvs and sql implementations return the updated user info so this fix aligns ldap with the other two.  i\u0027m assuming user value is returned as verification.\n\ni can modify my own user_crud test case to check for a return value.","accounts_in_message":[],"_revision_number":2},{"id":"533f799df5a05180dba9204abe5ada7ec84b13aa","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2013-02-08 15:09:40.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nsimilar \u0027return bug\u0027 fix with broader scope has been submitted (https://review.openstack.org/#/c/21320/). may be better to just fix the initial name check issue.","accounts_in_message":[],"_revision_number":2},{"id":"85f1d09cc98245cf59fb0ba57fa475580b425eec","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-02-08 18:37:02.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nas for the conflicting portion of these two fixes, i prefer the \u0027return self.get(id) \u0027 here a bit more.","accounts_in_message":[],"_revision_number":2},{"id":"8fb71c67a429ad2e8675b4e3536b779b22872428","author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"date":"2013-02-11 16:47:43.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"cc0ae6103bf69a361195bf4c1d9d1e5c017136ad","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2013-02-13 20:08:53.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fd3f6856a4cf1f0a00ac1de4e9965908afcd13e8","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2013-02-13 20:46:58.000000000","message":"Patch Set 2:\n\nagreed, this is a better response but the other fix offers a more complete solution. can we create a link between the two using this response with (https://review.openstack.org/#/c/21320/)\u0027s coverage","accounts_in_message":[],"_revision_number":2},{"id":"7e458ba7882dd5b559ba552a07f21f0f03198150","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-02-14 15:39:17.000000000","message":"Patch Set 2:\n\nGordon: which way would you suggest the review dependency go? rebase this change on top of jose\u0027s, or have jose base in change on this one, and avoid touching the return statement written here?","accounts_in_message":[],"_revision_number":2},{"id":"345edf8fe00668b2de06c8e129c9c167ae7a0dab","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2013-02-14 16:06:48.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nprobably best to base jose\u0027s change on this now that i think about it. jose\u0027s test cases may fail if this change gets applied fully (to groups, roles, etc..)","accounts_in_message":[],"_revision_number":2},{"id":"da13da0e5caa91611e5da8643af508b78542eb4c","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-02-15 20:30:26.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nOk, lets get the merge started on this, and Jose can rebase","accounts_in_message":[],"_revision_number":2},{"id":"831d2656055d2275cb3de52a72303063f145d442","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-15 20:30:34.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ca0d34e6e769c58fb321ec70bd8705c42f2a9953","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-16 06:18:14.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/20518/2/gate/gate-keystone-docs/1892 : SUCCESS\n- http://logs.openstack.org/20518/2/gate/gate-keystone-pep8/3419 : SUCCESS\n- http://logs.openstack.org/20518/2/gate/gate-keystone-python26/2424 : SUCCESS\n- http://logs.openstack.org/20518/2/gate/gate-keystone-python27/2432 : SUCCESS\n- http://logs.openstack.org/20518/2/gate/gate-tempest-devstack-vm-full/3235 : SUCCESS\n- http://logs.openstack.org/20518/2/gate/gate-tempest-devstack-vm-postgres-full/2959 : SUCCESS\n- http://logs.openstack.org/20518/2/gate/gate-tempest-devstack-vm-quantum/7543 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"2a9e814d16a1a6dfb0c90767c0c6534f80a8ad26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-16 06:18:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"34d0eb3d7399fcc8b511bfb0467f38b5bdae31b0","revisions":{"3b09d2274bf0997be91a0df442a481ee440bfc23":{"kind":"REWORK","_number":1,"created":"2013-01-25 20:00:31.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/18/20518/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/18/20518/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/18/20518/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/18/20518/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/18/20518/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/18/20518/1"}}},"commit":{"parents":[{"commit":"dd357475fbc10d7fb823fe116293c553cfe32733","subject":"Fix pep8 error.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/dd357475fbc10d7fb823fe116293c553cfe32733"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2013-01-23 02:47:59.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2013-01-25 19:59:55.000000000","tz":0},"subject":"Fix bugs with set ldap password.","message":"Fix bugs with set ldap password.\n\nChange-Id: I1b7af9b9225fa06a9404d0a54cd1ef7b6e5cda80\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/3b09d2274bf0997be91a0df442a481ee440bfc23"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/3b09d2274bf0997be91a0df442a481ee440bfc23"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"dd357475fbc10d7fb823fe116293c553cfe32733","is_merged_in_target_branch":true,"change_id":"I91525475e17898d8096d934e3f9a21adc74cfff9","change_number":20442,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"34d0eb3d7399fcc8b511bfb0467f38b5bdae31b0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-01-28 21:23:37.000000000","uploader":{"_account_id":396,"name":"Mandell","email":"mdegerness@nvidia.com","username":"mdegerne"},"ref":"refs/changes/18/20518/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/18/20518/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/18/20518/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/18/20518/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/18/20518/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/18/20518/2"}}},"commit":{"parents":[{"commit":"dd357475fbc10d7fb823fe116293c553cfe32733","subject":"Fix pep8 error.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/dd357475fbc10d7fb823fe116293c553cfe32733"}]}],"author":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2013-01-23 02:47:59.000000000","tz":0},"committer":{"name":"Mandell Degerness","email":"mdegerne@gmail.com","date":"2013-01-28 21:20:48.000000000","tz":0},"subject":"Fix bugs with set ldap password.","message":"Fix bugs with set ldap password.\n\nThere is no check that \u0027name\u0027 exists in the keys.\n\nClient update password call expects update_user to return the new user\nas do the kvs and sql back ends.\n\nChange-Id: I1b7af9b9225fa06a9404d0a54cd1ef7b6e5cda80\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/34d0eb3d7399fcc8b511bfb0467f38b5bdae31b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/34d0eb3d7399fcc8b511bfb0467f38b5bdae31b0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"dd357475fbc10d7fb823fe116293c553cfe32733","is_merged_in_target_branch":true,"change_id":"I91525475e17898d8096d934e3f9a21adc74cfff9","change_number":20442,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}