)]}'
{"keystone/tests/unit/test_versions.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"72bac1e603f305d01ca072cce77b86ef361059c4","unresolved":false,"context_lines":[{"line_number":976,"context_line":"    def test_public(self):"},{"line_number":977,"context_line":"        self._test_version(\u0027main\u0027)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    @utils.wip(\u0027waiting on bug #1381961\u0027)"},{"line_number":980,"context_line":"    def test_admin(self):"},{"line_number":981,"context_line":"        self._test_version(\u0027admin\u0027)"},{"line_number":982,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_9c1c7667","side":"PARENT","line":979,"updated":"2015-07-28 15:19:41.000000000","message":"if you\u0027re removing this, then i\u0027d assume that this patch should also be Closes-Bug: 1381961","commit_id":"37b81c95ed5b02ca98001430f26d457d1077693a"},{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"b471bfa9714df8ca72f979321337c13f35f616be","unresolved":false,"context_lines":[{"line_number":976,"context_line":"    def test_public(self):"},{"line_number":977,"context_line":"        self._test_version(\u0027main\u0027)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    @utils.wip(\u0027waiting on bug #1381961\u0027)"},{"line_number":980,"context_line":"    def test_admin(self):"},{"line_number":981,"context_line":"        self._test_version(\u0027admin\u0027)"},{"line_number":982,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_3f53ca18","side":"PARENT","line":979,"in_reply_to":"3a50d1a3_9c1c7667","updated":"2015-07-28 18:48:40.000000000","message":"My initial intention was to fix this as part of #1381961 but I realized that this is a separate bug. I can change this in a parent fix if it\u0027s a better move.","commit_id":"37b81c95ed5b02ca98001430f26d457d1077693a"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"dcd1b49a57782bf8b40b790a4f2842e0e20aa699","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    def _test_version(self, app_name):"},{"line_number":959,"context_line":"        app \u003d self.loadapp(\u0027keystone\u0027, app_name)"},{"line_number":960,"context_line":"        port \u003d (CONF.eventlet_server.admin_port if app_name \u003d\u003d \u0027admin\u0027"},{"line_number":961,"context_line":"                else CONF.eventlet_server.public_port)"},{"line_number":962,"context_line":"        client \u003d tests.TestClient(app)"},{"line_number":963,"context_line":"        resp \u003d client.get(\u0027/\u0027)"},{"line_number":964,"context_line":"        self.assertEqual(300, resp.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_e16059d1","line":961,"updated":"2015-07-29 02:31:33.000000000","message":"just pass in the port.","commit_id":"785e686b03a6761cda8e997ea5d52b41e651c2eb"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"df1dda54e717a022a1c4e09766e701850de4e2ab","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    def _test_version(self, app_name):"},{"line_number":959,"context_line":"        app \u003d self.loadapp(\u0027keystone\u0027, app_name)"},{"line_number":960,"context_line":"        port \u003d (CONF.eventlet_server.admin_port if app_name \u003d\u003d \u0027admin\u0027"},{"line_number":961,"context_line":"                else CONF.eventlet_server.public_port)"},{"line_number":962,"context_line":"        client \u003d tests.TestClient(app)"},{"line_number":963,"context_line":"        resp \u003d client.get(\u0027/\u0027)"},{"line_number":964,"context_line":"        self.assertEqual(300, resp.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_01500131","line":961,"updated":"2015-07-28 15:18:43.000000000","message":"ternaries are hard to read once they break onto two or more lines -- this would be more readable with traditional if-blocks","commit_id":"785e686b03a6761cda8e997ea5d52b41e651c2eb"},{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"26df4d2a580bf2c37d9fe59eca25e3c8193fd80c","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    def _test_version(self, app_name):"},{"line_number":959,"context_line":"        app \u003d self.loadapp(\u0027keystone\u0027, app_name)"},{"line_number":960,"context_line":"        port \u003d (CONF.eventlet_server.admin_port if app_name \u003d\u003d \u0027admin\u0027"},{"line_number":961,"context_line":"                else CONF.eventlet_server.public_port)"},{"line_number":962,"context_line":"        client \u003d tests.TestClient(app)"},{"line_number":963,"context_line":"        resp \u003d client.get(\u0027/\u0027)"},{"line_number":964,"context_line":"        self.assertEqual(300, resp.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ff42420e","line":961,"in_reply_to":"3a50d1a3_01500131","updated":"2015-07-28 18:53:50.000000000","message":"Agree, but different options are even more unreadable or sower (2 assignments). Would you suggest a better option? I\u0027d happy to use it. Also as a LISP guy I\u0027m quite happy with additional () :)","commit_id":"785e686b03a6761cda8e997ea5d52b41e651c2eb"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2568fdb61725c7e53873fd80ea2cd0c500e0507e","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    def _test_version(self, app_name):"},{"line_number":959,"context_line":"        app \u003d self.loadapp(\u0027keystone\u0027, app_name)"},{"line_number":960,"context_line":"        port \u003d (CONF.eventlet_server.admin_port if app_name \u003d\u003d \u0027admin\u0027"},{"line_number":961,"context_line":"                else CONF.eventlet_server.public_port)"},{"line_number":962,"context_line":"        client \u003d tests.TestClient(app)"},{"line_number":963,"context_line":"        resp \u003d client.get(\u0027/\u0027)"},{"line_number":964,"context_line":"        self.assertEqual(300, resp.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_a99c4f0e","line":961,"in_reply_to":"3a50d1a3_9f3205f1","updated":"2015-07-29 18:42:06.000000000","message":"the abstraction is already leaky. If you wanted a better abstraction then create a class that has both app_name and port in it.","commit_id":"785e686b03a6761cda8e997ea5d52b41e651c2eb"},{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"d4c5200f72dbc581210eb3f19b0c34186a9f9ee1","unresolved":false,"context_lines":[{"line_number":958,"context_line":"    def _test_version(self, app_name):"},{"line_number":959,"context_line":"        app \u003d self.loadapp(\u0027keystone\u0027, app_name)"},{"line_number":960,"context_line":"        port \u003d (CONF.eventlet_server.admin_port if app_name \u003d\u003d \u0027admin\u0027"},{"line_number":961,"context_line":"                else CONF.eventlet_server.public_port)"},{"line_number":962,"context_line":"        client \u003d tests.TestClient(app)"},{"line_number":963,"context_line":"        resp \u003d client.get(\u0027/\u0027)"},{"line_number":964,"context_line":"        self.assertEqual(300, resp.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_9f3205f1","line":961,"in_reply_to":"3a50d1a3_e16059d1","updated":"2015-07-29 07:13:13.000000000","message":"As a parameter? Not sure, port is a function of app_name, so it would be a leaky abstraction.","commit_id":"785e686b03a6761cda8e997ea5d52b41e651c2eb"}]}