)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"8ddf5a45436dda81de3de24e2c8af8326b8ae53a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brant Knudson \u003cbknudson@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-29 16:29:42 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Config option for insecure reponses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.log\u0027s \"debug\" option was coopted to also indicate that the"},{"line_number":10,"context_line":"responses should include more information. A separate config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_ab6e7cc5","line":7,"updated":"2015-07-29 21:43:36.000000000","message":"responses","commit_id":"021aa2785f7dd3a16f1b063242a6ad92bc85ab1f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4c60588636258c90ae44efd1ba9623ab1e12e480","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brant Knudson \u003cbknudson@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-29 16:29:42 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Config option for insecure reponses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.log\u0027s \"debug\" option was coopted to also indicate that the"},{"line_number":10,"context_line":"responses should include more information. A separate config"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_abfe7c67","line":7,"in_reply_to":"3a50d1a3_ab6e7cc5","updated":"2015-07-29 22:12:27.000000000","message":"Done","commit_id":"021aa2785f7dd3a16f1b063242a6ad92bc85ab1f"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"5a48a16098cf95f652da7e800e37268a76265260","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Config option for insecure responses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.log\u0027s \"debug\" option was coopted to also indicate that the"},{"line_number":10,"context_line":"responses should include more information. A separate config"},{"line_number":11,"context_line":"option should be used instead so that deployers don\u0027t mistakenly"},{"line_number":12,"context_line":"expose themselves to security issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a26ad4f_ebabb01b","line":9,"updated":"2015-10-30 06:49:20.000000000","message":"coopted should be co-opted","commit_id":"afad604685b139d66199b90942a18df92c70e7a0"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bbd385f468400af09e5a77e19c8a7624342891c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Config option for insecure responses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo.log\u0027s \"debug\" option was coopted to also indicate that the"},{"line_number":10,"context_line":"responses should include more information. A separate config"},{"line_number":11,"context_line":"option should be used instead so that deployers don\u0027t mistakenly"},{"line_number":12,"context_line":"expose themselves to security issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a26ad4f_9c7280ac","line":9,"in_reply_to":"1a26ad4f_ebabb01b","updated":"2015-10-30 07:42:37.000000000","message":"Done","commit_id":"afad604685b139d66199b90942a18df92c70e7a0"}],"keystone/common/config.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"8ddf5a45436dda81de3de24e2c8af8326b8ae53a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                        \u0027\"HTTP_X_FORWARDED_PROTO\".\u0027),"},{"line_number":111,"context_line":"    ],"},{"line_number":112,"context_line":"    \u0027insecure\u0027: ["},{"line_number":113,"context_line":"        cfg.BoolOpt(\u0027debug_response\u0027, default\u003dFalse,"},{"line_number":114,"context_line":"                    help\u003d\u0027If set to true the server will return information \u0027"},{"line_number":115,"context_line":"                         \u0027in the response that may allow an unauthenticated \u0027"},{"line_number":116,"context_line":"                         \u0027or authenticated user to get more information than \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0b1bf073","line":113,"updated":"2015-07-29 21:43:36.000000000","message":"Does this really need it\u0027s own group, instead of something like insecure_debug in the default group?","commit_id":"021aa2785f7dd3a16f1b063242a6ad92bc85ab1f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4c60588636258c90ae44efd1ba9623ab1e12e480","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                        \u0027\"HTTP_X_FORWARDED_PROTO\".\u0027),"},{"line_number":111,"context_line":"    ],"},{"line_number":112,"context_line":"    \u0027insecure\u0027: ["},{"line_number":113,"context_line":"        cfg.BoolOpt(\u0027debug_response\u0027, default\u003dFalse,"},{"line_number":114,"context_line":"                    help\u003d\u0027If set to true the server will return information \u0027"},{"line_number":115,"context_line":"                         \u0027in the response that may allow an unauthenticated \u0027"},{"line_number":116,"context_line":"                         \u0027or authenticated user to get more information than \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6bd874ef","line":113,"in_reply_to":"3a50d1a3_0b1bf073","updated":"2015-07-29 22:12:27.000000000","message":"Done","commit_id":"021aa2785f7dd3a16f1b063242a6ad92bc85ab1f"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"8ddf5a45436dda81de3de24e2c8af8326b8ae53a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         \u0027in the response that may allow an unauthenticated \u0027"},{"line_number":116,"context_line":"                         \u0027or authenticated user to get more information than \u0027"},{"line_number":117,"context_line":"                         \u0027normal, such as why authentication failed. This may \u0027"},{"line_number":118,"context_line":"                         \u0027be useful for debugging in extreme circumstances \u0027"},{"line_number":119,"context_line":"                         \u0027but is insecure.\u0027),"},{"line_number":120,"context_line":"    ],"},{"line_number":121,"context_line":"    \u0027identity\u0027: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0b3210f2","line":118,"updated":"2015-07-29 21:43:36.000000000","message":"it\u0027s not a particularly extreme circumstance, IMO","commit_id":"021aa2785f7dd3a16f1b063242a6ad92bc85ab1f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4c60588636258c90ae44efd1ba9623ab1e12e480","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         \u0027in the response that may allow an unauthenticated \u0027"},{"line_number":116,"context_line":"                         \u0027or authenticated user to get more information than \u0027"},{"line_number":117,"context_line":"                         \u0027normal, such as why authentication failed. This may \u0027"},{"line_number":118,"context_line":"                         \u0027be useful for debugging in extreme circumstances \u0027"},{"line_number":119,"context_line":"                         \u0027but is insecure.\u0027),"},{"line_number":120,"context_line":"    ],"},{"line_number":121,"context_line":"    \u0027identity\u0027: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_cbef4885","line":118,"in_reply_to":"3a50d1a3_0b3210f2","updated":"2015-07-29 22:12:27.000000000","message":"Done","commit_id":"021aa2785f7dd3a16f1b063242a6ad92bc85ab1f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d5ff3beab78c1398387fb0f7e2d0528ee778295a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         \u0027in the response that may allow an unauthenticated \u0027"},{"line_number":116,"context_line":"                         \u0027or authenticated user to get more information than \u0027"},{"line_number":117,"context_line":"                         \u0027normal, such as why authentication failed. This may \u0027"},{"line_number":118,"context_line":"                         \u0027be useful for debugging but is insecure.\u0027),"},{"line_number":119,"context_line":"    ],"},{"line_number":120,"context_line":"    \u0027identity\u0027: ["},{"line_number":121,"context_line":"        cfg.StrOpt(\u0027default_domain_id\u0027, default\u003d\u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_1e0ceb39","line":118,"updated":"2016-01-05 22:10:36.000000000","message":"and should be used with caution in production environments.","commit_id":"2afad4dc30cd1e210f2353ce987fe1bbdd8b93d7"}],"keystone/exception.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d5ff3beab78c1398387fb0f7e2d0528ee778295a","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"class SecurityError(Error):"},{"line_number":164,"context_line":"    \"\"\"Avoids exposing details of security failures, unless in insecure_debug"},{"line_number":165,"context_line":"    mode."},{"line_number":166,"context_line":"    \"\"\""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_be3cbfc8","line":164,"updated":"2016-01-05 22:10:36.000000000","message":"suggest keeping this to one line.","commit_id":"2afad4dc30cd1e210f2353ce987fe1bbdd8b93d7"}],"keystone/tests/unit/test_exception.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"5b5dee13b52424f9f918fcff5c5af301f2fe4c67","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.config_fixture \u003d self.useFixture(config_fixture.Config(cfg.CONF))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def test_unexpected_error_no_debug(self):"},{"line_number":121,"context_line":"        self.config_fixture.config(debug\u003dFalse)"},{"line_number":122,"context_line":"        e \u003d exception.UnexpectedError(exception\u003dself.exc_str)"},{"line_number":123,"context_line":"        self.assertNotIn(self.exc_str, six.text_type(e))"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_50629bd9","side":"PARENT","line":121,"updated":"2015-10-04 03:00:43.000000000","message":"(nit) We could keep setting them explicitly to False, so the test is easier to understand ?","commit_id":"df2bd8cb3e9b69aa3bbf32a4ccca62abc41d2e11"}]}