)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b1f5b63e7235abd613d81055f50944489feec7b7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-29 22:53:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes Py3 string/bytes issues for tokens"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43d0abae8674e6ad6b9fcbc999022ccefe90951f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_48221e03","line":8,"updated":"2015-07-31 03:39:13.000000000","message":"If this patch happened to fix this bug (https://bugs.launchpad.net/keystone/+bug/1463727), feel free to include this in the commit message and close it, thanks.","commit_id":"551d9d25329afdd2690040129d42ed86319eae31"},{"author":{"_account_id":15830,"name":"jiaxi","email":"jiaxi@unitedstack.com","username":"jiaxi"},"change_message_id":"b8c2f911f64e9b133bde9c21d34d1cb01defb15e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-29 22:53:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes Py3 string/bytes issues for tokens"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43d0abae8674e6ad6b9fcbc999022ccefe90951f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_885d867b","line":8,"updated":"2015-07-31 03:40:37.000000000","message":"Why had no bug_id or bp_id in the commit log?","commit_id":"551d9d25329afdd2690040129d42ed86319eae31"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0fcae020f5076b5759a30da2a5f345c7d56d2386","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-07-29 22:53:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes Py3 string/bytes issues for tokens"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43d0abae8674e6ad6b9fcbc999022ccefe90951f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_a82f22a6","line":8,"in_reply_to":"3a50d1a3_885d867b","updated":"2015-07-31 03:51:38.000000000","message":"This will have a bp when i\u0027m ready to actually commit. Not all reviews will have a bug or bp. Refactorings for instance.","commit_id":"551d9d25329afdd2690040129d42ed86319eae31"}],"keystone/token/providers/common.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b1f5b63e7235abd613d81055f50944489feec7b7","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                                   utils.isotime(subsecond\u003dTrue))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _populate_audit_info(self, token_data, audit_info\u003dNone):"},{"line_number":402,"context_line":"        if audit_info is None or isinstance(audit_info, six.binary_type):"},{"line_number":403,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d provider.audit_info(audit_info)"},{"line_number":404,"context_line":"        elif isinstance(audit_info, list):"},{"line_number":405,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d audit_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_c815ce9b","line":402,"updated":"2015-07-31 03:39:13.000000000","message":"This will fail tempest case, tempest.api.identity.admin.v3.test_tokens.TokensV3TestJSON.test_rescope_token\n\naudit info is built from two place,\n\n1. The mod: random_urlsafe_str, return byte and is okay.\n\n2. Inherited from the exsiting token as what the tempest case did.\nIn this case, the audit info is built from the info fetched from the DB, and the type of audit info is unicode instead of byte, unless we tweak it, it won\u0027t pass the tempest test.\n\nIn python2, both str and unicode is the subclass of basestring, but obviously unicode is not the instance of the str (six.binary_type).","commit_id":"551d9d25329afdd2690040129d42ed86319eae31"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7cb72942356a327cd9d36ecc26d9481c36199151","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                                   utils.isotime(subsecond\u003dTrue))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _populate_audit_info(self, token_data, audit_info\u003dNone):"},{"line_number":402,"context_line":"        if audit_info is None or isinstance(audit_info, six.binary_type):"},{"line_number":403,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d provider.audit_info(audit_info)"},{"line_number":404,"context_line":"        elif isinstance(audit_info, list):"},{"line_number":405,"context_line":"            token_data[\u0027audit_ids\u0027] \u003d audit_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_e8044a19","line":402,"in_reply_to":"3a50d1a3_c815ce9b","updated":"2015-07-31 03:54:20.000000000","message":"Good to know. I\u0027ll try to fetch it from the DB correctly. IMO using string_types anywhere means that there is a serious problem somewhere.","commit_id":"551d9d25329afdd2690040129d42ed86319eae31"}],"tox.ini":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b1f5b63e7235abd613d81055f50944489feec7b7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      keystone/tests/unit/token/test_uuid_provider.py"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"#      keystone/tests/unit/token/test_fernet_provider.py"},{"line_number":53,"context_line":"#      keystone/tests/unit/token/test_provider.py"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"[testenv:pep8]"},{"line_number":56,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a50d1a3_a8772207","line":53,"updated":"2015-07-31 03:39:13.000000000","message":"remove these test modules if these are not ready to go.","commit_id":"551d9d25329afdd2690040129d42ed86319eae31"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7cb72942356a327cd9d36ecc26d9481c36199151","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      keystone/tests/unit/token/test_uuid_provider.py"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"#      keystone/tests/unit/token/test_fernet_provider.py"},{"line_number":53,"context_line":"#      keystone/tests/unit/token/test_provider.py"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"[testenv:pep8]"},{"line_number":56,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a50d1a3_830c873c","line":53,"in_reply_to":"3a50d1a3_a8772207","updated":"2015-07-31 03:54:20.000000000","message":"yep, this patch isn\u0027t quite ready for merging. i only pushed it to some of the others could get a preview of the fernet changes.","commit_id":"551d9d25329afdd2690040129d42ed86319eae31"}]}