)]}'
{"keystone/common/validation/__init__.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"6801aa87ecf6a015299748f4765beba231bf3ac7","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param request_body_schema: a schema to validate the resource reference"},{"line_number":28,"context_line":"    :param resource_to_validate: the reference to validate"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    schema_validator \u003d validators.SchemaValidator(request_body_schema)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_967adeb8","line":29,"updated":"2015-08-13 07:37:12.000000000","message":"And I think you need the comment the TypeError in Docstring since I got the same comment from patch (#195903).","commit_id":"6b2100e1e7ef4ec7abdc7b3761b2161c501d5f43"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c6f930a52dddf5e29e3b57cd90ef32246bd6cf58","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param request_body_schema: a schema to validate the resource reference"},{"line_number":28,"context_line":"    :param resource_to_validate: the reference to validate"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    schema_validator \u003d validators.SchemaValidator(request_body_schema)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f07f53a9","line":29,"in_reply_to":"1a4dcd0f_967adeb8","updated":"2015-08-14 16:10:47.000000000","message":"Done","commit_id":"6b2100e1e7ef4ec7abdc7b3761b2161c501d5f43"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"ce94a441e9d0ca4cafac04722a4e76455b6d4a83","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            arg_index \u003d argspec.args.index(resource_to_validate)"},{"line_number":37,"context_line":"        except ValueError:"},{"line_number":38,"context_line":"            raise TypeError(_(\u0027validated expected to find %(param_name)r in \u0027"},{"line_number":39,"context_line":"                              \u0027function signature for %(func_name)r\u0027) %"},{"line_number":40,"context_line":"                            {\u0027param_name\u0027: resource_to_validate,"},{"line_number":41,"context_line":"                             \u0027func_name\u0027: func.__name__})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_44cc9b34","line":38,"updated":"2015-08-13 10:12:22.000000000","message":"\u0027validated expected\u0027 does it make sense.\n\nIMO it should be either \u0027validation expected\u0027 or \u0027validator expected\u0027. Correct me if I am wrong.","commit_id":"6b2100e1e7ef4ec7abdc7b3761b2161c501d5f43"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"8e4555778309f7888f0d83331237b9b393678f9a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            arg_index \u003d argspec.args.index(resource_to_validate)"},{"line_number":37,"context_line":"        except ValueError:"},{"line_number":38,"context_line":"            raise TypeError(_(\u0027validated expected to find %(param_name)r in \u0027"},{"line_number":39,"context_line":"                              \u0027function signature for %(func_name)r\u0027) %"},{"line_number":40,"context_line":"                            {\u0027param_name\u0027: resource_to_validate,"},{"line_number":41,"context_line":"                             \u0027func_name\u0027: func.__name__})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_85c26f33","line":38,"in_reply_to":"1a4dcd0f_44cc9b34","updated":"2015-08-14 05:33:56.000000000","message":"Done","commit_id":"6b2100e1e7ef4ec7abdc7b3761b2161c501d5f43"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c6f930a52dddf5e29e3b57cd90ef32246bd6cf58","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            arg_index \u003d argspec.args.index(resource_to_validate)"},{"line_number":37,"context_line":"        except ValueError:"},{"line_number":38,"context_line":"            raise TypeError(_(\u0027validated expected to find %(param_name)r in \u0027"},{"line_number":39,"context_line":"                              \u0027function signature for %(func_name)r\u0027) %"},{"line_number":40,"context_line":"                            {\u0027param_name\u0027: resource_to_validate,"},{"line_number":41,"context_line":"                             \u0027func_name\u0027: func.__name__})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_5073a7e7","line":38,"in_reply_to":"1a4dcd0f_85c26f33","updated":"2015-08-14 16:10:47.000000000","message":"I think this is wrong. validated is the name of the decorator.","commit_id":"6b2100e1e7ef4ec7abdc7b3761b2161c501d5f43"}],"keystone/tests/unit/test_validation.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"a50614bd8ba3d48b40193e32da6d9b476f5af003","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def test_calling_with_valid_entity_kwarg_succeeds(self):"},{"line_number":122,"context_line":"        self.do_something(entity\u003dself.valid_entity)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_calling_with_invalid_entity_kwarg_fails(self):"},{"line_number":125,"context_line":"        self.assertRaises(exception.SchemaValidationError,"},{"line_number":126,"context_line":"                          self.do_something,"},{"line_number":127,"context_line":"                          entity\u003dself.invalid_entity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_56945635","line":124,"updated":"2015-08-13 07:28:05.000000000","message":"I am a little bit confused when I first saw this testcase `test_calling_with_invalid_entity_arg_fails` since this is not closely related with the bug and the fixing here.\n\nAnyway, it\u0027s no harm, I am fine with it. :)","commit_id":"6b2100e1e7ef4ec7abdc7b3761b2161c501d5f43"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f10e8355e483356c4296c0c597bb84c09465f180","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def test_calling_with_valid_entity_kwarg_succeeds(self):"},{"line_number":122,"context_line":"        self.do_something(entity\u003dself.valid_entity)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_calling_with_invalid_entity_kwarg_fails(self):"},{"line_number":125,"context_line":"        self.assertRaises(exception.SchemaValidationError,"},{"line_number":126,"context_line":"                          self.do_something,"},{"line_number":127,"context_line":"                          entity\u003dself.invalid_entity)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d7ec9694","line":124,"in_reply_to":"1a4dcd0f_56945635","updated":"2015-08-14 13:51:42.000000000","message":"This is just making sure it is working as designed and already being used.","commit_id":"6b2100e1e7ef4ec7abdc7b3761b2161c501d5f43"}]}