)]}'
{"keystone/common/controller.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"95f2dd17d11a75c053e65419899d2280a9c3f379","unresolved":false,"context_lines":[{"line_number":747,"context_line":"                      \u0027project call, but relying on falling back to the \u0027"},{"line_number":748,"context_line":"                      \u0027default domain\u0027),"},{"line_number":749,"context_line":"                in_favor_of\u003d\u0027specifying domain explicitly or using a \u0027"},{"line_number":750,"context_line":"                            \u0027domain-scoped token\u0027)(lambda: None)()"},{"line_number":751,"context_line":"            return CONF.identity.default_domain_id"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def _normalize_domain_id(self, context, ref):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_3d7c691e","line":750,"updated":"2015-09-16 15:58:50.000000000","message":"there\u0027s no need for the lambda, use report_deprecated_feature instead:\n\nhttp://docs.openstack.org/developer/oslo.log/api/versionutils.html#oslo_log.versionutils.report_deprecated_feature","commit_id":"ff303a3b73f1043e1b2d22490a13ae2d8ea42a8f"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"0de48527d170617a521a5a4068b63caa1eacca5b","unresolved":false,"context_lines":[{"line_number":747,"context_line":"                      \u0027project call, but relying on falling back to the \u0027"},{"line_number":748,"context_line":"                      \u0027default domain\u0027),"},{"line_number":749,"context_line":"                in_favor_of\u003d\u0027specifying domain explicitly or using a \u0027"},{"line_number":750,"context_line":"                            \u0027domain-scoped token\u0027)(lambda: None)()"},{"line_number":751,"context_line":"            return CONF.identity.default_domain_id"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def _normalize_domain_id(self, context, ref):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_03f82648","line":750,"in_reply_to":"ba15a1d1_3d7c691e","updated":"2015-09-16 16:45:18.000000000","message":"Yep..good idea - fixed up as suggested.","commit_id":"ff303a3b73f1043e1b2d22490a13ae2d8ea42a8f"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4bb0cffca4e43b082b510d4c8e751fb50769d250","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            # issue a deprecation warning."},{"line_number":743,"context_line":"            versionutils.report_deprecated_feature("},{"line_number":744,"context_line":"                LOG,"},{"line_number":745,"context_line":"                _LW(\u0027Not specifying a domain during a create user, group or\u0027"},{"line_number":746,"context_line":"                    \u0027project call, and relying on falling back to the \u0027"},{"line_number":747,"context_line":"                    \u0027default domain, is deprecated as of Liberty and will be\u0027"},{"line_number":748,"context_line":"                    \u0027removed in Mitaka. Specify the domain explicitly or use \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_0fe04728","line":745,"updated":"2015-09-16 18:17:16.000000000","message":"missing space at end of line","commit_id":"c7525f11e98cbeead9f3bf398b401cd763ce99c3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5150d75f3ca773425a23b4d733f5c4df0a98b53f","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            # issue a deprecation warning."},{"line_number":743,"context_line":"            versionutils.report_deprecated_feature("},{"line_number":744,"context_line":"                LOG,"},{"line_number":745,"context_line":"                _LW(\u0027Not specifying a domain during a create user, group or\u0027"},{"line_number":746,"context_line":"                    \u0027project call, and relying on falling back to the \u0027"},{"line_number":747,"context_line":"                    \u0027default domain, is deprecated as of Liberty and will be\u0027"},{"line_number":748,"context_line":"                    \u0027removed in Mitaka. Specify the domain explicitly or use \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_e4f09500","line":745,"in_reply_to":"ba15a1d1_0fe04728","updated":"2015-09-16 19:09:34.000000000","message":"Done","commit_id":"c7525f11e98cbeead9f3bf398b401cd763ce99c3"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4bb0cffca4e43b082b510d4c8e751fb50769d250","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                LOG,"},{"line_number":745,"context_line":"                _LW(\u0027Not specifying a domain during a create user, group or\u0027"},{"line_number":746,"context_line":"                    \u0027project call, and relying on falling back to the \u0027"},{"line_number":747,"context_line":"                    \u0027default domain, is deprecated as of Liberty and will be\u0027"},{"line_number":748,"context_line":"                    \u0027removed in Mitaka. Specify the domain explicitly or use \u0027"},{"line_number":749,"context_line":"                    \u0027a domain-scoped token\u0027))"},{"line_number":750,"context_line":"            return CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_cfe56f38","line":747,"updated":"2015-09-16 18:17:16.000000000","message":"missing space at end of line","commit_id":"c7525f11e98cbeead9f3bf398b401cd763ce99c3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5150d75f3ca773425a23b4d733f5c4df0a98b53f","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                LOG,"},{"line_number":745,"context_line":"                _LW(\u0027Not specifying a domain during a create user, group or\u0027"},{"line_number":746,"context_line":"                    \u0027project call, and relying on falling back to the \u0027"},{"line_number":747,"context_line":"                    \u0027default domain, is deprecated as of Liberty and will be\u0027"},{"line_number":748,"context_line":"                    \u0027removed in Mitaka. Specify the domain explicitly or use \u0027"},{"line_number":749,"context_line":"                    \u0027a domain-scoped token\u0027))"},{"line_number":750,"context_line":"            return CONF.identity.default_domain_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_84f19903","line":747,"in_reply_to":"ba15a1d1_cfe56f38","updated":"2015-09-16 19:09:34.000000000","message":"Done","commit_id":"c7525f11e98cbeead9f3bf398b401cd763ce99c3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3f238cfd91da9b3070015c57f092be51ee74c2fe","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                    \u0027project call, and relying on falling back to the \u0027"},{"line_number":747,"context_line":"                    \u0027default domain, is deprecated as of Liberty and will be \u0027"},{"line_number":748,"context_line":"                    \u0027removed in Mitaka. Specify the domain explicitly or use \u0027"},{"line_number":749,"context_line":"                    \u0027a domain-scoped token\u0027))"},{"line_number":750,"context_line":"            return CONF.identity.default_domain_id"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def _normalize_domain_id(self, context, ref):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_f09dab66","line":749,"updated":"2015-09-16 21:05:59.000000000","message":"2-cycle deprecation on API changes.","commit_id":"9ea9e588cff2d58e6aa75fe526e59b8c22c7abdc"}],"keystone/tests/unit/test_v3_identity.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4bb0cffca4e43b082b510d4c8e751fb50769d250","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # issued. Change the code below to expect a failure once this bug is"},{"line_number":106,"context_line":"        # fixed."},{"line_number":107,"context_line":"        mock_dep \u003d mock.Mock()"},{"line_number":108,"context_line":"        with mock.patch(\u0027keystone.common.controller.versionutils.\u0027"},{"line_number":109,"context_line":"                        \u0027report_deprecated_feature\u0027,"},{"line_number":110,"context_line":"                        mock_dep):"},{"line_number":111,"context_line":"            r \u003d self.post(\u0027/users\u0027, body\u003d{\u0027user\u0027: ref_nd}, auth\u003dauth)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_af659bb5","line":108,"updated":"2015-09-16 18:17:16.000000000","message":"this should be using oslo_log.versionutils rather than rely on the name in keystone.common.controller.\n\nAlso, if mock.patch.object was used then could have a shorter line.\n\nAlso, no need to create the Mock yourself since mock.patch creates one by default, just put \"as mock_dep\" on the with statement.","commit_id":"c7525f11e98cbeead9f3bf398b401cd763ce99c3"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"5150d75f3ca773425a23b4d733f5c4df0a98b53f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        # issued. Change the code below to expect a failure once this bug is"},{"line_number":106,"context_line":"        # fixed."},{"line_number":107,"context_line":"        mock_dep \u003d mock.Mock()"},{"line_number":108,"context_line":"        with mock.patch(\u0027keystone.common.controller.versionutils.\u0027"},{"line_number":109,"context_line":"                        \u0027report_deprecated_feature\u0027,"},{"line_number":110,"context_line":"                        mock_dep):"},{"line_number":111,"context_line":"            r \u003d self.post(\u0027/users\u0027, body\u003d{\u0027user\u0027: ref_nd}, auth\u003dauth)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_048fc975","line":108,"in_reply_to":"ba15a1d1_af659bb5","updated":"2015-09-16 19:09:34.000000000","message":"Changed to patch the oslo version (and removed the extra mock)...but could not make patch.object version work...hopefully this is good enough","commit_id":"c7525f11e98cbeead9f3bf398b401cd763ce99c3"}]}