)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"de653ddd1ecdde0069b66291c86fb819ab553ea8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to provide an expected exception to `wip` decorator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sometimes it is needed to expose a bug with a test and show that a"},{"line_number":10,"context_line":"specific exception occurs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add a parameter to `wip` decorator which allows to pass an exception"},{"line_number":13,"context_line":"that will be caught. Any other exception will cause the test to fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_76f35574","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":26},"updated":"2016-01-21 03:05:45.000000000","message":"Can\u0027t this be done by writing the test to expect the specific exception with a note/fixme saying that it needs to be addressed (these usually link to a bug report, too).","commit_id":"5b5cb35a00fb242deb6fcb4c961c6baf566cdbe3"}],"keystone/tests/unit/utils.py":[{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"3ab6fdffa7625790c0c4cee78b347dbc7a47efb0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                f(*args, **kwargs)"},{"line_number":83,"context_line":"            except expected_exception:"},{"line_number":84,"context_line":"                raise testcase.TestSkipped(\u0027work in progress test failed: \u0027 +"},{"line_number":85,"context_line":"                                           message)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            raise AssertionError(\u0027work in progress test passed: \u0027 + message)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_ffbabc09","line":85,"updated":"2015-08-10 12:56:39.000000000","message":"Let me know if I am straying from what you are thinking, but what if you have 2 exceptions, 1 catching the \u0027expected_exception\u0027 and one catching \u0027Exception\u0027  so we don\u0027t have to worry about the program crashing if the expected exception is not passed in.","commit_id":"5b5cb35a00fb242deb6fcb4c961c6baf566cdbe3"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"c6a32c8e48ba5b8d72d311faa2875577bae5a28f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                f(*args, **kwargs)"},{"line_number":83,"context_line":"            except expected_exception:"},{"line_number":84,"context_line":"                raise testcase.TestSkipped(\u0027work in progress test failed: \u0027 +"},{"line_number":85,"context_line":"                                           message)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            raise AssertionError(\u0027work in progress test passed: \u0027 + message)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_13dd2414","line":85,"in_reply_to":"1a4dcd0f_33ece028","updated":"2015-08-10 13:20:06.000000000","message":"Okay, I just wanted to bring it up to make sure it has been thought about, Thanks for responding quickly","commit_id":"5b5cb35a00fb242deb6fcb4c961c6baf566cdbe3"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"81eb81cc5e46cdb2d1d53db0b3f742afaa6b0693","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                f(*args, **kwargs)"},{"line_number":83,"context_line":"            except expected_exception:"},{"line_number":84,"context_line":"                raise testcase.TestSkipped(\u0027work in progress test failed: \u0027 +"},{"line_number":85,"context_line":"                                           message)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            raise AssertionError(\u0027work in progress test passed: \u0027 + message)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_33ece028","line":85,"in_reply_to":"1a4dcd0f_ffbabc09","updated":"2015-08-10 13:14:05.000000000","message":"\u003e so we don\u0027t have to worry about the program crashing\n\nThat\u0027s the point of this -- to crash and show that the problem is not where we expect it to be, failing the test.","commit_id":"5b5cb35a00fb242deb6fcb4c961c6baf566cdbe3"}]}