)]}'
{"keystone/common/sql/migrate_repo/versions/076_migrate_domains_to_projects.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4f8b2b8434ff500cd93a9834c9153a875bfdfb3e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade(migrate_engine):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _get_project_from_domain(domain):"},{"line_number":34,"context_line":"        \"\"\"Creates an is_domain project ref from the provided domain.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # \u0027description\u0027 property is an extra attritbute in domains"},{"line_number":37,"context_line":"        description \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_b8a9ae7d","line":34,"updated":"2015-08-18 17:23:03.000000000","message":"a project acting as a domain","commit_id":"10f2bc8dc4a0f40795fd982ccdd80fa18d6099e3"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"adf88599cde0370ffea8700edfaf9f419520b9c4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade(migrate_engine):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _get_project_from_domain(domain):"},{"line_number":34,"context_line":"        \"\"\"Creates an is_domain project ref from the provided domain.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # \u0027description\u0027 property is an extra attritbute in domains"},{"line_number":37,"context_line":"        description \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_d48e71cf","line":34,"in_reply_to":"fa1b9901_b8a9ae7d","updated":"2015-08-19 17:43:33.000000000","message":"Done","commit_id":"10f2bc8dc4a0f40795fd982ccdd80fa18d6099e3"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4f8b2b8434ff500cd93a9834c9153a875bfdfb3e","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    projects \u003d list(project_table.select().execute())"},{"line_number":79,"context_line":"    for project in projects:"},{"line_number":80,"context_line":"        if (project.parent_id is None and not project.is_domain):"},{"line_number":81,"context_line":"            # Update the project parent_id to be its domain_id"},{"line_number":82,"context_line":"            values \u003d {\u0027parent_id\u0027: project.domain_id}"},{"line_number":83,"context_line":"            update \u003d project_table.update().where("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_b8d76eec","line":80,"updated":"2015-08-18 17:23:03.000000000","message":"why not perform this before inserting the domains in the project table?\n\nalso, unnecessary () in the if statement","commit_id":"10f2bc8dc4a0f40795fd982ccdd80fa18d6099e3"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e5cd98656ca426f2a52ef89aab49b566823be565","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    projects \u003d list(project_table.select().execute())"},{"line_number":79,"context_line":"    for project in projects:"},{"line_number":80,"context_line":"        if (project.parent_id is None and not project.is_domain):"},{"line_number":81,"context_line":"            # Update the project parent_id to be its domain_id"},{"line_number":82,"context_line":"            values \u003d {\u0027parent_id\u0027: project.domain_id}"},{"line_number":83,"context_line":"            update \u003d project_table.update().where("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_477151a7","line":80,"in_reply_to":"fa1b9901_946a39ed","updated":"2015-08-19 17:45:00.000000000","message":"you are going to iterate over unnecessary projects here if you insert the domains first","commit_id":"10f2bc8dc4a0f40795fd982ccdd80fa18d6099e3"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"adf88599cde0370ffea8700edfaf9f419520b9c4","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    projects \u003d list(project_table.select().execute())"},{"line_number":79,"context_line":"    for project in projects:"},{"line_number":80,"context_line":"        if (project.parent_id is None and not project.is_domain):"},{"line_number":81,"context_line":"            # Update the project parent_id to be its domain_id"},{"line_number":82,"context_line":"            values \u003d {\u0027parent_id\u0027: project.domain_id}"},{"line_number":83,"context_line":"            update \u003d project_table.update().where("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_946a39ed","line":80,"in_reply_to":"fa1b9901_b8d76eec","updated":"2015-08-19 17:43:33.000000000","message":"I think it is more logical we first insert the domains, and then point to them. removed the ()","commit_id":"10f2bc8dc4a0f40795fd982ccdd80fa18d6099e3"}]}
