)]}'
{"keystone/common/sql/migrate_repo/versions/074_create_cached_policy.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c14c85c2cb95d2de67f3b7fe45f430b81ae46213","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        sql.Column(\u0027extra\u0027, sql.JsonBlob()),"},{"line_number":32,"context_line":"        sql.Column(\u0027valid_to\u0027, sql.DateTime, nullable\u003dFalse),"},{"line_number":33,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":34,"context_line":"        mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    policy_cache_table.create(migrate_engine, checkfirst\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_1e061886","line":34,"updated":"2015-08-20 14:10:49.000000000","message":"this will need a test added to sql_upgrades.py I think.","commit_id":"f776d3ca98d0492ef6bbf462f87d099c6a4e8ea2"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"e7c77158c07d05f4d4c4f8d25d5f330bb464fa98","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        sql.Column(\u0027extra\u0027, sql.JsonBlob()),"},{"line_number":32,"context_line":"        sql.Column(\u0027valid_to\u0027, sql.DateTime, nullable\u003dFalse),"},{"line_number":33,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":34,"context_line":"        mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    policy_cache_table.create(migrate_engine, checkfirst\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_761d7065","line":34,"in_reply_to":"fa1b9901_1e061886","updated":"2015-08-24 13:15:17.000000000","message":"As it isn\u0027t in the initial tables structure (collapsed migrations), and the is no data migrated to this table, I think there is no test to be added there, do you agree?","commit_id":"f776d3ca98d0492ef6bbf462f87d099c6a4e8ea2"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"1f552d677bf96dcdd65a64f665bcec68b2449e30","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        sql.Column(\u0027extra\u0027, sql.JsonBlob()),"},{"line_number":32,"context_line":"        sql.Column(\u0027valid_to\u0027, sql.DateTime, nullable\u003dFalse),"},{"line_number":33,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":34,"context_line":"        mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    policy_cache_table.create(migrate_engine, checkfirst\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_7c872ab5","line":34,"in_reply_to":"fa1b9901_761d7065","updated":"2015-08-26 09:01:32.000000000","message":"but the testcase in test_sql_upgrades.py is used to test that the table is created, column is correct, this can also be applied to the initial tables like this.","commit_id":"f776d3ca98d0492ef6bbf462f87d099c6a4e8ea2"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"2d076c839ddedda514795ff0c4cefe551f1dbc08","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        sql.Column(\u0027extra\u0027, sql.JsonBlob()),"},{"line_number":32,"context_line":"        sql.Column(\u0027valid_to\u0027, sql.DateTime, nullable\u003dFalse),"},{"line_number":33,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":34,"context_line":"        mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    policy_cache_table.create(migrate_engine, checkfirst\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_3b53ee18","line":34,"in_reply_to":"fa1b9901_7c872ab5","updated":"2015-08-26 12:29:40.000000000","message":"This isn\u0027t an initial table. The initial tables are the ones created by the first migration script, which is a collapsed one.\n\nI am testing the table structure already, see the file keystone/tests/unit/backend/policy/test_sql.py in this patchset.","commit_id":"f776d3ca98d0492ef6bbf462f87d099c6a4e8ea2"}],"keystone/policy/backends/sql.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"2cbb965c20a43461d327273e815ac9b9f6c72d80","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    id \u003d sql.Column(sql.String(64), primary_key\u003dTrue)"},{"line_number":33,"context_line":"    blob \u003d sql.Column(sql.JsonBlob(), nullable\u003dFalse)"},{"line_number":34,"context_line":"    type \u003d sql.Column(sql.String(255), nullable\u003dFalse)"},{"line_number":35,"context_line":"    extra \u003d sql.Column(sql.JsonBlob())"},{"line_number":36,"context_line":"    valid_to \u003d sql.Column(sql.DateTime, nullable\u003dFalse)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_a100cbab","line":35,"updated":"2015-09-25 02:44:12.000000000","message":"What do you need extra for here?","commit_id":"f776d3ca98d0492ef6bbf462f87d099c6a4e8ea2"}]}