)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"ca8a560c1c331915948c443e6ae2c0b02c4a9657","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roxana Gherle \u003croxana.gherle@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-13 15:17:15 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Domain configs are loaded with wrong type from db"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When loading domain configuration from database we are changing"},{"line_number":10,"context_line":"the actual data type of the configuration to unicode string. We"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_53bf5a60","line":7,"updated":"2015-08-13 22:48:26.000000000","message":"\"config override to maintain types\"   or something along those lines.","commit_id":"d4dacd0ca766ffc346ce74b958114fefbd786300"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"d5e40ab29016e2d8564cf6226e5af7cbe5ade521","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roxana Gherle \u003croxana.gherle@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-13 15:17:15 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Domain configs are loaded with wrong type from db"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When loading domain configuration from database we are changing"},{"line_number":10,"context_line":"the actual data type of the configuration to unicode string. We"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_76c6046a","line":7,"in_reply_to":"1a4dcd0f_53bf5a60","updated":"2015-08-13 23:15:15.000000000","message":"Done","commit_id":"d4dacd0ca766ffc346ce74b958114fefbd786300"}],"keystone/identity/core.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"ca8a560c1c331915948c443e6ae2c0b02c4a9657","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            for option in specific_config[group]:"},{"line_number":203,"context_line":"                domain_config[\u0027cfg\u0027].set_override("},{"line_number":204,"context_line":"                    option, specific_config[group][option],"},{"line_number":205,"context_line":"                    group, enforce_type\u003dTrue)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        domain_config[\u0027cfg_overrides\u0027] \u003d specific_config"},{"line_number":208,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_937c02b7","line":205,"updated":"2015-08-13 22:48:26.000000000","message":"Do you ever want to have this value be false?","commit_id":"d4dacd0ca766ffc346ce74b958114fefbd786300"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"d5e40ab29016e2d8564cf6226e5af7cbe5ade521","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            for option in specific_config[group]:"},{"line_number":203,"context_line":"                domain_config[\u0027cfg\u0027].set_override("},{"line_number":204,"context_line":"                    option, specific_config[group][option],"},{"line_number":205,"context_line":"                    group, enforce_type\u003dTrue)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        domain_config[\u0027cfg_overrides\u0027] \u003d specific_config"},{"line_number":208,"context_line":"        domain_config[\u0027driver\u0027] \u003d self._load_driver(domain_config)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_b63d6c2e","line":205,"in_reply_to":"1a4dcd0f_937c02b7","updated":"2015-08-13 23:15:15.000000000","message":"My only thought about a case when we want it to be False is when we have a None value and we don\u0027t want to convert it to the string \u0027None\u0027 if the config is a StrOpt, but I am almost sure that at this point all config values are unicode type, so that shouldn\u0027t be a possibility.","commit_id":"d4dacd0ca766ffc346ce74b958114fefbd786300"}]}