)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6f9f2fc7c2cd599795707d4150a28c205d909da8","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if modlist:"},{"line_number":315,"context_line":"            conn \u003d self.get_connection()"},{"line_number":316,"context_line":"            conn.modify_s(self._id_to_dn(id), modlist)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def delete(self, id):"},{"line_number":319,"context_line":"        if not self.allow_delete:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FEzA%3D","line":316,"updated":"2013-02-07 22:15:05.000000000","message":"just wondering if you considered putting the check for empty modlist in conn.modify_s (LdapWrapper) rather than requiring all callers to ensure modlist is not empty.","commit_id":"2930a289773c8c6124971bed66216db91d48c70d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"565cccb1c8ee4b383ebec2d6941433fc671a04c3","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if modlist:"},{"line_number":315,"context_line":"            conn \u003d self.get_connection()"},{"line_number":316,"context_line":"            conn.modify_s(self._id_to_dn(id), modlist)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def delete(self, id):"},{"line_number":319,"context_line":"        if not self.allow_delete:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FDic%3D","line":316,"in_reply_to":"AAAAM3%2F%2FD9E%3D","updated":"2013-02-08 19:23:27.000000000","message":"I don\u0027t have a preference on whether it should be here or in the wrapper. I just wanted you to consider it if you hadn\u0027t already. It\u0027s easy to move later if this bites us again.","commit_id":"2930a289773c8c6124971bed66216db91d48c70d"},{"author":{"_account_id":5575,"name":"Jose Castro Leon","email":"jose.castro.leon@cern.ch","username":"jose-castro-leon"},"change_message_id":"3242996af6d6400b2cedc78d60e5305447ed6005","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if modlist:"},{"line_number":315,"context_line":"            conn \u003d self.get_connection()"},{"line_number":316,"context_line":"            conn.modify_s(self._id_to_dn(id), modlist)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def delete(self, id):"},{"line_number":319,"context_line":"        if not self.allow_delete:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FD9E%3D","line":316,"in_reply_to":"AAAAM3%2F%2FEzA%3D","updated":"2013-02-08 13:37:53.000000000","message":"I put it here because it is also applicable to fakeldap and LdapWrapper, but if you think that is better in the latter one.","commit_id":"2930a289773c8c6124971bed66216db91d48c70d"}]}